From d54fb3e12cd7bf6f261ebf9de939ad755607ad1f Mon Sep 17 00:00:00 2001
From: Alex Andreev <alex.andreev.email@gmail.com>
Date: Wed, 8 Jun 2022 11:36:32 +0300
Subject: [PATCH] Use lefecycleEnum.singleton and bit of cleaning up

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
---
 .../extension-preference-items.injectable.ts        | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/renderer/components/+preferences/extension-preference-items.injectable.ts b/src/renderer/components/+preferences/extension-preference-items.injectable.ts
index 5e54ce45ac..47682ab074 100644
--- a/src/renderer/components/+preferences/extension-preference-items.injectable.ts
+++ b/src/renderer/components/+preferences/extension-preference-items.injectable.ts
@@ -26,16 +26,17 @@ const extensionsPreferenceItemsInjectable = getInjectable({
     const extensions = di.inject(rendererExtensionsInjectable);
     const { extensionId, tabId } = pathParams.get();
     const extension = extensions.get().find((extension) => extension.sanitizedExtensionId === extensionId);
+
+    if (!extension) {
+      return computed(() => []);
+    }
+  
     const preferences = extension.appPreferences.map(preference => ({
-      id: preference.id,
+      id: preference.id || preference.title,
       ...preference,
     }));
 
     return computed(() => {
-      if (!extension) {
-        return [];
-      }
-
       if (tabId) {
         return preferences.filter(preference => preference.showInPreferencesTab == tabId);
       }
@@ -43,7 +44,7 @@ const extensionsPreferenceItemsInjectable = getInjectable({
       return preferences.filter(preference => !preference.showInPreferencesTab);
     });
   },
-  lifecycle: lifecycleEnum.transient,
+  lifecycle: lifecycleEnum.singleton,
 });
 
 export default extensionsPreferenceItemsInjectable;