hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Try making UI unit testable in Ubuntu by removing usage of component which uses an experimental browser feature

Browse Source 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2021-11-16 13:31:36 +02:00
parent 550abfcc0d
commit d592848a7f
2 changed files with 25 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/renderer/components/kube-object-menu/kube-object-menu.test.tsx
View File

@ -55,16 +55,6 @@ describe("kube-object-menu", () => {
render = renderFor(di); render = renderFor(di);
// TODO: Remove illegal global overwrites for what should be a dependency somewhere.
// TODO: Remove usage of experimental browser API.
window.requestIdleCallback = (callback: IdleRequestCallback): number => {
callback(undefined);
return undefined;
};
window.cancelIdleCallback = () => {};
di.override(clusterInjectable, { di.override(clusterInjectable, {
name: "Some name", name: "Some name",
}); });

52
src/renderer/components/menu/menu-actions.tsx
View File

@ -30,7 +30,6 @@ import { Icon, IconProps } from "../icon";
import { Menu, MenuItem, MenuProps } from "../menu"; import { Menu, MenuItem, MenuProps } from "../menu";
import uniqueId from "lodash/uniqueId"; import uniqueId from "lodash/uniqueId";
import isString from "lodash/isString"; import isString from "lodash/isString";
import { RenderDelay } from "../render-delay/render-delay";
export interface MenuActionsProps extends Partial<MenuProps> { export interface MenuActionsProps extends Partial<MenuProps> {
className?: string; className?: string;
@ -125,32 +124,31 @@ export class MenuActions extends React.Component<MenuActionsProps> {
return ( return (
<> <>
{this.renderTriggerIcon()} {this.renderTriggerIcon()}
<RenderDelay>
<Menu <Menu
htmlFor={this.id} htmlFor={this.id}
isOpen={this.isOpen} open={this.toggle} close={this.toggle} isOpen={this.isOpen} open={this.toggle} close={this.toggle}
className={menuClassName} className={menuClassName}
usePortal={autoClose} usePortal={autoClose}
closeOnScroll={autoClose} closeOnScroll={autoClose}
closeOnClickItem={autoCloseOnSelect ?? autoClose } closeOnClickItem={autoCloseOnSelect ?? autoClose }
closeOnClickOutside={autoClose} closeOnClickOutside={autoClose}
{...menuProps} {...menuProps}
> >
{children} {children}
{updateAction && ( {updateAction && (
<MenuItem onClick={updateAction}> <MenuItem onClick={updateAction}>
<Icon material="edit" interactive={toolbar} tooltip="Edit"/> <Icon material="edit" interactive={toolbar} tooltip="Edit"/>
<span className="title">Edit</span> <span className="title">Edit</span>
</MenuItem> </MenuItem>
)} )}
{removeAction && ( {removeAction && (
<MenuItem onClick={this.remove} data-testid="menu-action-remove"> <MenuItem onClick={this.remove} data-testid="menu-action-remove">
<Icon material="delete" interactive={toolbar} tooltip="Delete"/> <Icon material="delete" interactive={toolbar} tooltip="Delete"/>
<span className="title">Delete</span> <span className="title">Delete</span>
</MenuItem> </MenuItem>
)} )}
</Menu> </Menu>
</RenderDelay>
</> </>
); );
} }