Copy detected metadata from cluster to catalog cluster (#7316)

* Copy detected metadata from cluster to catalog cluster Signed-off-by: Juho Heikka <juho.heikka@gmail.com> * Remove duplicate copyright comment Signed-off-by: Juho Heikka <juho.heikka@gmail.com> * Lint fixes Signed-off-by: Juho Heikka <juho.heikka@gmail.com> * Typescript fix Signed-off-by: Juho Heikka <juho.heikka@gmail.com> --------- Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
2025-05-20 05:10:56 +00:00 · 2023-03-09 09:06:43 +02:00
1 parent 48ce558420
commit d5a124bd79
@@ -0,0 +1,154 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import type { AppPaths } from "../../common/app-paths/app-path-injection-token";
+import appPathsStateInjectable from "../../common/app-paths/app-paths-state.injectable";
+import directoryForUserDataInjectable from "../../common/app-paths/directory-for-user-data/directory-for-user-data.injectable";
+import { KubernetesCluster } from "../../common/catalog-entities";
+import type { Cluster } from "../../common/cluster/cluster";
+import { createClusterInjectionToken } from "../../common/cluster/create-cluster-injection-token";
+import { getDiForUnitTesting } from "../getDiForUnitTesting";
+import type { UpdateEntitySpec } from "./update-entity-spec.injectable";
+import updateEntitySpecInjectable from "./update-entity-spec.injectable";
+
+describe("update-entity-spec", () => {
+  let cluster: Cluster;
+  let entity: KubernetesCluster;
+  let updateEntitySpec: UpdateEntitySpec;
+
+  beforeEach(() => {
+    const di = getDiForUnitTesting();
+
+    di.override(directoryForUserDataInjectable, () => "/some-user-store-path");
+    di.override(appPathsStateInjectable, () => ({
+      get: () => ({} as AppPaths),
+      set: () => {},
+    }));
+    const createCluster = di.inject(createClusterInjectionToken);
+
+    updateEntitySpec = di.inject(updateEntitySpecInjectable);
+
+    cluster = createCluster({
+      id: "some-id",
+      contextName: "some-context",
+      kubeConfigPath: "minikube-config.yml",
+    }, {
+      clusterServerUrl: "foo",
+    });
+
+    entity = new KubernetesCluster({
+      metadata: {
+        uid: "some-uid",
+        name: "some-name",
+        labels: {},
+      },
+      spec: {
+        kubeconfigContext: "some-context",
+        kubeconfigPath: "/some/path/to/kubeconfig",
+      },
+      status: {
+        phase: "connecting",
+      },
+    });
+  });
+
+  it("given cluster has icon, updates entity spec with icon", () => {
+    cluster.preferences.icon = "some-icon";
+    updateEntitySpec(entity, cluster);
+    expect(entity.spec.icon?.src).toEqual("some-icon");
+  });
+
+  it("given cluster icon is null, deletes icon from both", () => {
+    cluster.preferences.icon = null;
+    entity.spec.icon = { src : "some-icon" };
+
+    updateEntitySpec(entity, cluster);
+    expect(entity.spec.icon).toBeUndefined();
+    expect(cluster.preferences.icon).toBeUndefined();
+  });
+
+  it("given entity has no metrics, adds source as local", () => {
+    updateEntitySpec(entity, cluster);
+    expect(entity.spec.metrics?.source).toEqual("local");
+  });
+
+  it("given entity has metrics, does not change source", () => {
+    entity.spec.metrics = { source: "some-source" };
+    entity.spec.metrics.prometheus = {
+      address: {
+        namespace: "some-namespace",
+        port: 42,
+        service: "some-service",
+        prefix: "some-prefix",
+      },
+    };
+
+    cluster.preferences.prometheus = {
+      namespace: "some-other-namespace",
+      port: 666,
+      service: "some-other-service",
+      prefix: "some-other-prefix",
+    };
+
+    updateEntitySpec(entity, cluster);
+
+    expect(entity.spec.metrics?.source).toEqual("some-source");
+    expect(entity.spec.metrics?.prometheus?.address).toEqual({
+      namespace: "some-namespace",
+      port: 42,
+      service: "some-service",
+      prefix: "some-prefix",
+    });
+  });
+
+  it("given entity has local prometheus source, updates entity spec with prometheus provider", () => {
+    entity.spec.metrics = { source: "local" };
+
+    cluster.preferences.prometheusProvider = {
+      type: "some-prometheus-provider-type",
+    };
+    cluster.preferences.prometheus = {
+      namespace: "some-namespace",
+      port: 42,
+      service: "some-service",
+      prefix: "some-prefix",
+    };
+
+    updateEntitySpec(entity, cluster);
+    expect(entity.spec.metrics?.prometheus?.address).toEqual({
+      namespace: "some-namespace",
+      port: 42,
+      service: "some-service",
+      prefix: "some-prefix",
+    });
+
+    expect(entity.spec.metrics?.prometheus?.type).toEqual("some-prometheus-provider-type");
+  });
+
+  it("given entity has no metrics, updates entity spec with prometheus provider", () => {
+    expect(entity.spec.metrics).toBeUndefined();
+
+    cluster.preferences.prometheusProvider = {
+      type: "some-prometheus-provider-type",
+    };
+    cluster.preferences.prometheus = {
+      namespace: "some-namespace",
+      port: 42,
+      service: "some-service",
+      prefix: "some-prefix",
+    };
+
+    updateEntitySpec(entity, cluster);
+
+    expect(entity.spec.metrics?.prometheus?.address).toEqual({
+      namespace: "some-namespace",
+      port: 42,
+      service: "some-service",
+      prefix: "some-prefix",
+    });
+
+    expect(entity.spec.metrics?.prometheus?.type).toEqual("some-prometheus-provider-type");
+  });
+
+});