hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Replace avoidable asyncComputed with normal computed

Browse Source 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne Savolainen 2022-02-02 14:09:52 +02:00
parent f46c3748e7
commit d6432511ac
No known key found for this signature in database
GPG Key ID: 8C6CFB2FFFE8F68A
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/renderer/components/+apps-releases/release-details/release-details.injectable.ts
View File

@ -10,7 +10,7 @@ import releaseInjectable from "./release.injectable";
const releaseDetailsInjectable = getInjectable({ const releaseDetailsInjectable = getInjectable({
instantiate: (di) => instantiate: (di) =>
asyncComputed(async () => { asyncComputed(async () => {
const release = di.inject(releaseInjectable).value.get(); const release = di.inject(releaseInjectable).get();
return await getRelease(release.name, release.namespace); return await getRelease(release.name, release.namespace);
}), }),

6
src/renderer/components/+apps-releases/release-details/release-details.tsx
View File

@ -7,7 +7,7 @@ import "./release-details.scss";
import React, { Component } from "react"; import React, { Component } from "react";
import groupBy from "lodash/groupBy"; import groupBy from "lodash/groupBy";
import { computed, makeObservable, observable } from "mobx"; import { computed, IComputedValue, makeObservable, observable } from "mobx";
import { Link } from "react-router-dom"; import { Link } from "react-router-dom";
import kebabCase from "lodash/kebabCase"; import kebabCase from "lodash/kebabCase";
import type { HelmRelease, IReleaseDetails, IReleaseUpdateDetails, IReleaseUpdatePayload } from "../../../../common/k8s-api/endpoints/helm-releases.api"; import type { HelmRelease, IReleaseDetails, IReleaseUpdateDetails, IReleaseUpdatePayload } from "../../../../common/k8s-api/endpoints/helm-releases.api";
@ -39,7 +39,7 @@ interface Props {
} }
interface Dependencies { interface Dependencies {
release: IAsyncComputed<HelmRelease> release: IComputedValue<HelmRelease>
releaseDetails: IAsyncComputed<IReleaseDetails> releaseDetails: IAsyncComputed<IReleaseDetails>
releaseValues: IAsyncComputed<string> releaseValues: IAsyncComputed<string>
updateRelease: (name: string, namespace: string, payload: IReleaseUpdatePayload) => Promise<IReleaseUpdateDetails> updateRelease: (name: string, namespace: string, payload: IReleaseUpdatePayload) => Promise<IReleaseUpdateDetails>
@ -59,7 +59,7 @@ class NonInjectedReleaseDetails extends Component<Props & Dependencies> {
} }
@computed get release() { @computed get release() {
return this.props.release.value.get(); return this.props.release.get();
} }
@computed get details() { @computed get details() {

3
src/renderer/components/+apps-releases/release-details/release-values.injectable.ts
View File

@ -12,8 +12,9 @@ import userSuppliedValuesAreShownInjectable from "./user-supplied-values-are-sho
const releaseValuesInjectable = getInjectable({ const releaseValuesInjectable = getInjectable({
instantiate: (di) => instantiate: (di) =>
asyncComputed(async () => { asyncComputed(async () => {
const release = di.inject(releaseInjectable).value.get(); const release = di.inject(releaseInjectable).get();
// TODO: Figure out way to get rid of defensive code
if (!release) { if (!release) {
return ""; return "";
} }

4
src/renderer/components/+apps-releases/release-details/release.injectable.ts
View File

@ -6,14 +6,14 @@ import { getInjectable, lifecycleEnum } from "@ogre-tools/injectable";
import { matches } from "lodash/fp"; import { matches } from "lodash/fp";
import releasesInjectable from "../releases.injectable"; import releasesInjectable from "../releases.injectable";
import releaseRouteParametersInjectable from "./release-route-parameters.injectable"; import releaseRouteParametersInjectable from "./release-route-parameters.injectable";
import { asyncComputed } from "@ogre-tools/injectable-react"; import { computed } from "mobx";
const releaseInjectable = getInjectable({ const releaseInjectable = getInjectable({
instantiate: (di) => { instantiate: (di) => {
const releases = di.inject(releasesInjectable); const releases = di.inject(releasesInjectable);
const releaseRouteParameters = di.inject(releaseRouteParametersInjectable); const releaseRouteParameters = di.inject(releaseRouteParametersInjectable);
return asyncComputed(async () => { return computed(() => {
const { name, namespace } = releaseRouteParameters.get(); const { name, namespace } = releaseRouteParameters.get();
if (!name || !namespace) { if (!name || !namespace) {