hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

pass correct 'id' when registering from extensions

Browse Source 
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2020-12-10 13:59:22 -05:00
parent 9202db5c20
commit d66e600e7a
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/extensions/lens-extension.ts
View File

@ -53,13 +53,13 @@ export class LensExtension {
onProtocolRequest(pathSchema: string, handler: RouteHandler): void { onProtocolRequest(pathSchema: string, handler: RouteHandler): void {
const lpr = LensProtocolRouter.getInstance<LensProtocolRouter>(); const lpr = LensProtocolRouter.getInstance<LensProtocolRouter>();
lpr.extensionOn(this.id, pathSchema, handler); lpr.extensionOn(this.name, pathSchema, handler);
} }
removeProtocolHandlers(): void { removeProtocolHandlers(): void {
const lpr = LensProtocolRouter.getInstance<LensProtocolRouter>(); const lpr = LensProtocolRouter.getInstance<LensProtocolRouter>();
lpr.removeExtensionHandlers(this.id); lpr.removeExtensionHandlers(this.name);
} }
get description() { get description() {

3
src/main/protocol-handler/router.ts
View File

@ -161,6 +161,7 @@ export class LensProtocolRouter extends Singleton {
const [match, handler] = route; const [match, handler] = route;
delete match.params[EXTENSION_NAME_MATCH]; delete match.params[EXTENSION_NAME_MATCH];
delete match.params[EXTENSION_PUBLISHER_MATCH];
handler({ handler({
pathname: match.params, pathname: match.params,
search: url.query, search: url.query,
@ -169,10 +170,12 @@ export class LensProtocolRouter extends Singleton {
public on(urlSchema: string, handler: RouteHandler): void { public on(urlSchema: string, handler: RouteHandler): void {
pathToRegexp(urlSchema); // verify now that the schema is valid pathToRegexp(urlSchema); // verify now that the schema is valid
logger.info(`${LensProtocolRouter.LoggingPrefix}: internal registering ${urlSchema}`);
this.internalRoutes.set(urlSchema, handler); this.internalRoutes.set(urlSchema, handler);
} }
public extensionOn(id: ExtensionId, urlSchema: string, handler: RouteHandler): void { public extensionOn(id: ExtensionId, urlSchema: string, handler: RouteHandler): void {
logger.info(`${LensProtocolRouter.LoggingPrefix}: extension ${id} registering ${urlSchema}`);
pathToRegexp(urlSchema); // verify now that the schema is valid pathToRegexp(urlSchema); // verify now that the schema is valid
if (!this.extentionRoutes.has(id)) { if (!this.extentionRoutes.has(id)) {