Defend against self-referencing composites

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>

src/features/application-menu/main/menu-items/get-composite/get-composite.test.ts

@@ -235,6 +235,26 @@ Available parent ids are:
     });
   });
 
+  it("given items with same id and parent id, throws", () => {
+    const someItem = {
+      id: "some-id",
+      parentId: "some-id",
+    };
+
+    const someRoot = {
+      id: "root",
+      someParentId: undefined,
+    };
+
+    const items = [someItem, someRoot];
+
+    expect(() => {
+      getComposite({
+        source: items,
+      });
+    }).toThrow('Tried to get a composite, but found items with self as parent: "some-id"');
+  });
+
   it("given undefined ids, throws", () => {
     const root = {
       someParentId: undefined,

src/features/application-menu/main/menu-items/get-composite/get-composite.ts

@@ -50,6 +50,20 @@ export default <T>({
     );
   }
 
+  const selfReferencingIds = pipeline(
+    source,
+    filter((x) => getId(x) === getParentId(x)),
+    map(getId),
+  );
+
+  if (selfReferencingIds.length) {
+    throw new Error(
+      `Tried to get a composite, but found items with self as parent: "${selfReferencingIds.join(
+        '", ',
+      )}"`,
+    );
+  }
+
   const duplicateIds = pipeline(
     source,
     countBy(getId),