Add eslint rule padding-line-between-statements (#1593)

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>

extensions/example-extension/page.tsx

@@ -10,6 +10,7 @@ export function ExampleIcon(props: Component.IconProps) {
 export class ExamplePage extends React.Component<{ extension: LensRendererExtension }> {
   deactivate = () => {
     const { extension } = this.props;
+
     extension.disable();
   };
 
@@ -17,6 +18,7 @@ export class ExamplePage extends React.Component<{ extension: LensRendererExtens
     const doodleStyle = {
       width: "200px"
     };
+
     return (
       <div className="flex column gaps align-flex-start">
         <div style={doodleStyle}><CoffeeDoodle accent="#3d90ce" /></div>

extensions/kube-object-event-status/src/resolver.tsx

@@ -4,10 +4,12 @@ export function resolveStatus(object: K8sApi.KubeObject): K8sApi.KubeObjectStatu
   const eventStore = K8sApi.apiManager.getStore(K8sApi.eventApi);
   const events = (eventStore as K8sApi.EventStore).getEventsByObject(object);
   const warnings = events.filter(evt => evt.isWarning());
+
   if (!events.length || !warnings.length) {
     return null;
   }
   const event = [...warnings, ...events][0]; // get latest event
+
   return {
     level: K8sApi.KubeObjectStatusLevel.WARNING,
     text: `${event.message}`,
@@ -22,10 +24,12 @@ export function resolveStatusForPods(pod: K8sApi.Pod): K8sApi.KubeObjectStatus {
   const eventStore = K8sApi.apiManager.getStore(K8sApi.eventApi);
   const events = (eventStore as K8sApi.EventStore).getEventsByObject(pod);
   const warnings = events.filter(evt => evt.isWarning());
+
   if (!events.length || !warnings.length) {
     return null;
   }
   const event = [...warnings, ...events][0]; // get latest event
+
   return {
     level: K8sApi.KubeObjectStatusLevel.WARNING,
     text: `${event.message}`,
@@ -37,13 +41,16 @@ export function resolveStatusForCronJobs(cronJob: K8sApi.CronJob): K8sApi.KubeOb
   const eventStore = K8sApi.apiManager.getStore(K8sApi.eventApi);
   let events = (eventStore as K8sApi.EventStore).getEventsByObject(cronJob);
   const warnings = events.filter(evt => evt.isWarning());
+
   if (cronJob.isNeverRun()) {
     events = events.filter(event => event.reason != "FailedNeedsStart");
   }
+
   if (!events.length || !warnings.length) {
     return null;
   }
   const event = [...warnings, ...events][0]; // get latest event
+
   return {
     level: K8sApi.KubeObjectStatusLevel.WARNING,
     text: `${event.message}`,

extensions/metrics-cluster-feature/src/metrics-feature.ts

@@ -53,6 +53,7 @@ export class MetricsFeature extends ClusterFeature.Feature {
     // Check if there are storageclasses
     const storageClassApi = K8sApi.forCluster(cluster, K8sApi.StorageClass);
     const scs = await storageClassApi.list();
+
     this.templateContext.persistence.enabled = scs.some(sc => (
       sc.metadata?.annotations?.["storageclass.kubernetes.io/is-default-class"] === "true" ||
       sc.metadata?.annotations?.["storageclass.beta.kubernetes.io/is-default-class"] === "true"
@@ -69,6 +70,7 @@ export class MetricsFeature extends ClusterFeature.Feature {
     try {
       const statefulSet = K8sApi.forCluster(cluster, K8sApi.StatefulSet);
       const prometheus = await statefulSet.get({name: "prometheus", namespace: "lens-metrics"});
+
       if (prometheus?.kind) {
         this.status.installed = true;
         this.status.currentVersion = prometheus.spec.template.spec.containers[0].image.split(":")[1];

extensions/node-menu/src/node-menu.tsx

@@ -6,6 +6,7 @@ export interface NodeMenuProps extends Component.KubeObjectMenuProps<K8sApi.Node
 
 export function NodeMenu(props: NodeMenuProps) {
   const { object: node, toolbar } = props;
+
   if (!node) return null;
   const nodeName = node.getName();
 
@@ -35,6 +36,7 @@ export function NodeMenu(props: NodeMenuProps) {
 
   const drain = () => {
     const command = `kubectl drain ${nodeName} --delete-local-data --ignore-daemonsets --force`;
+
     Component.ConfirmDialog.open({
       ok: () => sendToTerminal(command),
       labelOk: `Drain Node`,

extensions/pod-menu/src/logs-menu.tsx

@@ -8,6 +8,7 @@ export class PodLogsMenu extends React.Component<PodLogsMenuProps> {
   showLogs(container: K8sApi.IPodContainer) {
     Navigation.hideDetails();
     const pod = this.props.object;
+
     Component.createPodLogsTab({
       pod,
       containers: pod.getContainers(),
@@ -22,7 +23,9 @@ export class PodLogsMenu extends React.Component<PodLogsMenuProps> {
     const { object: pod, toolbar } = this.props;
     const containers = pod.getAllContainers();
     const statuses = pod.getContainerStatuses();
+
     if (!containers.length) return null;
+
     return (
       <Component.MenuItem onClick={Util.prevDefault(() => this.showLogs(containers[0]))}>
         <Component.Icon material="subject" title="Logs" interactive={toolbar}/>
@@ -40,6 +43,7 @@ export class PodLogsMenu extends React.Component<PodLogsMenuProps> {
                       className={Util.cssNames(Object.keys(status.state)[0], { ready: status.ready })}
                     />
                   ) : null;
+
                   return (
                     <Component.MenuItem key={name} onClick={Util.prevDefault(() => this.showLogs(container))} className="flex align-center">
                       {brick}

extensions/pod-menu/src/shell-menu.tsx

@@ -12,9 +12,11 @@ export class PodShellMenu extends React.Component<PodShellMenuProps> {
     const { object: pod } = this.props;
     const containerParam = container ? `-c ${container}` : "";
     let command = `kubectl exec -i -t -n ${pod.getNs()} ${pod.getName()} ${containerParam} "--"`;
+
     if (window.navigator.platform !== "Win32") {
       command = `exec ${command}`;
     }
+
     if (pod.getSelectedNodeOs() === "windows") {
       command = `${command} powershell`;
     } else {
@@ -34,7 +36,9 @@ export class PodShellMenu extends React.Component<PodShellMenuProps> {
   render() {
     const { object, toolbar } = this.props;
     const containers = object.getRunningContainers();
+
     if (!containers.length) return null;
+
     return (
       <Component.MenuItem onClick={Util.prevDefault(() => this.execShell(containers[0].name))}>
         <Component.Icon svg="ssh" interactive={toolbar} title="Pod shell"/>
@@ -46,6 +50,7 @@ export class PodShellMenu extends React.Component<PodShellMenuProps> {
               {
                 containers.map(container => {
                   const { name } = container;
+
                   return (
                     <Component.MenuItem key={name} onClick={Util.prevDefault(() => this.execShell(name))} className="flex align-center">
                       <Component.StatusBrick/>

extensions/telemetry/src/telemetry-preference.tsx

@@ -7,6 +7,7 @@ import { TelemetryPreferencesStore } from "./telemetry-preferences-store";
 export class TelemetryPreferenceInput extends React.Component<{telemetry: TelemetryPreferencesStore}, {}> {
   render() {
     const { telemetry } = this.props;
+
     return (
       <Component.Checkbox
         label="Allow telemetry & usage tracking"

extensions/telemetry/src/tracker.ts

@@ -29,6 +29,7 @@ export class Tracker extends Util.Singleton {
     this.anonymousId = machineIdSync();
     this.os = this.resolveOS();
     this.userAgent = `Lens ${App.version} (${this.os})`;
+
     try {
       this.visitor = ua(Tracker.GA_ID, this.anonymousId, { strictCidFormat: false });
     } catch (error) {
@@ -49,18 +50,22 @@ export class Tracker extends Util.Singleton {
     const handler = (ev: EventBus.AppEvent) => {
       this.event(ev.name, ev.action, ev.params);
     };
+
     this.eventHandlers.push(handler);
     EventBus.appEventBus.addListener(handler);
   }
 
   watchExtensions() {
     let previousExtensions = App.getEnabledExtensions();
+
     this.disposers.push(reaction(() => App.getEnabledExtensions(), (currentExtensions) => {
       const removedExtensions = previousExtensions.filter(x => !currentExtensions.includes(x));
+
       removedExtensions.forEach(ext => {
         this.event("extension", "disable", { extension: ext });
       });
       const newExtensions = currentExtensions.filter(x => !previousExtensions.includes(x));
+
       newExtensions.forEach(ext => {
         this.event("extension", "enable", { extension: ext });
       });
@@ -82,6 +87,7 @@ export class Tracker extends Util.Singleton {
     for (const handler of this.eventHandlers) {
       EventBus.appEventBus.removeListener(handler);
     }
+
     if (this.reportInterval) {
       clearInterval(this.reportInterval);
     }
@@ -125,12 +131,14 @@ export class Tracker extends Util.Singleton {
 
   protected resolveOS() {
     let os = "";
+
     if (App.isMac) {
       os = "MacOS";
     } else if(App.isWindows) {
       os = "Windows";
     } else if (App.isLinux) {
       os = "Linux";
+
       if (App.isSnap) {
         os += "; Snap";
       } else {
@@ -139,12 +147,14 @@ export class Tracker extends Util.Singleton {
     } else {
       os = "Unknown";
     }
+
     return os;
   }
 
   protected async event(eventCategory: string, eventAction: string, otherParams = {}) {
     try {
       const allowed = await this.isTelemetryAllowed();
+
       if (!allowed) {
         return;
       }