Add eslint rule padding-line-between-statements (#1593)

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>

src/extensions/registries/__tests__/page-registry.test.ts

@@ -73,6 +73,7 @@ describe("globalPageRegistry", () => {
   describe("getByPageMenuTarget", () => {
     it("matching to first registered page without id", () => {
       const page = globalPageRegistry.getByPageMenuTarget({ extensionId: ext.name });
+
       expect(page.id).toEqual(undefined);
       expect(page.extensionId).toEqual(ext.name);
       expect(page.routePath).toEqual(getExtensionPageUrl({ extensionId: ext.name }));
@@ -83,6 +84,7 @@ describe("globalPageRegistry", () => {
         pageId: "test-page",
         extensionId: ext.name
       });
+
       expect(page.id).toEqual("test-page");
     });
 
@@ -91,6 +93,7 @@ describe("globalPageRegistry", () => {
         pageId: "wrong-page",
         extensionId: ext.name
       });
+
       expect(page).toBeNull();
     });
   });

src/extensions/registries/base-registry.ts

@@ -14,7 +14,9 @@ export class BaseRegistry<T> {
   @action
   add(items: T | T[]) {
     const itemArray = rectify(items);
+
     this.items.push(...itemArray);
+
     return () => this.remove(...itemArray);
   }
 

src/extensions/registries/kube-object-detail-registry.ts

@@ -20,8 +20,10 @@ export class KubeObjectDetailRegistry extends BaseRegistry<KubeObjectDetailRegis
       if (item.priority === null) {
         item.priority = 50;
       }
+
       return item;
     });
+
     return items.sort((a, b) => b.priority - a.priority);
   }
 }

src/extensions/registries/page-menu-registry.ts

@@ -35,8 +35,10 @@ export class GlobalPageMenuRegistry extends BaseRegistry<PageMenuRegistration> {
         extensionId: ext.name,
         ...(menuItem.target || {}),
       };
+
       return menuItem;
     });
+
     return super.add(normalizedItems);
   }
 }
@@ -49,8 +51,10 @@ export class ClusterPageMenuRegistry extends BaseRegistry<ClusterPageMenuRegistr
         extensionId: ext.name,
         ...(menuItem.target || {}),
       };
+
       return menuItem;
     });
+
     return super.add(normalizedItems);
   }
 

src/extensions/registries/page-registry.ts

@@ -45,9 +45,11 @@ export function getExtensionPageUrl<P extends object>({ extensionId, pageId = ""
     name: sanitizeExtensionName(extensionId), // compile only with extension-id first and define base path
   });
   const extPageRoutePath = path.join(extensionBaseUrl, pageId); // page-id might contain route :param-s, so don't compile yet
+
   if (params) {
     return compile(extPageRoutePath)(params); // might throw error when required params not passed
   }
+
   return extPageRoutePath;
 }
 
@@ -56,6 +58,7 @@ export class PageRegistry extends BaseRegistry<RegisteredPage> {
   add(items: PageRegistration | PageRegistration[], ext: LensExtension) {
     const itemArray = rectify(items);
     let registeredPages: RegisteredPage[] = [];
+
     try {
       registeredPages = itemArray.map(page => ({
         ...page,
@@ -69,6 +72,7 @@ export class PageRegistry extends BaseRegistry<RegisteredPage> {
         error: String(err),
       });
     }
+
     return super.add(registeredPages);
   }
 
@@ -78,8 +82,10 @@ export class PageRegistry extends BaseRegistry<RegisteredPage> {
 
   getByPageMenuTarget(target: PageMenuTarget = {}): RegisteredPage | null {
     const targetUrl = getExtensionPageUrl(target);
+
     return this.getItems().find(({ id: pageId, extensionId }) => {
       const pageUrl = getExtensionPageUrl({ extensionId, pageId, params: target.params }); // compiled with provided params
+
       return targetUrl === pageUrl;
     }) || null;
   }