Add eslint rule padding-line-between-statements (#1593)

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>

src/renderer/components/+apps-releases/release-details.tsx

@@ -55,6 +55,7 @@ export class ReleaseDetails extends Component<Props> {
     const { getReleaseSecret } = releaseStore;
     const { release } = this.props;
     const secret = getReleaseSecret(release);
+
     if (this.releaseSecret) {
       if (isEqual(this.releaseSecret.getLabels(), secret.getLabels())) return;
       this.loadDetails();
@@ -64,12 +65,14 @@ export class ReleaseDetails extends Component<Props> {
 
   async loadDetails() {
     const { release } = this.props;
+
     this.details = null;
     this.details = await helmReleasesApi.get(release.getName(), release.getNs());
   }
 
   async loadValues() {
     const { release } = this.props;
+
     this.values = "";
     this.values = await helmReleasesApi.getValues(release.getName(), release.getNs());
   }
@@ -84,7 +87,9 @@ export class ReleaseDetails extends Component<Props> {
       version: release.getVersion(),
       values: this.values
     };
+
     this.saving = true;
+
     try {
       await releaseStore.update(name, namespace, data);
       Notifications.ok(
@@ -98,12 +103,14 @@ export class ReleaseDetails extends Component<Props> {
 
   upgradeVersion = () => {
     const { release, hideDetails } = this.props;
+
     createUpgradeChartTab(release);
     hideDetails();
   };
 
   renderValues() {
     const { values, saving } = this;
+
     return (
       <div className="values">
         <DrawerTitle title={_i18n._(t`Values`)}/>
@@ -127,6 +134,7 @@ export class ReleaseDetails extends Component<Props> {
   renderNotes() {
     if (!this.details.info?.notes) return null;
     const { notes } = this.details.info;
+
     return (
       <div className="notes">
         {notes}
@@ -136,6 +144,7 @@ export class ReleaseDetails extends Component<Props> {
 
   renderResources() {
     const { resources } = this.details;
+
     if (!resources) return null;
     const groups = groupBy(resources, item => item.kind);
     const tables = Object.entries(groups).map(([kind, items]) => {
@@ -156,6 +165,7 @@ export class ReleaseDetails extends Component<Props> {
                 name,
                 namespace,
               })) : "";
+
               return (
                 <TableRow key={item.getId()}>
                   <TableCell className="name">
@@ -170,6 +180,7 @@ export class ReleaseDetails extends Component<Props> {
         </React.Fragment>
       );
     });
+
     return (
       <div className="resources">
         {tables}
@@ -180,10 +191,13 @@ export class ReleaseDetails extends Component<Props> {
   renderContent() {
     const { release } = this.props;
     const { details } = this;
+
     if (!release) return null;
+
     if (!details) {
       return <Spinner center/>;
     }
+
     return (
       <div>
         <DrawerItem name={<Trans>Chart</Trans>} className="chart">
@@ -229,6 +243,7 @@ export class ReleaseDetails extends Component<Props> {
     const { release, hideDetails } = this.props;
     const title = release ? <Trans>Release: {release.getName()}</Trans> : "";
     const toolbar = <HelmReleaseMenu release={release} toolbar hideDetails={hideDetails}/>;
+
     return (
       <Drawer
         className={cssNames("ReleaseDetails", themeStore.activeTheme.type)}

src/renderer/components/+apps-releases/release-menu.tsx

@@ -24,6 +24,7 @@ export class HelmReleaseMenu extends React.Component<Props> {
   @autobind()
   upgrade() {
     const { release, hideDetails } = this.props;
+
     createUpgradeChartTab(release);
     hideDetails && hideDetails();
   }
@@ -35,8 +36,10 @@ export class HelmReleaseMenu extends React.Component<Props> {
 
   renderContent() {
     const { release, toolbar } = this.props;
+
     if (!release) return;
     const hasRollback = release && release.getRevision() > 1;
+
     return (
       <>
         {hasRollback && (
@@ -51,6 +54,7 @@ export class HelmReleaseMenu extends React.Component<Props> {
 
   render() {
     const { className, release, ...menuProps } = this.props;
+
     return (
       <MenuActions
         {...menuProps}

src/renderer/components/+apps-releases/release-rollback-dialog.tsx

@@ -41,6 +41,7 @@ export class ReleaseRollbackDialog extends React.Component<Props> {
     this.isLoading = true;
     const currentRevision = this.release.getRevision();
     let releases = await helmReleasesApi.getHistory(this.release.getName(), this.release.getNs());
+
     releases = releases.filter(item => item.revision !== currentRevision); // remove current
     releases = orderBy(releases, "revision", "desc"); // sort
     this.revisions.replace(releases);
@@ -50,6 +51,7 @@ export class ReleaseRollbackDialog extends React.Component<Props> {
 
   rollback = async () => {
     const revisionNumber = this.revision.revision;
+
     try {
       await releaseStore.rollback(this.release.getName(), this.release.getNs(), revisionNumber);
       this.close();
@@ -64,9 +66,11 @@ export class ReleaseRollbackDialog extends React.Component<Props> {
 
   renderContent() {
     const { revision, revisions } = this;
+
     if (!revision) {
       return <p><Trans>No revisions to rollback.</Trans></p>;
     }
+
     return (
       <div className="flex gaps align-center">
         <b><Trans>Revision</Trans></b>
@@ -85,6 +89,7 @@ export class ReleaseRollbackDialog extends React.Component<Props> {
     const { ...dialogProps } = this.props;
     const releaseName = this.release ? this.release.getName() : "";
     const header = <h5><Trans>Rollback <b>{releaseName}</b></Trans></h5>;
+
     return (
       <Dialog
         {...dialogProps}

src/renderer/components/+apps-releases/release.store.ts

@@ -26,9 +26,12 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
       const amountChanged = secrets.length !== this.releaseSecrets.length;
       const labelsChanged = this.releaseSecrets.some(item => {
         const secret = secrets.find(secret => secret.getId() == item.getId());
+
         if (!secret) return;
+
         return !isEqual(item.getLabels(), secret.getLabels());
       });
+
       if (amountChanged || labelsChanged) {
         this.loadAll();
       }
@@ -49,6 +52,7 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
       owner: "helm",
       name: release.getName()
     };
+
     return secretsStore.getByLabel(labels)
       .filter(secret => secret.getNs() == release.getNs())[0];
   }
@@ -57,8 +61,10 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
   async loadAll() {
     this.isLoading = true;
     let items;
+
     try {
       const { isAdmin, allowedNamespaces } = getHostedCluster();
+
       items = await this.loadItems(!isAdmin ? allowedNamespaces : null);
     } finally {
       if (items) {
@@ -82,19 +88,25 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
 
   async create(payload: IReleaseCreatePayload) {
     const response = await helmReleasesApi.create(payload);
+
     if (this.isLoaded) this.loadAll();
+
     return response;
   }
 
   async update(name: string, namespace: string, payload: IReleaseUpdatePayload) {
     const response = await helmReleasesApi.update(name, namespace, payload);
+
     if (this.isLoaded) this.loadAll();
+
     return response;
   }
 
   async rollback(name: string, namespace: string, revision: number) {
     const response = await helmReleasesApi.rollback(name, namespace, revision);
+
     if (this.isLoaded) this.loadAll();
+
     return response;
   }
 
@@ -104,6 +116,7 @@ export class ReleaseStore extends ItemStore<HelmRelease> {
 
   async removeSelectedItems() {
     if (!this.selectedItems.length) return;
+
     return Promise.all(this.selectedItems.map(this.remove));
   }
 }

src/renderer/components/+apps-releases/releases.tsx

@@ -41,6 +41,7 @@ export class HelmReleases extends Component<Props> {
 
   get selectedRelease() {
     const { match: { params: { name, namespace } } } = this.props;
+
     return releaseStore.items.find(release => {
       return release.getName() == name && release.getNs() == namespace;
     });
@@ -66,6 +67,7 @@ export class HelmReleases extends Component<Props> {
 
   renderRemoveDialogMessage(selectedItems: HelmRelease[]) {
     const releaseNames = selectedItems.map(item => item.getName()).join(", ");
+
     return (
       <div>
         <Trans>Remove <b>{releaseNames}</b>?</Trans>
@@ -111,6 +113,7 @@ export class HelmReleases extends Component<Props> {
           ]}
           renderTableContents={(release: HelmRelease) => {
             const version = release.getVersion();
+
             return [
               release.getName(),
               release.getNs(),