Add eslint rule padding-line-between-statements (#1593)

Signed-off-by: Panu Horsmalahti <phorsmalahti@mirantis.com>
This commit is contained in:
Panu Horsmalahti authored and GitHub committed 2020-12-02 09:55:52 +02:00
1 parent 7b77f18376
commit dcf253e7d5
401 files changed
+2018 -40

No files matched your search

@@ -42,12 +42,14 @@ export class StatefulSetDetails extends React.Component<Props> {
render() {
const { object: statefulSet } = this.props;
if (!statefulSet) return null;
const images = statefulSet.getImages();
const selectors = statefulSet.getSelectors();
const nodeSelector = statefulSet.getNodeSelectors();
const childPods = statefulSetStore.getChildPods(statefulSet);
const metrics = statefulSetStore.metrics;
return (
<div className="StatefulSetDetails">
{podsStore.isLoaded && (
@@ -101,6 +101,7 @@ const dummyStatefulSet = {
describe("<StatefulSetScaleDialog />", () => {
it("renders w/o errors", () => {
const { container } = render(<StatefulSetScaleDialog/>);
expect(container).toBeInstanceOf(HTMLElement);
});
@@ -108,8 +109,10 @@ describe("<StatefulSetScaleDialog />", () => {
// mock statefulSetApi.getReplicas() which will be called
// when <StatefulSetScaleDialog /> rendered.
const initReplicas = 1;
statefulSetApi.getReplicas = jest.fn().mockImplementationOnce(async () => initReplicas);
const { getByTestId } = render(<StatefulSetScaleDialog/>);
StatefulSetScaleDialog.open(dummyStatefulSet);
// we need to wait for the StatefulSetScaleDialog to show up
// because there is an <Animate /> in <Dialog /> which renders null at start.
@@ -118,6 +121,7 @@ describe("<StatefulSetScaleDialog />", () => {
getByTestId("current-scale"),
getByTestId("desired-scale"),
]);
expect(currentScale).toHaveTextContent(`${initReplicas}`);
expect(desiredScale).toHaveTextContent(`${initReplicas}`);
});
@@ -125,8 +129,10 @@ describe("<StatefulSetScaleDialog />", () => {
it("changes the desired scale when clicking the icon buttons +/-", async () => {
const initReplicas = 1;
statefulSetApi.getReplicas = jest.fn().mockImplementationOnce(async () => initReplicas);
const component = render(<StatefulSetScaleDialog/>);
StatefulSetScaleDialog.open(dummyStatefulSet);
await waitFor(async () => {
expect(await component.findByTestId("desired-scale")).toHaveTextContent(`${initReplicas}`);
@@ -136,6 +142,7 @@ describe("<StatefulSetScaleDialog />", () => {
const up = await component.findByTestId("desired-replicas-up");
const down = await component.findByTestId("desired-replicas-down");
fireEvent.click(up);
expect(await component.findByTestId("desired-scale")).toHaveTextContent(`${initReplicas + 1}`);
expect(await component.findByTestId("current-scale")).toHaveTextContent(`${initReplicas}`);
@@ -148,6 +155,7 @@ describe("<StatefulSetScaleDialog />", () => {
// edge case, desiredScale must >= 0
let times = 10;
for (let i = 0; i < times; i++) {
fireEvent.click(down);
}
@@ -156,6 +164,7 @@ describe("<StatefulSetScaleDialog />", () => {
// edge case, desiredScale must <= scaleMax (100)
times = 120;
for (let i = 0; i < times; i++) {
fireEvent.click(up);
}
@@ -43,6 +43,7 @@ export class StatefulSetScaleDialog extends Component<Props> {
onOpen = async () => {
const { statefulSet } = this;
this.currentReplicas = await statefulSetApi.getReplicas({
namespace: statefulSet.getNs(),
name: statefulSet.getName(),
@@ -62,6 +63,7 @@ export class StatefulSetScaleDialog extends Component<Props> {
@computed get scaleMax() {
const { currentReplicas } = this;
const defaultMax = 50;
return currentReplicas <= defaultMax
? defaultMax * 2
: currentReplicas * 2;
@@ -70,6 +72,7 @@ export class StatefulSetScaleDialog extends Component<Props> {
scale = async () => {
const { statefulSet } = this;
const { currentReplicas, desiredReplicas, close } = this;
try {
if (currentReplicas !== desiredReplicas) {
await statefulSetApi.scale({
@@ -94,6 +97,7 @@ export class StatefulSetScaleDialog extends Component<Props> {
renderContents() {
const { currentReplicas, desiredReplicas, onChange, scaleMax } = this;
const warning = currentReplicas < 10 && desiredReplicas > 90;
return (
<>
<div className="current-scale" data-testid="current-scale">
@@ -139,6 +143,7 @@ export class StatefulSetScaleDialog extends Component<Props> {
<Trans>Scale Stateful Set <span>{statefulSetName}</span></Trans>
</h5>
);
return (
<Dialog
{...dialogProps}
@@ -12,6 +12,7 @@ export class StatefulSetStore extends KubeObjectStore<StatefulSet> {
async loadMetrics(statefulSet: StatefulSet) {
const pods = this.getChildPods(statefulSet);
this.metrics = await podsApi.getMetrics(pods, statefulSet.getNs(), "");
}
@@ -21,8 +22,10 @@ export class StatefulSetStore extends KubeObjectStore<StatefulSet> {
getStatuses(statefulSets: StatefulSet[]) {
const status = { failed: 0, pending: 0, running: 0 };
statefulSets.forEach(statefulSet => {
const pods = this.getChildPods(statefulSet);
if (pods.some(pod => pod.getStatus() === PodStatus.FAILED)) {
status.failed++;
}
@@ -33,6 +36,7 @@ export class StatefulSetStore extends KubeObjectStore<StatefulSet> {
status.running++;
}
});
return status;
}
@@ -33,6 +33,7 @@ interface Props extends RouteComponentProps<IStatefulSetsRouteParams> {
export class StatefulSets extends React.Component<Props> {
renderPods(statefulSet: StatefulSet) {
const { readyReplicas, currentReplicas } = statefulSet.status;
return `${readyReplicas || 0}/${currentReplicas || 0}`;
}
@@ -77,6 +78,7 @@ export class StatefulSets extends React.Component<Props> {
export function StatefulSetMenu(props: KubeObjectMenuProps<StatefulSet>) {
const { object, toolbar } = props;
return (
<>
<MenuItem onClick={() => StatefulSetScaleDialog.open(object)}>