From dde628b0279534e6c0d49418169d01145bb2e71b Mon Sep 17 00:00:00 2001
From: Janne Savolainen <janne.savolainen@live.fi>
Date: Thu, 25 Aug 2022 10:33:38 +0300
Subject: [PATCH] Remove dead code

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
---
 .../release-details-content.tsx               | 107 +++++++++---------
 .../release-details-model.injectable.tsx      |   9 --
 2 files changed, 51 insertions(+), 65 deletions(-)

diff --git a/src/renderer/components/+helm-releases/release-details/release-details-content.tsx b/src/renderer/components/+helm-releases/release-details/release-details-content.tsx
index 266333f974..df183ff601 100644
--- a/src/renderer/components/+helm-releases/release-details/release-details-content.tsx
+++ b/src/renderer/components/+helm-releases/release-details/release-details-content.tsx
@@ -34,7 +34,6 @@ interface Dependencies {
 }
 
 const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & ReleaseDetailsContentProps) => {
-  const isLoading = model.isLoading.get();
   const failedToLoad = model.failedToLoad.get();
 
   if (failedToLoad) {
@@ -43,69 +42,65 @@ const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & Rel
 
 
   return (
-    (isLoading ? (
-      <Spinner center data-testid="helm-release-detail-content-spinner" />
-    ) : (
-      <div>
-        <DrawerItem name="Chart" className="chart">
-          <div className="flex gaps align-center">
-            <span>{model.release.chart}</span>
+    <div>
+      <DrawerItem name="Chart" className="chart">
+        <div className="flex gaps align-center">
+          <span>{model.release.chart}</span>
 
-            <Button
-              primary
-              label="Upgrade"
-              className="box right upgrade"
-              onClick={model.startUpgradeProcess}
-              data-testid="helm-release-upgrade-button"
-            />
-          </div>
-        </DrawerItem>
-
-        <DrawerItem name="Updated">
-          {model.release.getUpdated()}
-          {` ago (${model.release.updated})`}
-        </DrawerItem>
-
-        <DrawerItem name="Namespace">{model.release.getNs()}</DrawerItem>
-
-        <DrawerItem name="Version" onClick={stopPropagation}>
-          <div className="version flex gaps align-center">
-            <span>{model.release.getVersion()}</span>
-          </div>
-        </DrawerItem>
-
-        <DrawerItem
-          name="Status"
-          className="status"
-          labelsOnly>
-          <Badge
-            label={model.release.getStatus()}
-            className={kebabCase(model.release.getStatus())}
+          <Button
+            primary
+            label="Upgrade"
+            className="box right upgrade"
+            onClick={model.startUpgradeProcess}
+            data-testid="helm-release-upgrade-button"
           />
-        </DrawerItem>
+        </div>
+      </DrawerItem>
 
-        <ReleaseValues
-          configuration={model.configuration}
-          onlyUserSuppliedValuesAreShown={
-            model.onlyUserSuppliedValuesAreShown
-          }
+      <DrawerItem name="Updated">
+        {model.release.getUpdated()}
+        {` ago (${model.release.updated})`}
+      </DrawerItem>
+
+      <DrawerItem name="Namespace">{model.release.getNs()}</DrawerItem>
+
+      <DrawerItem name="Version" onClick={stopPropagation}>
+        <div className="version flex gaps align-center">
+          <span>{model.release.getVersion()}</span>
+        </div>
+      </DrawerItem>
+
+      <DrawerItem
+        name="Status"
+        className="status"
+        labelsOnly>
+        <Badge
+          label={model.release.getStatus()}
+          className={kebabCase(model.release.getStatus())}
         />
+      </DrawerItem>
 
-        <DrawerTitle>Notes</DrawerTitle>
+      <ReleaseValues
+        configuration={model.configuration}
+        onlyUserSuppliedValuesAreShown={
+          model.onlyUserSuppliedValuesAreShown
+        }
+      />
 
-        {model.notes && <div className="notes">{model.notes}</div>}
+      <DrawerTitle>Notes</DrawerTitle>
 
-        <DrawerTitle>Resources</DrawerTitle>
+      {model.notes && <div className="notes">{model.notes}</div>}
 
-        {model.groupedResources.length > 0 && (
-          <div className="resources">
-            {model.groupedResources.map((group) => (
-              <ResourceGroup key={group.kind} group={group} />
-            ))}
-          </div>
-        )}
-      </div>
-    ))
+      <DrawerTitle>Resources</DrawerTitle>
+
+      {model.groupedResources.length > 0 && (
+        <div className="resources">
+          {model.groupedResources.map((group) => (
+            <ResourceGroup key={group.kind} group={group} />
+          ))}
+        </div>
+      )}
+    </div>
   );
 });
 
diff --git a/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx b/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx
index e782dd3a6d..0ccf416f4a 100644
--- a/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx
+++ b/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx
@@ -103,7 +103,6 @@ export class ReleaseDetailsModel {
 
   private detailedRelease = observable.box<DetailedHelmRelease | undefined>();
 
-  readonly isLoading = observable.box(false);
   readonly failedToLoad = observable.box(false);
 
   readonly configuration: ConfigurationInput = {
@@ -171,10 +170,6 @@ export class ReleaseDetailsModel {
   };
 
   load = async () => {
-    runInAction(() => {
-      this.isLoading.set(true);
-    });
-
     const { name, namespace } = this.dependencies.targetRelease;
 
     const result = await this.dependencies.callForHelmRelease(
@@ -195,10 +190,6 @@ export class ReleaseDetailsModel {
     });
 
     await this.loadConfiguration();
-
-    runInAction(() => {
-      this.isLoading.set(false);
-    });
   };
 
   private loadConfiguration = async () => {