mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Improve Table typing and remove annotations on callbacks
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
1 parent
22c9d03edb
commit
defb0ea0dd
55 files changed
+498
-490
No files matched your search
@@ -82,15 +82,15 @@ export class Deployments extends React.Component<Props> {
|
||||
className="Deployments" store={deploymentStore}
|
||||
dependentStores={[replicaSetStore, podsStore, nodesStore, eventStore]}
|
||||
sortingCallbacks={{
|
||||
[columnId.name]: (deployment: Deployment) => deployment.getName(),
|
||||
[columnId.namespace]: (deployment: Deployment) => deployment.getNs(),
|
||||
[columnId.replicas]: (deployment: Deployment) => deployment.getReplicas(),
|
||||
[columnId.age]: (deployment: Deployment) => deployment.getTimeDiffFromNow(),
|
||||
[columnId.condition]: (deployment: Deployment) => deployment.getConditionsText(),
|
||||
[columnId.name]: deployment => deployment.getName(),
|
||||
[columnId.namespace]: deployment => deployment.getNs(),
|
||||
[columnId.replicas]: deployment => deployment.getReplicas(),
|
||||
[columnId.age]: deployment => deployment.getTimeDiffFromNow(),
|
||||
[columnId.condition]: deployment => deployment.getConditionsText(),
|
||||
}}
|
||||
searchFilters={[
|
||||
(deployment: Deployment) => deployment.getSearchFields(),
|
||||
(deployment: Deployment) => deployment.getConditionsText(),
|
||||
deployment => deployment.getSearchFields(),
|
||||
deployment => deployment.getConditionsText(),
|
||||
]}
|
||||
renderHeaderTitle="Deployments"
|
||||
renderTableHeader={[
|
||||
@@ -102,7 +102,7 @@ export class Deployments extends React.Component<Props> {
|
||||
{ title: "Age", className: "age", sortBy: columnId.age, id: columnId.age },
|
||||
{ title: "Conditions", className: "conditions", sortBy: columnId.condition, id: columnId.condition },
|
||||
]}
|
||||
renderTableContents={(deployment: Deployment) => [
|
||||
renderTableContents={deployment => [
|
||||
deployment.getName(),
|
||||
<KubeObjectStatusIcon key="icon" object={deployment}/>,
|
||||
deployment.getNs(),
|
||||
@@ -111,9 +111,7 @@ export class Deployments extends React.Component<Props> {
|
||||
deployment.getAge(),
|
||||
this.renderConditions(deployment),
|
||||
]}
|
||||
renderItemMenu={(item: Deployment) => {
|
||||
return <DeploymentMenu object={item}/>;
|
||||
}}
|
||||
renderItemMenu={item => <DeploymentMenu object={item} />}
|
||||
/>
|
||||
);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user