diff --git a/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx b/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx index c81d3e9ac1..9abfcba9d0 100644 --- a/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx +++ b/src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx @@ -71,7 +71,7 @@ describe("preferences - navigation to extension specific preferences", () => { }); }); - describe("given multiple extensions with and without specific preferences, when navigating to extension specific preferences page", () => { + describe("given multiple extensions with and without specific preferences", () => { beforeEach(async () => { const getRendererExtensionFake = getRendererExtensionFakeFor(applicationBuilder); const someTestExtension = getRendererExtensionFake(extensionStubWithExtensionSpecificPreferenceItems); @@ -112,7 +112,7 @@ describe("preferences - navigation to extension specific preferences", () => { expect(actual).not.toBeNull(); }); - it("link doesn't have 'active' class", () => { + it("link should not be active", () => { const actual = rendered.getByTestId("tab-link-for-extension-some-test-extension-id"); expect(actual).not.toHaveClass("active"); @@ -145,7 +145,7 @@ describe("preferences - navigation to extension specific preferences", () => { expect(actual).toBeNull(); }); - it("link does have 'active' class", () => { + it("link is active", () => { const actual = rendered.getByTestId("tab-link-for-extension-some-test-extension-id"); expect(actual).toHaveClass("active"); diff --git a/src/renderer/components/+preferences/preferences-navigation/extensions-preferences-navigation-item.injectable.ts b/src/renderer/components/+preferences/preferences-navigation/extensions-preferences-navigation-item.injectable.ts index 7fbfe34d4c..97422f0398 100644 --- a/src/renderer/components/+preferences/preferences-navigation/extensions-preferences-navigation-item.injectable.ts +++ b/src/renderer/components/+preferences/preferences-navigation/extensions-preferences-navigation-item.injectable.ts @@ -16,7 +16,8 @@ const extensionPreferencesNavigationItemRegistratorInjectable = getInjectable({ id: "extension-preferences-navigation-item", instantiate: (di) => { - return (extension: LensRendererExtension) => { + return (ext) => { + const extension = ext as LensRendererExtension; const navigateToExtensionPreferences = di.inject( navigateToExtensionPreferencesInjectable, ); @@ -24,7 +25,7 @@ const extensionPreferencesNavigationItemRegistratorInjectable = getInjectable({ const extensionHasGeneralPreferences = extension.appPreferences.some(preferences => !preferences.showInPreferencesTab, ); - const isVisible = extensionHasPreferences && extensionHasGeneralPreferences; + const isVisible = computed(() => extensionHasPreferences && extensionHasGeneralPreferences); const extensionRoute = di.inject(extensionPreferencesRouteInjectable); const pathParameters = di.inject(currentPathParametersInjectable); const routeIsActive = di.inject(routeIsActiveInjectable, extensionRoute); @@ -38,7 +39,7 @@ const extensionPreferencesNavigationItemRegistratorInjectable = getInjectable({ label: `${extension.name}`, navigate: () => navigateToExtensionPreferences(extension.sanitizedExtensionId), isActive, - isVisible: computed(() => isVisible), + isVisible, orderNumber: 20, fromExtension: true, }), diff --git a/src/renderer/components/+preferences/preferences-navigation/navigate-to-preference-tab.injectable.ts b/src/renderer/components/+preferences/preferences-navigation/navigate-to-preference-tab.injectable.ts index 12495b5738..05a20dab29 100644 --- a/src/renderer/components/+preferences/preferences-navigation/navigate-to-preference-tab.injectable.ts +++ b/src/renderer/components/+preferences/preferences-navigation/navigate-to-preference-tab.injectable.ts @@ -12,7 +12,7 @@ const navigateToPreferenceTabInjectable = getInjectable({ instantiate: (di) => { const navigateToRoute = di.inject(navigateToRouteInjectionToken); - return (route: Route) => () => { + return (route: Route) => () => { navigateToRoute(route, { withoutAffectingBackButton: true }); }; },