hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Cleaning up

Browse Source 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2021-08-09 11:00:24 +03:00
parent 0824121234
commit df38165ce6
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/renderer/components/+preferences/extensions.tsx
View File

@ -24,7 +24,7 @@ import React from "react";
import { AppPreferenceRegistry } from "../../../extensions/registries"; import { AppPreferenceRegistry } from "../../../extensions/registries";
import { ExtensionSettings } from "./preferences"; import { ExtensionSettings } from "./preferences";
export const Telemetry = observer(() => { export const Extensions = observer(() => {
const extensions = AppPreferenceRegistry.getInstance().getItems(); const extensions = AppPreferenceRegistry.getInstance().getItems();
return ( return (

11
src/renderer/components/+preferences/preferences.tsx
View File

@ -47,6 +47,8 @@ import { Application } from "./application";
import { Kubernetes } from "./kubernetes"; import { Kubernetes } from "./kubernetes";
import { LensProxy } from "./proxy"; import { LensProxy } from "./proxy";
import { Telemetry } from "./telemetry"; import { Telemetry } from "./telemetry";
import { Extensions } from "./extensions";
import { sentryDsn } from "../../../common/vars";
@observer @observer
export class Preferences extends React.Component { export class Preferences extends React.Component {
@ -58,7 +60,8 @@ export class Preferences extends React.Component {
} }
renderNavigation() { renderNavigation() {
const extensions = AppPreferenceRegistry.getInstance().getItems().filter(e => !e.showInPreferencesTab); const extensions = AppPreferenceRegistry.getInstance().getItems();
const telemetryExtensions = extensions.filter(e => e.showInPreferencesTab == "telemetry");
const currentLocation = navigation.location.pathname; const currentLocation = navigation.location.pathname;
const isActive = (route: RouteProps) => !!matchPath(currentLocation, { path: route.path, exact: route.exact }); const isActive = (route: RouteProps) => !!matchPath(currentLocation, { path: route.path, exact: route.exact });
@ -68,8 +71,10 @@ export class Preferences extends React.Component {
<Tab value={appURL()} label="Application" data-testid="application-tab" active={isActive(appRoute)}/> <Tab value={appURL()} label="Application" data-testid="application-tab" active={isActive(appRoute)}/>
<Tab value={proxyURL()} label="Proxy" data-testid="proxy-tab" active={isActive(proxyRoute)}/> <Tab value={proxyURL()} label="Proxy" data-testid="proxy-tab" active={isActive(proxyRoute)}/>
<Tab value={kubernetesURL()} label="Kubernetes" data-testid="kube-tab" active={isActive(kubernetesRoute)}/> <Tab value={kubernetesURL()} label="Kubernetes" data-testid="kube-tab" active={isActive(kubernetesRoute)}/>
{telemetryExtensions.length > 0 || !!sentryDsn &&
<Tab value={telemetryURL()} label="Telemetry" data-testid="telemetry-tab" active={isActive(telemetryRoute)}/> <Tab value={telemetryURL()} label="Telemetry" data-testid="telemetry-tab" active={isActive(telemetryRoute)}/>
{extensions.length > 0 && }
{extensions.filter(e => !e.showInPreferencesTab).length > 0 &&
<Tab value={extensionURL()} label="Extensions" data-testid="extensions-tab" active={isActive(extensionRoute)}/> <Tab value={extensionURL()} label="Extensions" data-testid="extensions-tab" active={isActive(extensionRoute)}/>
} }
</Tabs> </Tabs>
@ -88,7 +93,7 @@ export class Preferences extends React.Component {
<Route path={proxyURL()} component={LensProxy}/> <Route path={proxyURL()} component={LensProxy}/>
<Route path={kubernetesURL()} component={Kubernetes}/> <Route path={kubernetesURL()} component={Kubernetes}/>
<Route path={telemetryURL()} component={Telemetry}/> <Route path={telemetryURL()} component={Telemetry}/>
<Route path={extensionURL()} component={Telemetry}/> <Route path={extensionURL()} component={Extensions}/>
<Redirect exact from={`${preferencesURL()}/`} to={appURL()}/> <Redirect exact from={`${preferencesURL()}/`} to={appURL()}/>
</Switch> </Switch>
</SettingLayout> </SettingLayout>