From dfc7470e6c5d1829619a2ab9d405916fbbeb7b60 Mon Sep 17 00:00:00 2001
From: Sebastian Malton <sebastian@malton.name>
Date: Thu, 7 Oct 2021 11:36:53 -0400
Subject: [PATCH] Don't read chartData.values until after it is checked

Signed-off-by: Sebastian Malton <sebastian@malton.name>
---
 src/renderer/components/dock/install-chart.tsx | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/renderer/components/dock/install-chart.tsx b/src/renderer/components/dock/install-chart.tsx
index b0113018ea..a31abb061b 100644
--- a/src/renderer/components/dock/install-chart.tsx
+++ b/src/renderer/components/dock/install-chart.tsx
@@ -55,10 +55,6 @@ export class InstallChart extends Component<Props> {
     makeObservable(this);
   }
 
-  get values() {
-    return this.chartData.values;
-  }
-
   get chartData() {
     return installChartStore.getData(this.tabId);
   }
@@ -135,7 +131,7 @@ export class InstallChart extends Component<Props> {
   };
 
   render() {
-    const { tabId, chartData, values, versions, install } = this;
+    const { tabId, chartData, versions, install } = this;
 
     if (chartData?.values === undefined || !versions) {
       return <Spinner center />;
@@ -215,7 +211,7 @@ export class InstallChart extends Component<Props> {
         />
         <EditorPanel
           tabId={tabId}
-          value={values}
+          value={chartData.values}
           onChange={this.onValuesChange}
         />
       </div>