Turn on strict mode in tsconfig.json, some helpful lints, and required cleanup where strictness necessitates it (#5195)

* Turn on strict mode in tsconfig.json - Add route, clusterRoute, and payloadValidatedClusterRoute helper functions to improve types with backend routes - Turn on the following new lints: - react/jsx-first-prop-new-line - react/jsx-wrap-multilines - react/jsx-one-expression-per-line - react/jsx-max-props-per-line - react/jsx-indent - react/jsx-indent-props Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix build Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace KubeObject scope strings with enum Signed-off-by: Sebastian Malton <sebastian@malton.name> * Revert package.json version changes Signed-off-by: Sebastian Malton <sebastian@malton.name> * revert move hostedCluster(Id) Signed-off-by: Sebastian Malton <sebastian@malton.name> * change some type param names to be not single letters Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove copy-extension-themes Signed-off-by: Sebastian Malton <sebastian@malton.name> * add new make clean action Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix build to not use webpack for generating types Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube-object-menu.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix select.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * revert move fileNameMigration to index Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix ref logic error Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix log-resource-selector.test.tsx tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-store.test.ts test by overriding createStorage to not touch file system Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cluster.test.ts tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube=api.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fixed hotbar-store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kubeconfig-manager.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cluster-role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix pods.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix delete-cluster-dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix daemonset.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix replicaset.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix statefulsets/dialog/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix replicasets/scale-dialog/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix deployments.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix deployments/scale/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cronjob.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix stateful-set.api.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix deployment.api.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix api-manager.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix statefulset.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix job.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix pods.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix scroll-spy.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix hotbar-remove-command.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog-entity-registry.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix welcome.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix verify-that-all-routes-have-route-component.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix pod-tolerations.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * better fix for previous 3 fixes, plus also select.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube-object-menu.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix app-paths.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-tabs.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix isReactNode typing Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix sub-title.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix drawer.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix list-layout.tsx and header.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix error-boundary.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix upgrade-chart/store.ts and dock-tab.store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix install-chart/store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix edit-resource/store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix create-resource/store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix namespace-select.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix namespace-select-filter.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix crd-list.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix wrong types for extensions Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix circular dependency Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix circular dependency on catalogCategoryRegistry Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix api-kube Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix type errors, most <Select /> errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * fixing more type errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * some more fixing type errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * convert all KubeApis to injectable with legacy global backups Signed-off-by: Sebastian Malton <sebastian@malton.name> * factor out into a common file all the exports Signed-off-by: Sebastian Malton <sebastian@malton.name> * convert all KubeObjectStores to injectable with legacy global backups Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove unused legacy KubeApi globals Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix bad previous commit Signed-off-by: Sebastian Malton <sebastian@malton.name> * more crash fixing Signed-off-by: Sebastian Malton <sebastian@malton.name> * try and fix behavioural tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix sidebar-and-tab-navigation-for-core.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix sidebar-and-tab-navigation-for-extensions.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-using-application-menu.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make ThemeStore non-singleton and fix navigation-to-terminal-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * extensions.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog-entity-registry.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-using-application-menu.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix log-resource-selector.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-tabs.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix delete-cluster-dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-kubernetes-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-editor-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-proxy-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-using-application-menu.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-application-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix select.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix hotbar-remove-command.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cluster-role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-extension-specific-preferences.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-telemetry-preferences.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix closing-preferences.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-editor-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-proxy-preferences.test.ts - Fix other type errors too Signed-off-by: Sebastian Malton <sebastian@malton.name> * final tweaks Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add more tsconfig files, fix bug in <Catalog> - Make all of history, navigation injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix type errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all of kube-details-params/ and navigate/ to injectable - This fixes a runtime error that was encountered during testing Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix runtime errors on renderer - remove all static uses of `createPageParam` (and then removed the legacy global) - Made LensRendererExtension and LensMainExtension just used dependencies and not the getLegacyDi - Fixed circular dep in extension-loader Signed-off-by: Sebastian Malton <sebastian@malton.name> * Move registerStore calls to after injectMany Signed-off-by: Sebastian Malton <sebastian@malton.name> * replace all the rest of the legacy uses of apiManager Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix stack overflow and cycles in DI Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix NamespaceSelectFilter not opening Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix WizardStep and AddNamespaceDialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix KubeApi's not being registered Signed-off-by: Sebastian Malton <sebastian@malton.name> * cleanup WindowManager Signed-off-by: Sebastian Malton <sebastian@malton.name> * Proper fix for Wizard, fix NamespaceStore.subscribe Signed-off-by: Sebastian Malton <sebastian@malton.name> * Rewrite withTooltip to be more type correct - Fixes mobx related "too many recursive actions" error - Change all the uses of withTooltips to be functional components Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add e2e test to cover kube api registration Signed-off-by: Sebastian Malton <sebastian@malton.name> * cleanup internal-commands Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove cast in <Animate> Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix command-palette e2e test Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix type error after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix test name Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix code to help CodeQL scanner Signed-off-by: Sebastian Malton <sebastian@malton.name> * update intree extension lock files Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix build-extensions picking wrong @types/react Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix tests from rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix type error Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make KubeconfigSyncManager more injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix crash in test mode for Dialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * make Select snapshots deterministic Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix new type error Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube-object.store.test.ts typing Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix merge build issues Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix snapshots after merge Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix lint after merge Signed-off-by: Sebastian Malton <sebastian@malton.name> * reexport BaseKubeJsonApiObjectMetadata Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix typo in terminalSpawningPool Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove duplicate license header Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix typo to waitUntilDefined Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove iter use from getLegacyGlobalDiForExtensionApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove complex createStorage override Signed-off-by: Sebastian Malton <sebastian@malton.name> * override logger with mocks only when needed for tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove specialized overrideStore flags for getDiForUnitTesting Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove unnecessary | undefined types from the exactOptionalFieldTypes experiment Signed-off-by: Sebastian Malton <sebastian@malton.name> * use more descriptive name for local test mocks Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove unnecessary addition to 'make clean' target Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove oddity of KubeObjectStore.getById(undefined) being allowed Signed-off-by: Sebastian Malton <sebastian@malton.name> * rename KubeObject.getDescriptor in favour of name without fundemental JS meaning Signed-off-by: Sebastian Malton <sebastian@malton.name> * Simplify legacyRegisterApi when working in behaviour unit tests - Don't emit within main environment as there should be no auto registering there Signed-off-by: Sebastian Malton <sebastian@malton.name> * change confusing variable name in ReactiveDuration Signed-off-by: Sebastian Malton <sebastian@malton.name> * make visitor pattern more explicit for Entity contextMenuOpen Signed-off-by: Sebastian Malton <sebastian@malton.name> * toggleDetails -> toggleKubeDetailsPane is more specific Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove outdated comment Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix bug where LensExtension dependencies are not set Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests from the revert of react 18 Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix more tests from merge Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix typings with new is-compatible-extension tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * more type fixing Signed-off-by: Sebastian Malton <sebastian@malton.name> * Revert in-tree extension versions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Improve name of guarding injectable for stores and apis - New name better implies that it is just a guard state and does not do anything Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add helper for <Select>.isMulti for storing in a Set<Value> Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix is-compatible-extension.test.ts types Signed-off-by: Sebastian Malton <sebastian@malton.name>
2025-05-20 05:10:56 +00:00 · 2022-05-16 07:17:57 -04:00
1 parent 381d77c633
commit dfcb7c3330
@@ -23,13 +23,17 @@ const addSyncEntriesInjectable = getInjectable({
        await getAllEntries(filePaths, logger),
      );

-      Notifications.ok(
+      Notifications.ok((
        <div>
-          <p>Selected items has been added to Kubeconfig Sync.</p><br/>
-          <p>Check the <a style={{ textDecoration: "underline" }} onClick={navigateToKubernetesPreferences}>Preferences</a>{" "}
-          to see full list.</p>
-        </div>,
-      );
+          <p>Selected items has been added to Kubeconfig Sync.</p>
+          <br/>
+          <p>
+            {"Check the "}
+            <a style={{ textDecoration: "underline" }} onClick={navigateToKubernetesPreferences}>Preferences</a>
+            {" to see full list."}
+          </p>
+        </div>
+      ));
    };
  },
 });
@@ -3,16 +3,21 @@
 * Licensed under MIT License. See LICENSE in root directory for more information.
 */

-import { kubernetesClusterCategory } from "../../common/catalog-entities";
+import type { KubernetesClusterCategory } from "../../common/catalog-entities";
 import { isLinux, isWindows } from "../../common/vars";
 import { PathPicker } from "../components/path-picker";

 interface Dependencies {
  navigateToAddCluster: () => void;
  addSyncEntries: (filePaths: string[]) => void;
+  kubernetesClusterCategory: KubernetesClusterCategory;
 }

-export function initCatalogCategoryRegistryEntries({ navigateToAddCluster, addSyncEntries } : Dependencies) {
+export function initCatalogCategoryRegistryEntries({
+  navigateToAddCluster,
+  addSyncEntries,
+  kubernetesClusterCategory,
+} : Dependencies) {
  kubernetesClusterCategory.on("catalogAddMenu", ctx => {
    ctx.menuItems.push(
      {
@@ -31,6 +31,9 @@ export function initCatalogEntityDetailRegistry() {
          ),
        },
      },
+    ]);
+  CatalogEntityDetailRegistry.getInstance()
+    .add([
      {
        apiVersions: [WebLink.apiVersion],
        kind: WebLink.kind,
@@ -10,33 +10,33 @@ import { ClusterStore } from "../../common/cluster-store/cluster-store";
 import { catalogCategoryRegistry } from "../api/catalog-category-registry";
 import { WeblinkAddCommand } from "../components/catalog-entities/weblink-add-command";
 import { loadConfigFromString } from "../../common/kube-helpers";
-import type { DeleteClusterDialogModel } from "../components/delete-cluster-dialog/delete-cluster-dialog-model/delete-cluster-dialog-model";
+import type { OpenDeleteClusterDialog } from "../components/delete-cluster-dialog/open.injectable";

-async function onClusterDelete(clusterId: string, deleteClusterDialogModel: DeleteClusterDialogModel) {
+async function onClusterDelete(clusterId: string, openDeleteClusterDialog: OpenDeleteClusterDialog) {
  const cluster = ClusterStore.getInstance().getById(clusterId);

  if (!cluster) {
    return console.warn("[KUBERNETES-CLUSTER]: cannot delete cluster, does not exist in store", { clusterId });
  }

-  const { config, error } = loadConfigFromString(await fs.promises.readFile(cluster.kubeConfigPath, "utf-8"));
+  const result = loadConfigFromString(await fs.promises.readFile(cluster.kubeConfigPath, "utf-8"));

-  if (error) {
-    throw error;
+  if (result.error) {
+    throw result.error;
  }

-  deleteClusterDialogModel.open({ cluster, config });
+  openDeleteClusterDialog({ cluster, config: result.config });
 }

 interface Dependencies {
  openCommandDialog: (component: React.ReactElement) => void;
-  deleteClusterDialogModel: DeleteClusterDialogModel;
+  openDeleteClusterDialog: OpenDeleteClusterDialog;
 }

-export function initCatalog({ openCommandDialog, deleteClusterDialogModel }: Dependencies) {
+export function initCatalog({ openCommandDialog, openDeleteClusterDialog }: Dependencies) {
  catalogCategoryRegistry
    .getForGroupKind("entity.k8slens.dev", "WebLink")
-    .on("catalogAddMenu", ctx => {
+    ?.on("catalogAddMenu", ctx => {
      ctx.menuItems.push({
        title: "Add web link",
        icon: "public",
@@ -46,12 +46,12 @@ export function initCatalog({ openCommandDialog, deleteClusterDialogModel }: Dep

  catalogCategoryRegistry
    .getForGroupKind("entity.k8slens.dev", "KubernetesCluster")
-    .on("contextMenuOpen", (entity, context) => {
+    ?.on("contextMenuOpen", (entity, context) => {
      if (entity.metadata?.source == "local") {
        context.menuItems.push({
          title: "Remove",
          icon: "delete",
-          onClick: () => onClusterDelete(entity.getId(), deleteClusterDialogModel),
+          onClick: () => onClusterDelete(entity.getId(), openDeleteClusterDialog),
        });
      }
    });
@@ -9,6 +9,8 @@ import type { LensRendererExtension } from "../../extensions/lens-renderer-exten

 export function initIpcRendererListeners(extensionLoader: ExtensionLoader) {
  ipcRendererOn("extension:navigate", (event, extId: string, pageId ?: string, params?: Record<string, any>) => {
-    extensionLoader.getInstanceById<LensRendererExtension>(extId).navigate(pageId, params);
+    const ext = extensionLoader.getInstanceById(extId) as LensRendererExtension | undefined;
+
+    ext?.navigate(pageId, params);
  });
 }
@@ -16,7 +16,7 @@ import { CRDDetails } from "../components/+custom-resources";
 import { EventDetails } from "../components/+events";
 import { KubeEventDetails } from "../components/+events/kube-event-details";
 import { NamespaceDetails } from "../components/+namespaces";
-import { EndpointDetails } from "../components/+network-endpoints";
+import { EndpointsDetails } from "../components/+network-endpoints";
 import { IngressDetails } from "../components/+network-ingresses";
 import { NetworkPolicyDetails } from "../components/+network-policies";
 import { ServiceDetails } from "../components/+network-services";
@@ -40,395 +40,402 @@ import { StatefulSetDetails } from "../components/+workloads-statefulsets";
 import type { KubeObjectDetailsProps } from "../components/kube-object-details";

 export function initKubeObjectDetailRegistry() {
-  KubeObjectDetailRegistry.getInstance()
-    .add([
-      {
-        kind: "HorizontalPodAutoscaler",
-        apiVersions: ["autoscaling/v2beta1"],
-        components: {
-          // Note: this line is left in the long form as a validation that this usecase is valid
-          Details: (props: HpaDetailsProps) => <HpaDetails {...props}/>,
-        },
-      },
-      {
-        kind: "HorizontalPodAutoscaler",
-        apiVersions: ["autoscaling/v2beta1"],
-        priority: 5,
-        components: {
-          // Note: this line is left in the long form as a validation that this usecase is valid
-          Details: (props: KubeObjectDetailsProps) => <KubeEventDetails {...props}/>,
-        },
-      },
-      {
-        kind: "LimitRange",
-        apiVersions: ["v1"],
-        components: {
-          Details: LimitRangeDetails,
-        },
-      },
-      {
-        kind: "ConfigMap",
-        apiVersions: ["v1"],
-        components: {
-          Details: ConfigMapDetails,
-        },
-      },
-      {
-        kind: "ConfigMap",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "PodDisruptionBudget",
-        apiVersions: ["policy/v1beta1"],
-        components: {
-          Details: PodDisruptionBudgetDetails,
-        },
-      },
-      {
-        kind: "ResourceQuota",
-        apiVersions: ["v1"],
-        components: {
-          Details: ResourceQuotaDetails,
-        },
-      },
-      {
-        kind: "Secret",
-        apiVersions: ["v1"],
-        components: {
-          Details: SecretDetails,
-        },
-      },
-      {
-        kind: "CustomResourceDefinition",
-        apiVersions: ["apiextensions.k8s.io/v1", "apiextensions.k8s.io/v1beta1"],
-        components: {
-          Details: CRDDetails,
-        },
-      },
-      {
-        kind: "Event",
-        apiVersions: ["v1"],
-        components: {
-          Details: EventDetails,
-        },
-      },
-      {
-        kind: "Namespace",
-        apiVersions: ["v1"],
-        components: {
-          Details: NamespaceDetails,
-        },
-      },
-      {
-        kind: "Endpoints",
-        apiVersions: ["v1"],
-        components: {
-          Details: EndpointDetails,
-        },
-      },
-      {
-        kind: "Endpoints",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Ingress",
-        apiVersions: ["networking.k8s.io/v1", "extensions/v1beta1"],
-        components: {
-          Details: IngressDetails,
-        },
-      },
-      {
-        kind: "Ingress",
-        apiVersions: ["networking.k8s.io/v1", "extensions/v1beta1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "NetworkPolicy",
-        apiVersions: ["networking.k8s.io/v1"],
-        components: {
-          Details: NetworkPolicyDetails,
-        },
-      },
-      {
-        kind: "NetworkPolicy",
-        apiVersions: ["networking.k8s.io/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Service",
-        apiVersions: ["v1"],
-        components: {
-          Details: ServiceDetails,
-        },
-      },
-      {
-        kind: "Service",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Node",
-        apiVersions: ["v1"],
-        components: {
-          Details: NodeDetails,
-        },
-      },
-      {
-        kind: "Node",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "PodSecurityPolicy",
-        apiVersions: ["policy/v1beta1"],
-        components: {
-          Details: PodSecurityPolicyDetails,
-        },
-      },
-      {
-        kind: "StorageClass",
-        apiVersions: ["storage.k8s.io/v1"],
-        components: {
-          Details: StorageClassDetails,
-        },
-      },
-      {
-        kind: "StorageClass",
-        apiVersions: ["storage.k8s.io/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "PersistentVolumeClaim",
-        apiVersions: ["v1"],
-        components: {
-          Details: PersistentVolumeClaimDetails,
-        },
-      },
-      {
-        kind: "PersistentVolumeClaim",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "PersistentVolume",
-        apiVersions: ["v1"],
-        components: {
-          Details: PersistentVolumeDetails,
-        },
-      },
-      {
-        kind: "PersistentVolume",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Role",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        components: {
-          Details: RoleDetails,
-        },
-      },
-      {
-        kind: "Role",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "ClusterRole",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        components: {
-          Details: ClusterRoleDetails,
-        },
-      },
-      {
-        kind: "ClusterRole",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "RoleBinding",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        components: {
-          Details: RoleBindingDetails,
-        },
-      },
-      {
-        kind: "RoleBinding",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "ClusterRoleBinding",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        components: {
-          Details: ClusterRoleBindingDetails,
-        },
-      },
-      {
-        kind: "ClusterRoleBinding",
-        apiVersions: ["rbac.authorization.k8s.io/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "ServiceAccount",
-        apiVersions: ["v1"],
-        components: {
-          Details: ServiceAccountsDetails,
-        },
-      },
-      {
-        kind: "ServiceAccount",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "CronJob",
-        apiVersions: ["batch/v1beta1"],
-        components: {
-          Details: CronJobDetails,
-        },
-      },
-      {
-        kind: "CronJob",
-        apiVersions: ["batch/v1beta1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "DaemonSet",
-        apiVersions: ["apps/v1"],
-        components: {
-          Details: DaemonSetDetails,
-        },
-      },
-      {
-        kind: "DaemonSet",
-        apiVersions: ["apps/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Deployment",
-        apiVersions: ["apps/v1"],
-        components: {
-          Details: DeploymentDetails,
-        },
-      },
-      {
-        kind: "Deployment",
-        apiVersions: ["apps/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Job",
-        apiVersions: ["batch/v1"],
-        components: {
-          Details: JobDetails,
-        },
-      },
-      {
-        kind: "Job",
-        apiVersions: ["batch/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "Pod",
-        apiVersions: ["v1"],
-        components: {
-          Details: PodDetails,
-        },
-      },
-      {
-        kind: "Pod",
-        apiVersions: ["v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "ReplicaSet",
-        apiVersions: ["apps/v1"],
-        components: {
-          Details: ReplicaSetDetails,
-        },
-      },
-      {
-        kind: "ReplicaSet",
-        apiVersions: ["apps/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-      {
-        kind: "StatefulSet",
-        apiVersions: ["apps/v1"],
-        components: {
-          Details: StatefulSetDetails,
-        },
-      },
-      {
-        kind: "StatefulSet",
-        apiVersions: ["apps/v1"],
-        priority: 5,
-        components: {
-          Details: KubeEventDetails,
-        },
-      },
-    ]);
+  const registry = KubeObjectDetailRegistry.getInstance();
+
+  registry.add({
+    kind: "HorizontalPodAutoscaler",
+    apiVersions: ["autoscaling/v2beta1"],
+    components: {
+      // Note: this line is left in the long form as a validation that this usecase is valid
+      Details: (props: HpaDetailsProps) => <HpaDetails {...props}/>,
+    },
+  });
+  registry.add({
+    kind: "HorizontalPodAutoscaler",
+    apiVersions: ["autoscaling/v2beta1"],
+    components: {
+      // Note: this line is left in the long form as a validation that this usecase is valid
+      Details: (props: HpaDetailsProps) => <HpaDetails {...props}/>,
+    },
+  });
+  registry.add({
+    kind: "HorizontalPodAutoscaler",
+    apiVersions: ["autoscaling/v2beta1"],
+    priority: 5,
+    components: {
+      // Note: this line is left in the long form as a validation that this usecase is valid
+      Details: (props: KubeObjectDetailsProps) => <KubeEventDetails {...props}/>,
+    },
+  });
+  registry.add({
+    kind: "LimitRange",
+    apiVersions: ["v1"],
+    components: {
+      Details: LimitRangeDetails,
+    },
+  });
+  registry.add({
+    kind: "ConfigMap",
+    apiVersions: ["v1"],
+    components: {
+      Details: ConfigMapDetails,
+    },
+  });
+  registry.add({
+    kind: "ConfigMap",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "PodDisruptionBudget",
+    apiVersions: ["policy/v1beta1"],
+    components: {
+      Details: PodDisruptionBudgetDetails,
+    },
+  });
+  registry.add({
+    kind: "ResourceQuota",
+    apiVersions: ["v1"],
+    components: {
+      Details: ResourceQuotaDetails,
+    },
+  });
+  registry.add({
+    kind: "Secret",
+    apiVersions: ["v1"],
+    components: {
+      Details: SecretDetails,
+    },
+  });
+  registry.add({
+    kind: "CustomResourceDefinition",
+    apiVersions: ["apiextensions.k8s.io/v1", "apiextensions.k8s.io/v1beta1"],
+    components: {
+      Details: CRDDetails,
+    },
+  });
+  registry.add({
+    kind: "Event",
+    apiVersions: ["v1"],
+    components: {
+      Details: EventDetails,
+    },
+  });
+  registry.add({
+    kind: "Namespace",
+    apiVersions: ["v1"],
+    components: {
+      Details: NamespaceDetails,
+    },
+  });
+  registry.add({
+    kind: "Endpoints",
+    apiVersions: ["v1"],
+    components: {
+      Details: EndpointsDetails,
+    },
+  });
+  registry.add({
+    kind: "Endpoints",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Ingress",
+    apiVersions: ["networking.k8s.io/v1", "extensions/v1beta1"],
+    components: {
+      Details: IngressDetails,
+    },
+  });
+  registry.add({
+    kind: "Ingress",
+    apiVersions: ["networking.k8s.io/v1", "extensions/v1beta1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "NetworkPolicy",
+    apiVersions: ["networking.k8s.io/v1"],
+    components: {
+      Details: NetworkPolicyDetails,
+    },
+  });
+  registry.add({
+    kind: "NetworkPolicy",
+    apiVersions: ["networking.k8s.io/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Service",
+    apiVersions: ["v1"],
+    components: {
+      Details: ServiceDetails,
+    },
+  });
+  registry.add({
+    kind: "Service",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Node",
+    apiVersions: ["v1"],
+    components: {
+      Details: NodeDetails,
+    },
+  });
+  registry.add({
+    kind: "Node",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "PodSecurityPolicy",
+    apiVersions: ["policy/v1beta1"],
+    components: {
+      Details: PodSecurityPolicyDetails,
+    },
+  });
+  registry.add({
+    kind: "StorageClass",
+    apiVersions: ["storage.k8s.io/v1"],
+    components: {
+      Details: StorageClassDetails,
+    },
+  });
+  registry.add({
+    kind: "StorageClass",
+    apiVersions: ["storage.k8s.io/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "PersistentVolumeClaim",
+    apiVersions: ["v1"],
+    components: {
+      Details: PersistentVolumeClaimDetails,
+    },
+  });
+  registry.add({
+    kind: "PersistentVolumeClaim",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "PersistentVolume",
+    apiVersions: ["v1"],
+    components: {
+      Details: PersistentVolumeDetails,
+    },
+  });
+  registry.add({
+    kind: "PersistentVolume",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Role",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    components: {
+      Details: RoleDetails,
+    },
+  });
+  registry.add({
+    kind: "Role",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "ClusterRole",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    components: {
+      Details: ClusterRoleDetails,
+    },
+  });
+  registry.add({
+    kind: "ClusterRole",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "RoleBinding",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    components: {
+      Details: RoleBindingDetails,
+    },
+  });
+  registry.add({
+    kind: "RoleBinding",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "ClusterRoleBinding",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    components: {
+      Details: ClusterRoleBindingDetails,
+    },
+  });
+  registry.add({
+    kind: "ClusterRoleBinding",
+    apiVersions: ["rbac.authorization.k8s.io/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "ServiceAccount",
+    apiVersions: ["v1"],
+    components: {
+      Details: ServiceAccountsDetails,
+    },
+  });
+  registry.add({
+    kind: "ServiceAccount",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "CronJob",
+    apiVersions: ["batch/v1beta1"],
+    components: {
+      Details: CronJobDetails,
+    },
+  });
+  registry.add({
+    kind: "CronJob",
+    apiVersions: ["batch/v1beta1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "DaemonSet",
+    apiVersions: ["apps/v1"],
+    components: {
+      Details: DaemonSetDetails,
+    },
+  });
+  registry.add({
+    kind: "DaemonSet",
+    apiVersions: ["apps/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Deployment",
+    apiVersions: ["apps/v1"],
+    components: {
+      Details: DeploymentDetails,
+    },
+  });
+  registry.add({
+    kind: "Deployment",
+    apiVersions: ["apps/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Job",
+    apiVersions: ["batch/v1"],
+    components: {
+      Details: JobDetails,
+    },
+  });
+  registry.add({
+    kind: "Job",
+    apiVersions: ["batch/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "Pod",
+    apiVersions: ["v1"],
+    components: {
+      Details: PodDetails,
+    },
+  });
+  registry.add({
+    kind: "Pod",
+    apiVersions: ["v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "ReplicaSet",
+    apiVersions: ["apps/v1"],
+    components: {
+      Details: ReplicaSetDetails,
+    },
+  });
+  registry.add({
+    kind: "ReplicaSet",
+    apiVersions: ["apps/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
+  registry.add({
+    kind: "StatefulSet",
+    apiVersions: ["apps/v1"],
+    components: {
+      Details: StatefulSetDetails,
+    },
+  });
+  registry.add({
+    kind: "StatefulSet",
+    apiVersions: ["apps/v1"],
+    priority: 5,
+    components: {
+      Details: KubeEventDetails,
+    },
+  });
 }