Turn on strict mode in tsconfig.json, some helpful lints, and required cleanup where strictness necessitates it (#5195)

* Turn on strict mode in tsconfig.json - Add route, clusterRoute, and payloadValidatedClusterRoute helper functions to improve types with backend routes - Turn on the following new lints: - react/jsx-first-prop-new-line - react/jsx-wrap-multilines - react/jsx-one-expression-per-line - react/jsx-max-props-per-line - react/jsx-indent - react/jsx-indent-props Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix build Signed-off-by: Sebastian Malton <sebastian@malton.name> * Replace KubeObject scope strings with enum Signed-off-by: Sebastian Malton <sebastian@malton.name> * Revert package.json version changes Signed-off-by: Sebastian Malton <sebastian@malton.name> * revert move hostedCluster(Id) Signed-off-by: Sebastian Malton <sebastian@malton.name> * change some type param names to be not single letters Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove copy-extension-themes Signed-off-by: Sebastian Malton <sebastian@malton.name> * add new make clean action Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix build to not use webpack for generating types Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube-object-menu.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix select.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * revert move fileNameMigration to index Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix ref logic error Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix log-resource-selector.test.tsx tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-store.test.ts test by overriding createStorage to not touch file system Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cluster.test.ts tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube=api.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fixed hotbar-store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kubeconfig-manager.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cluster-role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix pods.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix delete-cluster-dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix daemonset.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix replicaset.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix statefulsets/dialog/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix replicasets/scale-dialog/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix deployments.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix deployments/scale/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cronjob.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix stateful-set.api.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix deployment.api.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix api-manager.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix statefulset.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix job.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix pods.store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix scroll-spy.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix hotbar-remove-command.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog-entity-registry.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix welcome.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix verify-that-all-routes-have-route-component.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix pod-tolerations.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * better fix for previous 3 fixes, plus also select.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube-object-menu.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix app-paths.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-tabs.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix isReactNode typing Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix sub-title.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix drawer.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix list-layout.tsx and header.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix error-boundary.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix upgrade-chart/store.ts and dock-tab.store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix install-chart/store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix edit-resource/store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix create-resource/store.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix namespace-select.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix namespace-select-filter.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix crd-list.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix wrong types for extensions Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix circular dependency Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix circular dependency on catalogCategoryRegistry Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix api-kube Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix type errors, most <Select /> errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * fixing more type errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * some more fixing type errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * convert all KubeApis to injectable with legacy global backups Signed-off-by: Sebastian Malton <sebastian@malton.name> * factor out into a common file all the exports Signed-off-by: Sebastian Malton <sebastian@malton.name> * convert all KubeObjectStores to injectable with legacy global backups Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove unused legacy KubeApi globals Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix bad previous commit Signed-off-by: Sebastian Malton <sebastian@malton.name> * more crash fixing Signed-off-by: Sebastian Malton <sebastian@malton.name> * try and fix behavioural tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix sidebar-and-tab-navigation-for-core.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix sidebar-and-tab-navigation-for-extensions.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-using-application-menu.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make ThemeStore non-singleton and fix navigation-to-terminal-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * extensions.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix catalog-entity-registry.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-using-application-menu.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix log-resource-selector.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-tabs.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix delete-cluster-dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-kubernetes-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-editor-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-proxy-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-using-application-menu.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-application-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix dock-store.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix select.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix hotbar-remove-command.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix cluster-role-bindings/__tests__/dialog.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-extension-specific-preferences.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-telemetry-preferences.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix closing-preferences.test.tsx Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-editor-preferences.test.ts Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix navigation-to-proxy-preferences.test.ts - Fix other type errors too Signed-off-by: Sebastian Malton <sebastian@malton.name> * final tweaks Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add more tsconfig files, fix bug in <Catalog> - Make all of history, navigation injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix type errors Signed-off-by: Sebastian Malton <sebastian@malton.name> * Convert all of kube-details-params/ and navigate/ to injectable - This fixes a runtime error that was encountered during testing Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix runtime errors on renderer - remove all static uses of `createPageParam` (and then removed the legacy global) - Made LensRendererExtension and LensMainExtension just used dependencies and not the getLegacyDi - Fixed circular dep in extension-loader Signed-off-by: Sebastian Malton <sebastian@malton.name> * Move registerStore calls to after injectMany Signed-off-by: Sebastian Malton <sebastian@malton.name> * replace all the rest of the legacy uses of apiManager Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix stack overflow and cycles in DI Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix NamespaceSelectFilter not opening Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix WizardStep and AddNamespaceDialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix KubeApi's not being registered Signed-off-by: Sebastian Malton <sebastian@malton.name> * cleanup WindowManager Signed-off-by: Sebastian Malton <sebastian@malton.name> * Proper fix for Wizard, fix NamespaceStore.subscribe Signed-off-by: Sebastian Malton <sebastian@malton.name> * Rewrite withTooltip to be more type correct - Fixes mobx related "too many recursive actions" error - Change all the uses of withTooltips to be functional components Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add e2e test to cover kube api registration Signed-off-by: Sebastian Malton <sebastian@malton.name> * cleanup internal-commands Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove cast in <Animate> Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix command-palette e2e test Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix type error after rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix test name Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix lint Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix code to help CodeQL scanner Signed-off-by: Sebastian Malton <sebastian@malton.name> * update intree extension lock files Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix build-extensions picking wrong @types/react Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix tests from rebase Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix type error Signed-off-by: Sebastian Malton <sebastian@malton.name> * Make KubeconfigSyncManager more injectable Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix crash in test mode for Dialog Signed-off-by: Sebastian Malton <sebastian@malton.name> * make Select snapshots deterministic Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix new type error Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix kube-object.store.test.ts typing Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix merge build issues Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix snapshots after merge Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix lint after merge Signed-off-by: Sebastian Malton <sebastian@malton.name> * reexport BaseKubeJsonApiObjectMetadata Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix typo in terminalSpawningPool Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove duplicate license header Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix typo to waitUntilDefined Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove iter use from getLegacyGlobalDiForExtensionApi Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove complex createStorage override Signed-off-by: Sebastian Malton <sebastian@malton.name> * override logger with mocks only when needed for tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove specialized overrideStore flags for getDiForUnitTesting Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove unnecessary | undefined types from the exactOptionalFieldTypes experiment Signed-off-by: Sebastian Malton <sebastian@malton.name> * use more descriptive name for local test mocks Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove unnecessary addition to 'make clean' target Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove oddity of KubeObjectStore.getById(undefined) being allowed Signed-off-by: Sebastian Malton <sebastian@malton.name> * rename KubeObject.getDescriptor in favour of name without fundemental JS meaning Signed-off-by: Sebastian Malton <sebastian@malton.name> * Simplify legacyRegisterApi when working in behaviour unit tests - Don't emit within main environment as there should be no auto registering there Signed-off-by: Sebastian Malton <sebastian@malton.name> * change confusing variable name in ReactiveDuration Signed-off-by: Sebastian Malton <sebastian@malton.name> * make visitor pattern more explicit for Entity contextMenuOpen Signed-off-by: Sebastian Malton <sebastian@malton.name> * toggleDetails -> toggleKubeDetailsPane is more specific Signed-off-by: Sebastian Malton <sebastian@malton.name> * remove outdated comment Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix bug where LensExtension dependencies are not set Signed-off-by: Sebastian Malton <sebastian@malton.name> * Fix tests from the revert of react 18 Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix more tests from merge Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix typings with new is-compatible-extension tests Signed-off-by: Sebastian Malton <sebastian@malton.name> * more type fixing Signed-off-by: Sebastian Malton <sebastian@malton.name> * Revert in-tree extension versions Signed-off-by: Sebastian Malton <sebastian@malton.name> * Improve name of guarding injectable for stores and apis - New name better implies that it is just a guard state and does not do anything Signed-off-by: Sebastian Malton <sebastian@malton.name> * Add helper for <Select>.isMulti for storing in a Set<Value> Signed-off-by: Sebastian Malton <sebastian@malton.name> * fix is-compatible-extension.test.ts types Signed-off-by: Sebastian Malton <sebastian@malton.name>
2025-05-20 05:10:56 +00:00 · 2022-05-16 07:17:57 -04:00
1 parent 381d77c633
commit dfcb7c3330
@@ -12,25 +12,22 @@ import navigateToExtensionsInjectable from "../../../common/front-end-routing/ro
 import navigateToEntitySettingsInjectable from "../../../common/front-end-routing/routes/entity-settings/navigate-to-entity-settings.injectable";
 import navigateToClusterViewInjectable from "../../../common/front-end-routing/routes/cluster-view/navigate-to-cluster-view.injectable";
 import navigateToPreferenceTabIdInjectable from "./navigate-to-preference-tab-id.injectable";
+import catalogEntityRegistryInjectable from "../../api/catalog/entity/registry.injectable";

 const bindProtocolAddRouteHandlersInjectable = getInjectable({
  id: "bind-protocol-add-route-handlers",

-  instantiate: (di) =>
-    bindProtocolAddRouteHandlers({
-      attemptInstallByInfo: di.inject(attemptInstallByInfoInjectable),
-
-      lensProtocolRouterRenderer: di.inject(
-        lensProtocolRouterRendererInjectable,
-      ),
-
-      navigateToCatalog: di.inject(navigateToCatalogInjectable),
-      navigateToAddCluster: di.inject(navigateToAddClusterInjectable),
-      navigateToExtensions: di.inject(navigateToExtensionsInjectable),
-      navigateToEntitySettings: di.inject(navigateToEntitySettingsInjectable),
-      navigateToClusterView: di.inject(navigateToClusterViewInjectable),
-      navigateToPreferenceTabId: di.inject(navigateToPreferenceTabIdInjectable),
-    }),
+  instantiate: (di) => bindProtocolAddRouteHandlers({
+    attemptInstallByInfo: di.inject(attemptInstallByInfoInjectable),
+    lensProtocolRouterRenderer: di.inject(lensProtocolRouterRendererInjectable ),
+    navigateToCatalog: di.inject(navigateToCatalogInjectable),
+    navigateToAddCluster: di.inject(navigateToAddClusterInjectable),
+    navigateToExtensions: di.inject(navigateToExtensionsInjectable),
+    navigateToEntitySettings: di.inject(navigateToEntitySettingsInjectable),
+    navigateToClusterView: di.inject(navigateToClusterViewInjectable),
+    navigateToPreferenceTabId: di.inject(navigateToPreferenceTabIdInjectable),
+    entityRegistry: di.inject(catalogEntityRegistryInjectable),
+  }),
 });

 export default bindProtocolAddRouteHandlersInjectable;
@@ -5,7 +5,7 @@

 import React from "react";
 import type { LensProtocolRouterRenderer } from "../lens-protocol-router-renderer/lens-protocol-router-renderer";
-import { catalogEntityRegistry } from "../../api/catalog-entity-registry";
+import type { CatalogEntityRegistry } from "../../api/catalog/entity/registry";
 import { ClusterStore } from "../../../common/cluster-store/cluster-store";
 import {
  EXTENSION_NAME_MATCH,
@@ -16,8 +16,10 @@ import { Notifications } from "../../components/notifications";
 import type { NavigateToCatalog } from "../../../common/front-end-routing/routes/catalog/navigate-to-catalog.injectable";
 import type { NavigateToEntitySettings } from "../../../common/front-end-routing/routes/entity-settings/navigate-to-entity-settings.injectable";
 import type { NavigateToClusterView } from "../../../common/front-end-routing/routes/cluster-view/navigate-to-cluster-view.injectable";
+import assert from "assert";
 import type { AttemptInstallByInfo } from "../../components/+extensions/attempt-install-by-info.injectable";

+// TODO: make it so that the handlers are type safe and we don't need to do the asserts
 interface Dependencies {
  attemptInstallByInfo: AttemptInstallByInfo;
  lensProtocolRouterRenderer: LensProtocolRouterRenderer;
@@ -27,103 +29,112 @@ interface Dependencies {
  navigateToEntitySettings: NavigateToEntitySettings;
  navigateToClusterView: NavigateToClusterView;
  navigateToPreferenceTabId: (tabId: string) => void;
+  entityRegistry: CatalogEntityRegistry;
 }

-export const bindProtocolAddRouteHandlers =
-  ({ attemptInstallByInfo, lensProtocolRouterRenderer, navigateToCatalog, navigateToAddCluster, navigateToExtensions, navigateToEntitySettings, navigateToClusterView, navigateToPreferenceTabId }: Dependencies) =>
-    () => {
-      lensProtocolRouterRenderer
-        .addInternalHandler("/preferences", ({ search: { highlight: tabId }}) => {
-          navigateToPreferenceTabId(tabId);
-        })
-        .addInternalHandler("/", ({ tail }) => {
-          if (tail) {
-            Notifications.shortInfo(
-              <p>
-              Unknown Action for <code>lens://app/{tail}</code>. Are you on the
-              latest version?
-              </p>,
-            );
-          }
-
-          navigateToCatalog();
-        })
-        .addInternalHandler("/landing", () => {
-          navigateToCatalog();
-        })
-        .addInternalHandler(
-          "/landing/view/:group/:kind",
-          ({ pathname: { group, kind }}) => {
-            navigateToCatalog({ group, kind });
-          },
-        )
-        .addInternalHandler("/cluster", () => {
-          navigateToAddCluster();
-        })
-        .addInternalHandler(
-          "/entity/:entityId/settings",
-          ({ pathname: { entityId }}) => {
-            const entity = catalogEntityRegistry.getById(entityId);
-
-            if (entity) {
-              navigateToEntitySettings(entityId);
-            } else {
-              Notifications.shortInfo(
-                <p>
-                Unknown catalog entity <code>{entityId}</code>.
-                </p>,
-              );
-            }
-          },
-        )
-      // Handlers below are deprecated and only kept for backward compact purposes
-        .addInternalHandler(
-          "/cluster/:clusterId",
-          ({ pathname: { clusterId }}) => {
-            const cluster = ClusterStore.getInstance().getById(clusterId);
-
-            if (cluster) {
-              navigateToClusterView(clusterId);
-            } else {
-              Notifications.shortInfo(
-                <p>
-                Unknown catalog entity <code>{clusterId}</code>.
-                </p>,
-              );
-            }
-          },
-        )
-        .addInternalHandler(
-          "/cluster/:clusterId/settings",
-          ({ pathname: { clusterId }}) => {
-            const cluster = ClusterStore.getInstance().getById(clusterId);
-
-            if (cluster) {
-              navigateToEntitySettings(clusterId);
-            } else {
-              Notifications.shortInfo(
-                <p>
-                Unknown catalog entity <code>{clusterId}</code>.
-                </p>,
-              );
-            }
-          },
-        )
-        .addInternalHandler("/extensions", () => {
-          navigateToExtensions();
-        })
-        .addInternalHandler(
-          `/extensions/install${LensProtocolRouter.ExtensionUrlSchema}`,
-          ({ pathname, search: { version }}) => {
-            const name = [
-              pathname[EXTENSION_PUBLISHER_MATCH],
-              pathname[EXTENSION_NAME_MATCH],
-            ]
-              .filter(Boolean)
-              .join("/");
-
-            navigateToExtensions();
-            attemptInstallByInfo({ name, version, requireConfirmation: true });
-          },
+export const bindProtocolAddRouteHandlers = ({
+  attemptInstallByInfo,
+  lensProtocolRouterRenderer,
+  navigateToCatalog,
+  navigateToAddCluster,
+  navigateToExtensions,
+  navigateToEntitySettings,
+  navigateToClusterView,
+  navigateToPreferenceTabId,
+  entityRegistry,
+}: Dependencies) => () => {
+  lensProtocolRouterRenderer
+    .addInternalHandler("/preferences", ({ search: { highlight: tabId }}) => {
+      if (tabId) {
+        navigateToPreferenceTabId(tabId);
+      }
+    })
+    .addInternalHandler("/", ({ tail }) => {
+      if (tail) {
+        Notifications.shortInfo(
+          <p>
+            {"Unknown Action for "}
+            <code>
+              lens://app/
+              {tail}
+            </code>
+            . Are you on the latest version?
+          </p>,
        );
-    };
+      }
+
+      navigateToCatalog();
+    })
+    .addInternalHandler("/landing", () => {
+      navigateToCatalog();
+    })
+    .addInternalHandler("/landing/view/:group/:kind", ({ pathname: { group, kind }}) => {
+      navigateToCatalog({ group, kind });
+    })
+    .addInternalHandler("/cluster", () => {
+      navigateToAddCluster();
+    })
+    .addInternalHandler("/entity/:entityId/settings", ({ pathname: { entityId }}) => {
+      assert(entityId);
+      const entity = entityRegistry.getById(entityId);
+
+      if (entity) {
+        navigateToEntitySettings(entityId);
+      } else {
+        Notifications.shortInfo(
+          <p>
+            {"Unknown catalog entity "}
+            <code>{entityId}</code>
+            .
+          </p>,
+        );
+      }
+    })
+    // Handlers below are deprecated and only kept for backward compact purposes
+    .addInternalHandler("/cluster/:clusterId", ({ pathname: { clusterId }}) => {
+      assert(clusterId);
+      const cluster = ClusterStore.getInstance().getById(clusterId);
+
+      if (cluster) {
+        navigateToClusterView(clusterId);
+      } else {
+        Notifications.shortInfo(
+          <p>
+            {"Unknown catalog entity "}
+            <code>{clusterId}</code>
+            .
+          </p>,
+        );
+      }
+    })
+    .addInternalHandler("/cluster/:clusterId/settings", ({ pathname: { clusterId }}) => {
+      assert(clusterId);
+      const cluster = ClusterStore.getInstance().getById(clusterId);
+
+      if (cluster) {
+        navigateToEntitySettings(clusterId);
+      } else {
+        Notifications.shortInfo(
+          <p>
+            {"Unknown catalog entity "}
+            <code>{clusterId}</code>
+            .
+          </p>,
+        );
+      }
+    })
+    .addInternalHandler("/extensions", () => {
+      navigateToExtensions();
+    })
+    .addInternalHandler(`/extensions/install${LensProtocolRouter.ExtensionUrlSchema}`, ({ pathname, search: { version }}) => {
+      const name = [
+        pathname[EXTENSION_PUBLISHER_MATCH],
+        pathname[EXTENSION_NAME_MATCH],
+      ]
+        .filter(Boolean)
+        .join("/");
+
+      navigateToExtensions();
+      attemptInstallByInfo({ name, version, requireConfirmation: true });
+    });
+};
@@ -55,12 +55,13 @@ export class LensProtocolRouterRenderer extends proto.LensProtocolRouter {
        const rendererAttempt = this._routeToInternal(new Url(rawUrl, true));

        if (foldAttemptResults(mainAttemptResult, rendererAttempt) === RouteAttempt.MISSING) {
-          Notifications.shortInfo(
+          Notifications.shortInfo((
            <p>
-              Unknown action <code>{rawUrl}</code>.{" "}
-              Are you on the latest version?
-            </p>,
-          );
+              {"Unknown action "}
+              <code>{rawUrl}</code>
+              {". Are you on the latest version?"}
+            </p>
+          ));
        }
      },
    });
@@ -73,21 +74,22 @@ export class LensProtocolRouterRenderer extends proto.LensProtocolRouter {

        switch (foldAttemptResults(mainAttemptResult, rendererAttempt)) {
          case RouteAttempt.MISSING:
-            Notifications.shortInfo(
+            Notifications.shortInfo((
              <p>
-                Unknown action <code>{rawUrl}</code>.{" "}
-                Are you on the latest version of the extension?
-              </p>,
-            );
+                {"Unknown action "}
+                <code>{rawUrl}</code>
+                {". Are you on the latest version of the extension?"}
+              </p>
+            ));
            break;
          case RouteAttempt.MISSING_EXTENSION:
-            Notifications.shortInfo(
+            Notifications.shortInfo((
              <p>
-                Missing extension for action <code>{rawUrl}</code>.{" "}
-                Not able to find extension in our known list.{" "}
-                Try installing it manually.
-              </p>,
-            );
+                {"Missing extension for action "}
+                <code>{rawUrl}</code>
+                {". Not able to find extension in our known list. Try installing it manually."}
+              </p>
+            ));
            break;
        }
      },
@@ -99,10 +101,14 @@ export class LensProtocolRouterRenderer extends proto.LensProtocolRouter {
        Notifications.error((
          <>
            <p>
-              Failed to route <code>{rawUrl}</code>.
+              {"Failed to route "}
+              <code>{rawUrl}</code>
+              .
            </p>
            <p>
-              <b>Error:</b> {error}
+              <b>Error:</b>
+              {" "}
+              {error}
            </p>
          </>
        ));