From 70967294e78597b4cf85a0181887fea8453b0fd0 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 29 Aug 2022 07:39:14 -0700 Subject: [PATCH 01/21] Revert eslint-plugin-react to 7.30.1 to fix linting (#6130) --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 523e78c75b..b0be4336de 100644 --- a/package.json +++ b/package.json @@ -383,7 +383,7 @@ "eslint": "^8.22.0", "eslint-plugin-header": "^3.1.1", "eslint-plugin-import": "^2.26.0", - "eslint-plugin-react": "^7.31.0", + "eslint-plugin-react": "7.30.1", "eslint-plugin-react-hooks": "^4.6.0", "eslint-plugin-unused-imports": "^2.0.0", "flex.box": "^3.4.4", diff --git a/yarn.lock b/yarn.lock index bd1ba7712e..f1315fb493 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5852,10 +5852,10 @@ eslint-plugin-react-hooks@^4.6.0: resolved "https://registry.yarnpkg.com/eslint-plugin-react-hooks/-/eslint-plugin-react-hooks-4.6.0.tgz#4c3e697ad95b77e93f8646aaa1630c1ba607edd3" integrity sha512-oFc7Itz9Qxh2x4gNHStv3BqJq54ExXmfC+a1NjAta66IAN87Wu0R/QArgIS9qKzX3dXKPI9H5crl9QchNMY9+g== -eslint-plugin-react@^7.31.0: - version "7.31.1" - resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.31.1.tgz#d29793ed27743f3ed8a473c347b1bf5a0a8fb9af" - integrity sha512-j4/2xWqt/R7AZzG8CakGHA6Xa/u7iR8Q3xCxY+AUghdT92bnIDOBEefV456OeH0QvBcroVc0eyvrrLSyQGYIfg== +eslint-plugin-react@7.30.1: + version "7.30.1" + resolved "https://registry.yarnpkg.com/eslint-plugin-react/-/eslint-plugin-react-7.30.1.tgz#2be4ab23ce09b5949c6631413ba64b2810fd3e22" + integrity sha512-NbEvI9jtqO46yJA3wcRF9Mo0lF9T/jhdHqhCHXiXtD+Zcb98812wvokjWpU7Q4QH5edo6dmqrukxVvWWXHlsUg== dependencies: array-includes "^3.1.5" array.prototype.flatmap "^1.3.0" From 45a4de5ae5ad4ef9607197ee88353226523f19af Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 29 Aug 2022 10:48:39 -0400 Subject: [PATCH 02/21] Bump @types/semver from 7.3.10 to 7.3.12 (#6127) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- package.json | 2 +- yarn.lock | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index b0be4336de..2447201e14 100644 --- a/package.json +++ b/package.json @@ -348,7 +348,7 @@ "@types/readable-stream": "^2.3.13", "@types/request": "^2.48.7", "@types/request-promise-native": "^1.0.18", - "@types/semver": "^7.3.10", + "@types/semver": "^7.3.12", "@types/sharp": "^0.30.5", "@types/spdy": "^3.4.5", "@types/tar": "^4.0.5", diff --git a/yarn.lock b/yarn.lock index f1315fb493..d6351cfad4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2337,10 +2337,10 @@ resolved "https://registry.yarnpkg.com/@types/scheduler/-/scheduler-0.16.2.tgz#1a62f89525723dde24ba1b01b092bf5df8ad4d39" integrity sha512-hppQEBDmlwhFAXKJX2KnWLYu5yMfi91yazPb2l+lbJiwW+wdo1gNeRA+3RgNSO39WYX2euey41KEwnqesU2Jew== -"@types/semver@^7.3.10", "@types/semver@^7.3.6": - version "7.3.10" - resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.3.10.tgz#5f19ee40cbeff87d916eedc8c2bfe2305d957f73" - integrity sha512-zsv3fsC7S84NN6nPK06u79oWgrPVd0NvOyqgghV1haPaFcVxIrP4DLomRwGAXk0ui4HZA7mOcSFL98sMVW9viw== +"@types/semver@^7.3.12", "@types/semver@^7.3.6": + version "7.3.12" + resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.3.12.tgz#920447fdd78d76b19de0438b7f60df3c4a80bf1c" + integrity sha512-WwA1MW0++RfXmCr12xeYOOC5baSC9mSb0ZqCquFzKhcoF4TvHu5MKOuXsncgZcpVFhB1pXd5hZmM0ryAoCp12A== "@types/serve-index@^1.9.1": version "1.9.1" From 63d7b9b99155a106c061bf9eb7ce1d8233b50d3f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 29 Aug 2022 10:49:37 -0400 Subject: [PATCH 03/21] Bump typedoc from 0.23.10 to 0.23.11 (#6124) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- package.json | 2 +- yarn.lock | 32 ++++++++++++++++---------------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/package.json b/package.json index 2447201e14..e6347a1702 100644 --- a/package.json +++ b/package.json @@ -426,7 +426,7 @@ "ts-node": "^10.9.1", "type-fest": "^2.14.0", "typed-emitter": "^1.4.0", - "typedoc": "0.23.10", + "typedoc": "0.23.11", "typedoc-plugin-markdown": "^3.13.1", "typescript": "^4.7.4", "typescript-plugin-css-modules": "^3.4.0", diff --git a/yarn.lock b/yarn.lock index d6351cfad4..9104ed23fc 100644 --- a/yarn.lock +++ b/yarn.lock @@ -9387,7 +9387,7 @@ markdown@^0.5.0: dependencies: nopt "~2.1.1" -marked@^4.0.18, marked@^4.0.19: +marked@^4.0.19: version "4.0.19" resolved "https://registry.yarnpkg.com/marked/-/marked-4.0.19.tgz#d36198d1ac1255525153c351c68c75bc1d7aee46" integrity sha512-rgQF/OxOiLcvgUAj1Q1tAf4Bgxn5h5JZTp04Fx4XUkVhs7B+7YA9JEWJhJpoO8eJt8MkZMwqLCNeNqj1bCREZQ== @@ -12321,14 +12321,14 @@ shelljs@^0.8.5: interpret "^1.0.0" rechoir "^0.6.2" -shiki@^0.10.1: - version "0.10.1" - resolved "https://registry.yarnpkg.com/shiki/-/shiki-0.10.1.tgz#6f9a16205a823b56c072d0f1a0bcd0f2646bef14" - integrity sha512-VsY7QJVzU51j5o1+DguUd+6vmCmZ5v/6gYu4vyYAhzjuNQU6P/vmSy4uQaOhvje031qQMiW0d2BwgMH52vqMng== +shiki@^0.11.1: + version "0.11.1" + resolved "https://registry.yarnpkg.com/shiki/-/shiki-0.11.1.tgz#df0f719e7ab592c484d8b73ec10e215a503ab8cc" + integrity sha512-EugY9VASFuDqOexOgXR18ZV+TbFrQHeCpEYaXamO+SZlsnT/2LxuLBX25GGtIrwaEVFXUAbUQ601SWE2rMwWHA== dependencies: jsonc-parser "^3.0.0" vscode-oniguruma "^1.6.1" - vscode-textmate "5.2.0" + vscode-textmate "^6.0.0" side-channel@^1.0.4: version "1.0.4" @@ -13464,15 +13464,15 @@ typedoc-plugin-markdown@^3.13.1: dependencies: handlebars "^4.7.7" -typedoc@0.23.10: - version "0.23.10" - resolved "https://registry.yarnpkg.com/typedoc/-/typedoc-0.23.10.tgz#285d595a5f2e35ccdf6f38eba4dfe951d5bff461" - integrity sha512-03EUiu/ZuScUBMnY6p0lY+HTH8SwhzvRE3gImoemdPDWXPXlks83UGTx++lyquWeB1MTwm9D9Ca8RIjkK3AFfQ== +typedoc@0.23.11: + version "0.23.11" + resolved "https://registry.yarnpkg.com/typedoc/-/typedoc-0.23.11.tgz#eacdc389038efd6de40a3c4561c413ad00f1ab16" + integrity sha512-FhZ2HfqlS++53UwHk4txCsTrTlpYR0So/0osMyBeP1E7llRNRqycJGfYK1qx9Wvvv5VO8tGdpwzOwDW5FrTi7A== dependencies: lunr "^2.3.9" - marked "^4.0.18" + marked "^4.0.19" minimatch "^5.1.0" - shiki "^0.10.1" + shiki "^0.11.1" typescript-plugin-css-modules@^3.4.0: version "3.4.0" @@ -13798,10 +13798,10 @@ vscode-oniguruma@^1.6.1: resolved "https://registry.yarnpkg.com/vscode-oniguruma/-/vscode-oniguruma-1.6.2.tgz#aeb9771a2f1dbfc9083c8a7fdd9cccaa3f386607" integrity sha512-KH8+KKov5eS/9WhofZR8M8dMHWN2gTxjMsG4jd04YhpbPR91fUj7rYQ2/XjeHCJWbg7X++ApRIU9NUwM2vTvLA== -vscode-textmate@5.2.0: - version "5.2.0" - resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-5.2.0.tgz#01f01760a391e8222fe4f33fbccbd1ad71aed74e" - integrity sha512-Uw5ooOQxRASHgu6C7GVvUxisKXfSgW4oFlO+aa+PAkgmH89O3CXxEEzNRNtHSqtXFTl0nAC1uYj0GMSH27uwtQ== +vscode-textmate@^6.0.0: + version "6.0.0" + resolved "https://registry.yarnpkg.com/vscode-textmate/-/vscode-textmate-6.0.0.tgz#a3777197235036814ac9a92451492f2748589210" + integrity sha512-gu73tuZfJgu+mvCSy4UZwd2JXykjK9zAZsfmDeut5dx/1a7FeTk0XwJsSuqQn+cuMCGVbIBfl+s53X4T19DnzQ== w3c-hr-time@^1.0.2: version "1.0.2" From f2c392edde3e619a211d1f88e3a679f7b1fca788 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 29 Aug 2022 10:49:54 -0400 Subject: [PATCH 04/21] Bump playwright from 1.24.2 to 1.25.1 (#6126) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- package.json | 2 +- yarn.lock | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index e6347a1702..19de3e7750 100644 --- a/package.json +++ b/package.json @@ -404,7 +404,7 @@ "node-gyp": "^8.3.0", "node-loader": "^2.0.0", "nodemon": "^2.0.19", - "playwright": "^1.24.2", + "playwright": "^1.25.1", "postcss": "^8.4.16", "postcss-loader": "^6.2.1", "randomcolor": "^0.6.2", diff --git a/yarn.lock b/yarn.lock index 9104ed23fc..5eb918bee7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10884,17 +10884,17 @@ pkg-up@^3.1.0: dependencies: find-up "^3.0.0" -playwright-core@1.24.2: - version "1.24.2" - resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.24.2.tgz#47bc5adf3dcfcc297a5a7a332449c9009987db26" - integrity sha512-zfAoDoPY/0sDLsgSgLZwWmSCevIg1ym7CppBwllguVBNiHeixZkc1AdMuYUPZC6AdEYc4CxWEyLMBTw2YcmRrA== +playwright-core@1.25.1: + version "1.25.1" + resolved "https://registry.yarnpkg.com/playwright-core/-/playwright-core-1.25.1.tgz#abe56aec8bef645fba988320d9f9328fafab0446" + integrity sha512-lSvPCmA2n7LawD2Hw7gSCLScZ+vYRkhU8xH0AapMyzwN+ojoDqhkH/KIEUxwNu2PjPoE/fcE0wLAksdOhJ2O5g== -playwright@^1.24.2: - version "1.24.2" - resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.24.2.tgz#51e60f128b386023e5ee83deca23453aaf73ba6d" - integrity sha512-iMWDLgaFRT+7dXsNeYwgl8nhLHsUrzFyaRVC+ftr++P1dVs70mPrFKBZrGp1fOKigHV9d1syC03IpPbqLKlPsg== +playwright@^1.25.1: + version "1.25.1" + resolved "https://registry.yarnpkg.com/playwright/-/playwright-1.25.1.tgz#23fe129ca05568a72ee2a3842baa0a1985d1b345" + integrity sha512-kOlW7mllnQ70ALTwAor73q/FhdH9EEXLUqjdzqioYLcSVC4n4NBfDqeCikGuayFZrLECLkU6Hcbziy/szqTXSA== dependencies: - playwright-core "1.24.2" + playwright-core "1.25.1" plist@^3.0.1, plist@^3.0.4: version "3.0.5" From 642300c71fa0ca0af9801825b14fbbb0754cdb75 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 29 Aug 2022 10:50:17 -0400 Subject: [PATCH 05/21] Bump eslint from 8.22.0 to 8.23.0 (#6125) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- package.json | 2 +- yarn.lock | 42 +++++++++++++++++++++--------------------- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/package.json b/package.json index 19de3e7750..3f53e2aabe 100644 --- a/package.json +++ b/package.json @@ -380,7 +380,7 @@ "electron-notarize": "^0.3.0", "esbuild": "^0.15.5", "esbuild-loader": "^2.19.0", - "eslint": "^8.22.0", + "eslint": "^8.23.0", "eslint-plugin-header": "^3.1.1", "eslint-plugin-import": "^2.26.0", "eslint-plugin-react": "7.30.1", diff --git a/yarn.lock b/yarn.lock index 5eb918bee7..514e0dde3a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -608,14 +608,14 @@ resolved "https://registry.yarnpkg.com/@esbuild/linux-loong64/-/linux-loong64-0.15.5.tgz#91aef76d332cdc7c8942b600fa2307f3387e6f82" integrity sha512-UHkDFCfSGTuXq08oQltXxSZmH1TXyWsL+4QhZDWvvLl6mEJQqk3u7/wq1LjhrrAXYIllaTtRSzUXl4Olkf2J8A== -"@eslint/eslintrc@^1.3.0": - version "1.3.0" - resolved "https://registry.yarnpkg.com/@eslint/eslintrc/-/eslintrc-1.3.0.tgz#29f92c30bb3e771e4a2048c95fa6855392dfac4f" - integrity sha512-UWW0TMTmk2d7hLcWD1/e2g5HDM/HQ3csaLSqXCfqwh4uNDuNqlaKWXmEsL4Cs41Z0KnILNvwbHAah3C2yt06kw== +"@eslint/eslintrc@^1.3.1": + version "1.3.1" + resolved "https://registry.yarnpkg.com/@eslint/eslintrc/-/eslintrc-1.3.1.tgz#de0807bfeffc37b964a7d0400e0c348ce5a2543d" + integrity sha512-OhSY22oQQdw3zgPOOwdoj01l/Dzl1Z+xyUP33tkSN+aqyEhymJCcPHyXt+ylW8FSe0TfRC2VG+ROQOapD0aZSQ== dependencies: ajv "^6.12.4" debug "^4.3.2" - espree "^9.3.2" + espree "^9.4.0" globals "^13.15.0" ignore "^5.2.0" import-fresh "^3.2.1" @@ -753,6 +753,11 @@ resolved "https://registry.yarnpkg.com/@humanwhocodes/gitignore-to-minimatch/-/gitignore-to-minimatch-1.0.2.tgz#316b0a63b91c10e53f242efb4ace5c3b34e8728d" integrity sha512-rSqmMJDdLFUsyxR6FMtD00nfQKKLFb1kv+qBbOVKqErvloEIJLo5bDTJTQNTYgeyp78JsA7u/NPi5jT1GR/MuA== +"@humanwhocodes/module-importer@^1.0.1": + version "1.0.1" + resolved "https://registry.yarnpkg.com/@humanwhocodes/module-importer/-/module-importer-1.0.1.tgz#af5b2691a22b44be847b0ca81641c5fb6ad0172c" + integrity sha512-bxveV4V8v5Yb4ncFTT3rPSgZBOpCkjfK0y4oVVVJwIuDVBRMDXrPyXRL988i5ap9m9bnyEEjWfm5WkBmtffLfA== + "@humanwhocodes/object-schema@^1.2.1": version "1.2.1" resolved "https://registry.yarnpkg.com/@humanwhocodes/object-schema/-/object-schema-1.2.1.tgz#b520529ec21d8e5945a1851dfd1c32e94e39ff45" @@ -5917,14 +5922,15 @@ eslint-visitor-keys@^3.3.0: resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-3.3.0.tgz#f6480fa6b1f30efe2d1968aa8ac745b862469826" integrity sha512-mQ+suqKJVyeuwGYHAdjMFqjCyfl8+Ldnxuyp3ldiMBFKkvytrXUZWaiPCEav8qDHKty44bD+qV1IP4T+w+xXRA== -eslint@^8.22.0: - version "8.22.0" - resolved "https://registry.yarnpkg.com/eslint/-/eslint-8.22.0.tgz#78fcb044196dfa7eef30a9d65944f6f980402c48" - integrity sha512-ci4t0sz6vSRKdmkOGmprBo6fmI4PrphDFMy5JEq/fNS0gQkJM3rLmrqcp8ipMcdobH3KtUP40KniAE9W19S4wA== +eslint@^8.23.0: + version "8.23.0" + resolved "https://registry.yarnpkg.com/eslint/-/eslint-8.23.0.tgz#a184918d288820179c6041bb3ddcc99ce6eea040" + integrity sha512-pBG/XOn0MsJcKcTRLr27S5HpzQo4kLr+HjLQIyK4EiCsijDl/TB+h5uEuJU6bQ8Edvwz1XWOjpaP2qgnXGpTcA== dependencies: - "@eslint/eslintrc" "^1.3.0" + "@eslint/eslintrc" "^1.3.1" "@humanwhocodes/config-array" "^0.10.4" "@humanwhocodes/gitignore-to-minimatch" "^1.0.2" + "@humanwhocodes/module-importer" "^1.0.1" ajv "^6.10.0" chalk "^4.0.0" cross-spawn "^7.0.2" @@ -5934,7 +5940,7 @@ eslint@^8.22.0: eslint-scope "^7.1.1" eslint-utils "^3.0.0" eslint-visitor-keys "^3.3.0" - espree "^9.3.3" + espree "^9.4.0" esquery "^1.4.0" esutils "^2.0.2" fast-deep-equal "^3.1.3" @@ -5960,12 +5966,11 @@ eslint@^8.22.0: strip-ansi "^6.0.1" strip-json-comments "^3.1.0" text-table "^0.2.0" - v8-compile-cache "^2.0.3" -espree@^9.3.2, espree@^9.3.3: - version "9.3.3" - resolved "https://registry.yarnpkg.com/espree/-/espree-9.3.3.tgz#2dd37c4162bb05f433ad3c1a52ddf8a49dc08e9d" - integrity sha512-ORs1Rt/uQTqUKjDdGCyrtYxbazf5umATSf/K4qxjmZHORR6HJk+2s/2Pqe+Kk49HHINC/xNIrGfgh8sZcll0ng== +espree@^9.4.0: + version "9.4.0" + resolved "https://registry.yarnpkg.com/espree/-/espree-9.4.0.tgz#cd4bc3d6e9336c433265fc0aa016fc1aaf182f8a" + integrity sha512-DQmnRpLj7f6TgN/NYb0MTzJXL+vJF9h3pHy4JhCIs3zwcgez8xmGg3sXHcEO97BrmO2OSvCwMdfdlyl+E9KjOw== dependencies: acorn "^8.8.0" acorn-jsx "^5.3.2" @@ -13736,11 +13741,6 @@ v8-compile-cache-lib@^3.0.1: resolved "https://registry.yarnpkg.com/v8-compile-cache-lib/-/v8-compile-cache-lib-3.0.1.tgz#6336e8d71965cb3d35a1bbb7868445a7c05264bf" integrity sha512-wa7YjyUGfNZngI/vtK0UHAN+lgDCxBPCylVXGp0zu59Fz5aiGtNXaq3DhIov063MorB+VfufLh3JlF2KdTK3xg== -v8-compile-cache@^2.0.3: - version "2.3.0" - resolved "https://registry.yarnpkg.com/v8-compile-cache/-/v8-compile-cache-2.3.0.tgz#2de19618c66dc247dcfb6f99338035d8245a2cee" - integrity sha512-l8lCEmLcLYZh4nbunNZvQCJc5pv7+RCwa8q/LdUx8u7lsWvPDKmpodJAJNwkAhJC//dFY48KuIEmjtd4RViDrA== - v8-to-istanbul@^9.0.1: version "9.0.1" resolved "https://registry.yarnpkg.com/v8-to-istanbul/-/v8-to-istanbul-9.0.1.tgz#b6f994b0b5d4ef255e17a0d17dc444a9f5132fa4" From 77672161671d8f8c25ace59dcf9bc4c15cd00fd0 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 29 Aug 2022 23:46:52 -0700 Subject: [PATCH 06/21] Fix issues when using newer @types/semver (#6132) - All the removed uses of `includePrerelease` that are removed were not actually used within the semver package Signed-off-by: Sebastian Malton Signed-off-by: Sebastian Malton --- src/common/utils/sort-compare.ts | 2 +- .../is-compatible-extension/is-compatible-extension.ts | 1 - src/main/kubectl/kubectl.ts | 2 +- .../+extensions/attempt-install-by-info.injectable.tsx | 2 +- src/renderer/components/+helm-charts/helm-chart.store.ts | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/common/utils/sort-compare.ts b/src/common/utils/sort-compare.ts index df4c59b961..ee32ab45c4 100644 --- a/src/common/utils/sort-compare.ts +++ b/src/common/utils/sort-compare.ts @@ -81,7 +81,7 @@ export function sortCharts(charts: RawHelmChart[]) { iter.map( charts, chart => { - const __version = coerce(chart.version, { includePrerelease: true, loose: true }); + const __version = coerce(chart.version, { loose: true }); if (!__version) { logger.warn(`[HELM-SERVICE]: Version from helm chart is not loosely coercable to semver.`, { name: chart.name, version: chart.version, repo: chart.repo }); diff --git a/src/extensions/extension-discovery/is-compatible-extension/is-compatible-extension.ts b/src/extensions/extension-discovery/is-compatible-extension/is-compatible-extension.ts index 44b0f1782d..717effa1c6 100644 --- a/src/extensions/extension-discovery/is-compatible-extension/is-compatible-extension.ts +++ b/src/extensions/extension-discovery/is-compatible-extension/is-compatible-extension.ts @@ -27,7 +27,6 @@ export const isCompatibleExtension = ({ appSemVer }: Dependencies): ((manifest: const { major: extMajor, minor: extMinor } = semver.coerce(manifestLensEngine, { loose: true, - includePrerelease: false, }) as semver.SemVer; const supportedVersionsByExtension = semver.validRange(`^${extMajor}.${extMinor}`) as string; diff --git a/src/main/kubectl/kubectl.ts b/src/main/kubectl/kubectl.ts index 6fde083de5..2e70f3c7ee 100644 --- a/src/main/kubectl/kubectl.ts +++ b/src/main/kubectl/kubectl.ts @@ -67,7 +67,7 @@ export class Kubectl { let version: SemVer; try { - version = new SemVer(clusterVersion, { includePrerelease: false }); + version = new SemVer(clusterVersion); } catch { version = new SemVer(Kubectl.bundledKubectlVersion); } diff --git a/src/renderer/components/+extensions/attempt-install-by-info.injectable.tsx b/src/renderer/components/+extensions/attempt-install-by-info.injectable.tsx index 0af3149e1b..dd320407a5 100644 --- a/src/renderer/components/+extensions/attempt-install-by-info.injectable.tsx +++ b/src/renderer/components/+extensions/attempt-install-by-info.injectable.tsx @@ -91,7 +91,7 @@ const attemptInstallByInfo = ({ } } else { const versions = Object.keys(json.versions) - .map(version => new SemVer(version, { loose: true, includePrerelease: true })) + .map(version => new SemVer(version, { loose: true })) // ignore pre-releases for auto picking the version .filter(version => version.prerelease.length === 0); diff --git a/src/renderer/components/+helm-charts/helm-chart.store.ts b/src/renderer/components/+helm-charts/helm-chart.store.ts index 1a3c4d7d7f..415fe3e333 100644 --- a/src/renderer/components/+helm-charts/helm-chart.store.ts +++ b/src/renderer/components/+helm-charts/helm-chart.store.ts @@ -55,7 +55,7 @@ export class HelmChartStore extends ItemStore { protected sortVersions = (versions: ChartVersion[]) => { return versions - .map(chartVersion => ({ ...chartVersion, __version: semver.coerce(chartVersion.version, { includePrerelease: true, loose: true }) })) + .map(chartVersion => ({ ...chartVersion, __version: semver.coerce(chartVersion.version, { loose: true }) })) .sort(sortCompareChartVersions) .map(({ __version, ...chartVersion }) => chartVersion); }; From 4b1c9fb5fdcedca4c7cb371cbd24c4410ad8b6e7 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Tue, 30 Aug 2022 04:54:18 -0700 Subject: [PATCH 07/21] Fix doughnut graphs on workload overview sometimes not showing (#5727) --- .../allowed-resources-injection-token.ts | 4 +- src/extensions/renderer-api/theming.ts | 12 +- .../order-of-sidebar-items.test.tsx.snap | 2 + ...-and-tab-navigation-for-core.test.tsx.snap | 5 + ...ab-navigation-for-extensions.test.tsx.snap | 5 + .../visibility-of-sidebar-items.test.tsx.snap | 2 + .../workload-overview.test.tsx.snap | 576 ++++++++++++++++++ ...when-cluster-is-not-relevant.test.tsx.snap | 2 + ...when-cluster-is-not-relevant.test.tsx.snap | 3 + ...e-from-previously-opened-tab.test.tsx.snap | 2 + .../cluster/workload-overview.test.tsx | 37 ++ ...when-cluster-is-not-relevant.test.tsx.snap | 3 + ...rt-from-previously-opened-tab.test.ts.snap | 2 + .../components/+cluster/cluster-issues.tsx | 11 +- .../+cluster/cluster-pie-charts.tsx | 13 +- .../release-details-model.injectable.tsx | 14 +- .../components/+nodes/node-charts.tsx | 13 +- .../volume-claim-disk-chart.tsx | 13 +- .../+workloads-overview/overview-statuses.tsx | 2 +- .../overview-workload-status.tsx | 141 +++-- .../+workloads-overview/overview.tsx | 2 +- .../workloads/workload-injection-token.ts | 3 +- .../+workloads-pods/container-charts.tsx | 13 +- src/renderer/components/chart/bar-chart.tsx | 13 +- src/renderer/components/chart/chart.tsx | 36 +- src/renderer/components/chart/pie-chart.tsx | 28 +- .../components/dock/terminal/view.tsx | 11 +- .../components/item-object-list/content.tsx | 13 +- .../monaco-editor/monaco-editor.tsx | 11 +- src/renderer/components/select/select.tsx | 12 +- .../test-utils/get-application-builder.tsx | 9 +- .../__snapshots__/cluster-frame.test.tsx.snap | 1 + src/renderer/themes/active.injectable.ts | 18 + src/renderer/themes/lens-dark.ts | 4 +- src/renderer/themes/lens-light.ts | 4 +- src/renderer/themes/store.ts | 12 +- 36 files changed, 868 insertions(+), 184 deletions(-) create mode 100644 src/features/cluster/__snapshots__/workload-overview.test.tsx.snap create mode 100644 src/features/cluster/workload-overview.test.tsx create mode 100644 src/renderer/themes/active.injectable.ts diff --git a/src/common/cluster-store/allowed-resources-injection-token.ts b/src/common/cluster-store/allowed-resources-injection-token.ts index ad387d26a2..353d0b309c 100644 --- a/src/common/cluster-store/allowed-resources-injection-token.ts +++ b/src/common/cluster-store/allowed-resources-injection-token.ts @@ -6,8 +6,6 @@ import { getInjectionToken } from "@ogre-tools/injectable"; import type { IComputedValue } from "mobx"; -export const allowedResourcesInjectionToken = getInjectionToken< - IComputedValue> ->({ +export const allowedResourcesInjectionToken = getInjectionToken>>({ id: "allowed-resources", }); diff --git a/src/extensions/renderer-api/theming.ts b/src/extensions/renderer-api/theming.ts index a39efc80b7..435cf23504 100644 --- a/src/extensions/renderer-api/theming.ts +++ b/src/extensions/renderer-api/theming.ts @@ -3,11 +3,17 @@ * Licensed under MIT License. See LICENSE in root directory for more information. */ -import themeStoreInjectable from "../../renderer/themes/store.injectable"; +import activeThemeInjectable from "../../renderer/themes/active.injectable"; +import type { LensTheme } from "../../renderer/themes/store"; import { asLegacyGlobalForExtensionApi } from "../as-legacy-globals-for-extension-api/as-legacy-global-object-for-extension-api"; -const themeStore = asLegacyGlobalForExtensionApi(themeStoreInjectable); +export const activeTheme = asLegacyGlobalForExtensionApi(activeThemeInjectable); +/** + * @deprecated This hides the reactivity of active theme, use {@link activeTheme} instead + */ export function getActiveTheme() { - return themeStore.activeTheme; + return activeTheme.get(); } + +export type { LensTheme }; diff --git a/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap b/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap index 3dccc2e925..b9d854220c 100644 --- a/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap +++ b/src/features/cluster/__snapshots__/order-of-sidebar-items.test.tsx.snap @@ -350,6 +350,7 @@ exports[`cluster - order of sidebar items when rendered renders 1`] = `
+
+
+
+