hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix app crash opening Install Chart dock tab (#6782)

Browse Source 
* Change type of RequestHelmChartValues to be AsyncResult

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fixing tests

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Linter fix

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev authored and GitHub committed 2022-12-19 17:00:13 +03:00
1 parent 8b752981a0
commit e0bccfabd4
4 files changed
+35 -23
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/features/helm-charts/installing-chart/installing-helm-chart-from-new-tab.test.ts
+20 -15
View File
@@ -240,9 +240,10 @@ describe("installing helm chart from new tab", () => {
describe("when default configuration and versions resolve", () => {
beforeEach(async () => {
await requestHelmChartValuesMock.resolve(
"some-default-configuration",
);
await requestHelmChartValuesMock.resolve({
callWasSuccessful: true,
response: "some-default-configuration",
});
await requestHelmChartVersionsMock.resolve([
HelmChart.create({
@@ -537,9 +538,10 @@ describe("installing helm chart from new tab", () => {
describe("when configuration and versions resolve", () => {
beforeEach(async () => {
await requestHelmChartValuesMock.resolve(
"some-other-default-configuration",
);
await requestHelmChartValuesMock.resolve({
callWasSuccessful: true,
response: "some-other-default-configuration",
});
await requestHelmChartVersionsMock.resolve([]);
});
@@ -702,9 +704,10 @@ describe("installing helm chart from new tab", () => {
describe("when default configuration resolves", () => {
beforeEach(async () => {
await requestHelmChartValuesMock.resolve(
"some-default-configuration-for-other-version",
);
await requestHelmChartValuesMock.resolve({
callWasSuccessful: true,
response: "some-default-configuration-for-other-version",
});
});
it("renders", () => {
@@ -847,9 +850,10 @@ describe("installing helm chart from new tab", () => {
)
.selectOption("some-other-version");
await requestHelmChartValuesMock.resolve(
"some-default-configuration-for-other-version",
);
await requestHelmChartValuesMock.resolve({
callWasSuccessful: true,
response: "some-default-configuration-for-other-version",
});
expect(installButton).not.toHaveAttribute("disabled");
});
@@ -920,9 +924,10 @@ describe("installing helm chart from new tab", () => {
)
.selectOption("some-other-version");
await requestHelmChartValuesMock.resolve(
"some-default-configuration-for-other-version",
);
await requestHelmChartValuesMock.resolve({
callWasSuccessful: true,
response: "some-default-configuration-for-other-version",
});
const input = rendered.getByTestId(
"monaco-editor-for-some-first-tab-id",
src/features/helm-charts/installing-chart/installing-helm-chart-from-previously-opened-tab.test.ts
+4 -3
View File
@@ -149,9 +149,10 @@ describe("installing helm chart from previously opened tab", () => {
describe("when configuration and version resolves", () => {
beforeEach(async () => {
await requestHelmChartValuesMock.resolve(
"some-default-configuration",
);
await requestHelmChartValuesMock.resolve({
callWasSuccessful: true,
response: "some-default-configuration",
});
await requestHelmChartVersionsMock.resolve([
HelmChart.create({