hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix app crash opening Install Chart dock tab (#6782)

Browse Source 
* Change type of RequestHelmChartValues to be AsyncResult

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fixing tests

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Linter fix

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev authored and GitHub committed 2022-12-19 17:00:13 +03:00
1 parent 8b752981a0
commit e0bccfabd4
4 files changed
+35 -23
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/renderer/components/dock/install-chart/install-chart-model.injectable.tsx
+9 -4
View File
@@ -122,14 +122,18 @@ export class InstallChartModel {
this.configuration.isLoading.set(true);
});
const configuration = await this.dependencies.requestHelmChartValues(
const chartValuesRequest = await this.dependencies.requestHelmChartValues(
this.chart.repo,
this.chart.name,
version,
);
if (!chartValuesRequest.callWasSuccessful) {
throw chartValuesRequest.error;
}
runInAction(() => {
this.configuration.onChange(configuration);
this.configuration.onChange(chartValuesRequest.response);
this.configuration.isLoading.set(false);
});
},
@@ -187,7 +191,7 @@ export class InstallChartModel {
load = async () => {
await this.dependencies.waitForChart();
const [defaultConfiguration, versions] = await Promise.all([
const [defaultConfigurationRequest, versions] = await Promise.all([
this.dependencies.requestHelmChartValues(
this.chart.repo,
this.chart.name,
@@ -203,13 +207,14 @@ export class InstallChartModel {
runInAction(() => {
// TODO: Make "default" not hard-coded
const namespace = this.chart.namespace || "default";
const values = this.chart.values || (defaultConfigurationRequest.callWasSuccessful ? defaultConfigurationRequest.response : "");
this.versions.replace(versions);
this.save({
version: this.chart.version,
namespace,
values: this.chart.values || defaultConfiguration,
values,
releaseName: this.chart.releaseName,
});
});