hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Adding more control over extension preferences page title (#5901)

Browse Source 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev authored and GitHub committed 2022-07-27 14:05:55 +03:00
1 parent 392d548bf0
commit e334a6aeda
4 files changed
+47 -33
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/behaviours/preferences/__snapshots__/navigation-to-extension-specific-preferences.test.tsx.snap
+28 -27
View File
@@ -172,10 +172,10 @@ exports[`preferences - navigation to extension specific preferences given in pre
<section
id="extensions"
>
<h2>
<h2
data-testid="extension-preferences-page-title"
>
Metrics tab
preferences
</h2>
<section
class="small"
@@ -472,10 +472,10 @@ exports[`preferences - navigation to extension specific preferences given in pre
<section
id="extensions"
>
<h2>
<h2
data-testid="extension-preferences-page-title"
>
Metrics tab
preferences
</h2>
<section
class="small"
@@ -772,10 +772,10 @@ exports[`preferences - navigation to extension specific preferences given in pre
<section
id="extensions"
>
<h2>
<h2
data-testid="extension-preferences-page-title"
>
Metrics tab
preferences
</h2>
<section
class="small"
@@ -1095,10 +1095,10 @@ exports[`preferences - navigation to extension specific preferences given in pre
<section
id="extensions"
>
<h2>
some-test-extension-id
preferences
<h2
data-testid="extension-preferences-page-title"
>
some-test-extension-id preferences
</h2>
<section
class="small"
@@ -2717,10 +2717,10 @@ exports[`preferences - navigation to extension specific preferences given in pre
<section
id="extensions"
>
<h2>
some-test-extension-id
preferences
<h2
data-testid="extension-preferences-page-title"
>
some-test-extension-id preferences
</h2>
<section
class="small"
@@ -2994,9 +2994,10 @@ exports[`preferences - navigation to extension specific preferences given in pre
<section
id="extensions"
>
<h2>
preferences
<h2
data-testid="extension-preferences-page-title"
>
Extension preferences
</h2>
<div
class="flex items-center"
@@ -3263,10 +3264,10 @@ exports[`preferences - navigation to extension specific preferences when navigat
<section
id="extensions"
>
<h2>
<h2
data-testid="extension-preferences-page-title"
>
Metrics tab
preferences
</h2>
<section
class="small"
@@ -3551,10 +3552,10 @@ exports[`preferences - navigation to extension specific preferences when navigat
<section
id="extensions"
>
<h2>
extension-using-someone-else-tab-id
preferences
<h2
data-testid="extension-preferences-page-title"
>
extension-using-someone-else-tab-id preferences
</h2>
<section
class="small"
src/behaviours/preferences/navigation-to-extension-specific-preferences.test.tsx
+12
View File
@@ -225,6 +225,18 @@ describe("preferences - navigation to extension specific preferences", () => {
expect(actual).not.toBeInTheDocument();
});
it("shows page title", () => {
const pageTitle = rendered.queryByTestId("extension-preferences-page-title");
expect(pageTitle).toBeInTheDocument();
});
it("shows page title same as tab title", () => {
const pageTitle = rendered.queryByTestId("extension-preferences-page-title");
const tabs = extensionStubWithWithRegisteredTab.appPreferenceTabs;
const tabTitle = tabs && tabs[0].title;
expect(pageTitle?.innerHTML).toBe(tabTitle);
});
});
});