From e3354f3b7593cd9a4586ff70c4e591d512f3f8bd Mon Sep 17 00:00:00 2001 From: Alex Andreev Date: Tue, 3 Nov 2020 16:22:54 +0300 Subject: [PATCH] Fixing return statements in Pod menus (#1211) Signed-off-by: Alex Andreev --- extensions/pod-menu/src/logs-menu.tsx | 2 +- extensions/pod-menu/src/shell-menu.tsx | 2 +- src/renderer/components/+workloads-pods/pod-details.tsx | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/extensions/pod-menu/src/logs-menu.tsx b/extensions/pod-menu/src/logs-menu.tsx index f80c55cc01..a1a6dba834 100644 --- a/extensions/pod-menu/src/logs-menu.tsx +++ b/extensions/pod-menu/src/logs-menu.tsx @@ -22,7 +22,7 @@ export class PodLogsMenu extends React.Component { const { object: pod, toolbar } = this.props const containers = pod.getAllContainers(); const statuses = pod.getContainerStatuses(); - if (!containers.length) return; + if (!containers.length) return null; return ( this.showLogs(containers[0]))}> diff --git a/extensions/pod-menu/src/shell-menu.tsx b/extensions/pod-menu/src/shell-menu.tsx index 772d17a894..02e248810b 100644 --- a/extensions/pod-menu/src/shell-menu.tsx +++ b/extensions/pod-menu/src/shell-menu.tsx @@ -34,7 +34,7 @@ export class PodShellMenu extends React.Component { render() { const { object, toolbar } = this.props const containers = object.getRunningContainers(); - if (!containers.length) return; + if (!containers.length) return null; return ( this.execShell(containers[0].name))}> diff --git a/src/renderer/components/+workloads-pods/pod-details.tsx b/src/renderer/components/+workloads-pods/pod-details.tsx index 6c20fd1326..a029591bbd 100644 --- a/src/renderer/components/+workloads-pods/pod-details.tsx +++ b/src/renderer/components/+workloads-pods/pod-details.tsx @@ -65,7 +65,6 @@ export class PodDetails extends React.Component { const { nodeName } = spec; const nodeSelector = pod.getNodeSelectors(); const volumes = pod.getVolumes(); - const labels = pod.getLabels(); const metrics = podsStore.metrics; return (