hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix bugs in ItemListLayouts/KubeObjectListLayouts (#4792)

Browse Source 
* Fix virtual list behaviour in item list layout by making table rows observer

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Make selecting item in ItemListLayout not scroll to top

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Fix scrolling to top when selecting all items in item list layout

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Fix refreshing release values when release is unselected

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Remove noisy debugging

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Fix sorting of table rows

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Replace avoidable asyncComputed with normal computed

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Revert unnecessary code style changes

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Fix render-storm in Events

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Fix missing key in React array

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This commit is contained in:
Janne SavolainenandMikko Aspiala authored and GitHub committed 2022-02-02 16:46:07 +02:00
1 parent 334ab56f9d
commit e58d9b631a
7 files changed
+95 -70
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/renderer/components/+events/events.tsx
+2 -2
View File
@@ -124,7 +124,7 @@ export class Events extends React.Component<Props> {
};
render() {
const { store, visibleItems } = this;
const { store } = this;
const { compact, compactLimit, className, ...layoutProps } = this.props;
const events = (
@@ -137,7 +137,7 @@ export class Events extends React.Component<Props> {
renderHeaderTitle="Events"
customizeHeader={this.customizeHeader}
isSelectable={false}
items={visibleItems}
getItems={() => this.visibleItems}
virtual={!compact}
tableProps={{
sortSyncWithUrl: false,