mirror of
https://github.com/lensapp/lens.git
synced 2025-05-20 05:10:56 +00:00
Conditionally render node taints upon value existance (#3989)
This commit is contained in:
1 parent
f51ce1e34b
commit
e64060cc69
6 files changed
+66
-18
No files matched your search
@@ -30,7 +30,7 @@ import { Badge } from "../badge";
|
||||
import { ResourceMetrics } from "../resource-metrics";
|
||||
import { podsStore } from "../+workloads-pods/pods.store";
|
||||
import type { KubeObjectDetailsProps } from "../kube-object-details";
|
||||
import { getMetricsByNodeNames, IClusterMetrics, Node } from "../../../common/k8s-api/endpoints";
|
||||
import { formatNodeTaint, getMetricsByNodeNames, IClusterMetrics, Node } from "../../../common/k8s-api/endpoints";
|
||||
import { NodeCharts } from "./node-charts";
|
||||
import { makeObservable, observable, reaction } from "mobx";
|
||||
import { PodDetailsList } from "../+workloads-pods/pod-details-list";
|
||||
@@ -132,11 +132,7 @@ export class NodeDetails extends React.Component<Props> {
|
||||
/>
|
||||
{taints.length > 0 && (
|
||||
<DrawerItem name="Taints" labelsOnly>
|
||||
{
|
||||
taints.map(({ key, effect, value }) => (
|
||||
<Badge key={key} label={`${key}=${value}:${effect}`} />
|
||||
))
|
||||
}
|
||||
{taints.map(taint => <Badge key={taint.key} label={formatNodeTaint(taint)} />)}
|
||||
</DrawerItem>
|
||||
)}
|
||||
{conditions &&
|
||||
|
||||
@@ -27,7 +27,7 @@ import { cssNames, interval } from "../../utils";
|
||||
import { TabLayout } from "../layout/tab-layout";
|
||||
import { nodesStore } from "./nodes.store";
|
||||
import { KubeObjectListLayout } from "../kube-object-list-layout";
|
||||
import { getMetricsForAllNodes, INodeMetrics, Node } from "../../../common/k8s-api/endpoints/nodes.api";
|
||||
import { formatNodeTaint, getMetricsForAllNodes, INodeMetrics, Node } from "../../../common/k8s-api/endpoints/nodes.api";
|
||||
import { LineProgress } from "../line-progress";
|
||||
import { bytesToUnits } from "../../../common/utils/convertMemory";
|
||||
import { Tooltip, TooltipPosition } from "../tooltip";
|
||||
@@ -227,6 +227,7 @@ export class Nodes extends React.Component<Props> {
|
||||
]}
|
||||
renderTableContents={node => {
|
||||
const tooltipId = `node-taints-${node.getId()}`;
|
||||
const taints = node.getTaints();
|
||||
|
||||
return [
|
||||
<Badge flat key="name" label={node.getName()} tooltip={node.getName()} />,
|
||||
@@ -235,9 +236,9 @@ export class Nodes extends React.Component<Props> {
|
||||
this.renderMemoryUsage(node),
|
||||
this.renderDiskUsage(node),
|
||||
<>
|
||||
<span id={tooltipId}>{node.getTaints().length}</span>
|
||||
<span id={tooltipId}>{taints.length}</span>
|
||||
<Tooltip targetId={tooltipId} tooltipOnParentHover={true} style={{ whiteSpace: "pre-line" }}>
|
||||
{node.getTaints().map(({ key, value, effect }) => `${key}=${value}:${effect}`).join("\n")}
|
||||
{taints.map(formatNodeTaint).join("\n")}
|
||||
</Tooltip>
|
||||
</>,
|
||||
node.getRoleLabels(),
|
||||
|
||||
Reference in new issue
Block a user