From e815461cb495acddef6f36a7c5271fddd58a118c Mon Sep 17 00:00:00 2001 From: "Hung-Han (Henry) Chen" Date: Fri, 9 Jul 2021 14:22:38 +0300 Subject: [PATCH] Move SentryInit before logger.log to avoid winston exceptions Signed-off-by: Hung-Han (Henry) Chen --- src/main/index.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/main/index.ts b/src/main/index.ts index 20e1c8d19c..91a9b7c68a 100644 --- a/src/main/index.ts +++ b/src/main/index.ts @@ -61,6 +61,10 @@ import { ExtensionsStore } from "../extensions/extensions-store"; import { FilesystemProvisionerStore } from "./extension-filesystem"; import { SentryInit } from "../common/sentry"; +// This has to be called before start using winton-based logger +// For example, before any logger.log +SentryInit(); + const workingDir = path.join(app.getPath("appData"), appName); const cleanup = disposer(); @@ -141,12 +145,6 @@ app.on("ready", async () => { UserStore.createInstance().startMainReactions(); - /** - * There is no point setting up sentry before UserStore is initialized as - * `allowErrorReporting` will always be falsy. - */ - await SentryInit(); - ClusterStore.createInstance().provideInitialFromMain(); HotbarStore.createInstance(); ExtensionsStore.createInstance();