From e9d951920ca16151339e5aacf835f792befb87d0 Mon Sep 17 00:00:00 2001
From: Iku-turso <mikko.aspiala@gmail.com>
Date: Mon, 24 Oct 2022 12:24:07 +0300
Subject: [PATCH] Simplify unit tests for composite

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
---
 .../get-composite/get-composite.test.ts       | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/src/common/utils/composite/get-composite/get-composite.test.ts b/src/common/utils/composite/get-composite/get-composite.test.ts
index 0ac0e0ec36..398282e449 100644
--- a/src/common/utils/composite/get-composite/get-composite.test.ts
+++ b/src/common/utils/composite/get-composite/get-composite.test.ts
@@ -15,19 +15,17 @@ interface SomeItem {
 }
 
 describe("get-composite", () => {
-  it("given items and a specified root id, creates a composite", () => {
-    const getComposite = getCompositeFor<SomeItem>({
-      rootId: "some-root-id",
-      getId: (x) => x.id,
-      getParentId: (x) => x.parentId,
-    });
-
+  it("given items and an explicit root id, creates a composite", () => {
     const someRootItem = {
       id: "some-root-id",
-      parentId: undefined,
       someProperty: "some-root-content",
     };
 
+    const someIrrelevantRootItem = {
+      id: "some-irrelevant-root-id",
+      someProperty: "some-other-root-content",
+    };
+
     const someItem = {
       id: "some-id",
       parentId: "some-root-id",
@@ -40,7 +38,13 @@ describe("get-composite", () => {
       someProperty: "some-nested-content",
     };
 
-    const items = [someRootItem, someItem, someNestedItem];
+    const items = [someRootItem, someIrrelevantRootItem, someItem, someNestedItem];
+
+    const getComposite = getCompositeFor<SomeItem>({
+      rootId: "some-root-id",
+      getId: (x) => x.id,
+      getParentId: (x) => x.parentId,
+    });
 
     const composite = getComposite(items);
 
@@ -67,11 +71,11 @@ describe("get-composite", () => {
     });
   });
 
-  it("given items and an unspecified root id and single item without parent as root, creates a composite", () => {
+  it("given items and implicit root, creates a composite", () => {
     const someRootItem = {
       id: "some-root-id",
       someProperty: "some-root-content",
-      // Notice: no "parentId" makes this the root.
+      // Notice: no "parentId" makes this the implicit root.
       parentId: undefined,
     };