hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fix code style

Browse Source 
Signed-off-by: Janne Savolainen <janne.savolainen@houston-inc.com>
This commit is contained in:
Janne Savolainen 2021-11-05 08:51:36 +02:00 committed by Janne Savolainen
parent a2f9a76add
commit ec075ad957
2 changed files with 64 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/renderer/components/kube-object-menu/kube-object-menu.test.tsx
View File

@ -37,7 +37,7 @@ describe("kube-object-menu", () => {
let hideDetailsStub: () => void; let hideDetailsStub: () => void;
let editResourceTabStub: () => void; let editResourceTabStub: () => void;
let apiManagerStub: IGettableStore; let apiManagerStub: IGettableStore;
let clusterStub : IHasName; let clusterStub: IHasName;
let kubeObjectMenuRegistryStub: IHasGettableItemsForKind; let kubeObjectMenuRegistryStub: IHasGettableItemsForKind;
let objectStub: KubeObject | null; let objectStub: KubeObject | null;
@ -54,12 +54,15 @@ describe("kube-object-menu", () => {
apiManagerStub = { apiManagerStub = {
// eslint-disable-next-line unused-imports/no-unused-vars-ts // eslint-disable-next-line unused-imports/no-unused-vars-ts
getStore: <TKubeObjectStore extends KubeObjectStore<KubeObject>>(api: string | KubeApi<KubeObject>): TKubeObjectStore | undefined => undefined,
getStore: <TKubeObjectStore extends KubeObjectStore<KubeObject>>(
api: string | KubeApi<KubeObject>,
): TKubeObjectStore | undefined => undefined,
}; };
clusterStub = { name: "Some cluster name" }; clusterStub = { name: "Some cluster name" };
const MenuItemComponentStub : React.FC = () => <div>Some menu item</div>; const MenuItemComponentStub: React.FC = () => <div>Some menu item</div>;
const menuItemStub: KubeObjectMenuRegistration = { const menuItemStub: KubeObjectMenuRegistration = {
apiVersions: ["irrelevant"], apiVersions: ["irrelevant"],
@ -67,10 +70,11 @@ describe("kube-object-menu", () => {
kind: "irrelevant", kind: "irrelevant",
}; };
kubeObjectMenuRegistryStub = { kubeObjectMenuRegistryStub = {
// eslint-disable-next-line unused-imports/no-unused-vars-ts // eslint-disable-next-line unused-imports/no-unused-vars-ts
getItemsForKind: (kind: string, apiVersion: string): any => [menuItemStub], getItemsForKind: (kind: string, apiVersion: string): any => [
menuItemStub,
],
}; };
hideDetailsStub = () => {}; hideDetailsStub = () => {};
@ -81,14 +85,17 @@ describe("kube-object-menu", () => {
it("given no kube object, renders", () => { it("given no kube object, renders", () => {
objectStub = null; objectStub = null;
const { baseElement } = render(<KubeObjectMenu object={objectStub} const { baseElement } = render(
apiManager={apiManagerStub} <KubeObjectMenu
cluster={clusterStub} object={objectStub}
kubeObjectMenuRegistry={kubeObjectMenuRegistryStub} apiManager={apiManagerStub}
hideDetails={hideDetailsStub} cluster={clusterStub}
editResourceTab={editResourceTabStub} kubeObjectMenuRegistry={kubeObjectMenuRegistryStub}
toolbar={true} hideDetails={hideDetailsStub}
/>); editResourceTab={editResourceTabStub}
toolbar={true}
/>,
);
expect(baseElement).toMatchSnapshot(); expect(baseElement).toMatchSnapshot();
}); });
@ -97,17 +104,24 @@ describe("kube-object-menu", () => {
objectStub = KubeObject.create({ objectStub = KubeObject.create({
apiVersion: "some-api-version", apiVersion: "some-api-version",
kind: "some-kind", kind: "some-kind",
metadata: { uid: "some-uid", name: "some-name", resourceVersion: "some-resource-version" }, metadata: {
uid: "some-uid",
name: "some-name",
resourceVersion: "some-resource-version",
},
}); });
const { baseElement } = render(<KubeObjectMenu object={objectStub} const { baseElement } = render(
apiManager={apiManagerStub} <KubeObjectMenu
cluster={clusterStub} object={objectStub}
kubeObjectMenuRegistry={kubeObjectMenuRegistryStub} apiManager={apiManagerStub}
hideDetails={hideDetailsStub} cluster={clusterStub}
editResourceTab={editResourceTabStub} kubeObjectMenuRegistry={kubeObjectMenuRegistryStub}
toolbar={true} hideDetails={hideDetailsStub}
/>); editResourceTab={editResourceTabStub}
toolbar={true}
/>,
);
expect(baseElement).toMatchSnapshot(); expect(baseElement).toMatchSnapshot();
}); });

46
src/renderer/components/kube-object-menu/kube-object-menu.tsx
View File

@ -29,7 +29,6 @@ import type { IHasGettableItemsForKind } from "../../../extensions/registries";
import type { IGettableStore } from "../../../common/k8s-api/api-manager"; import type { IGettableStore } from "../../../common/k8s-api/api-manager";
import type { IHasName } from "../../../main/cluster"; import type { IHasName } from "../../../main/cluster";
export interface KubeObjectMenuProps<TKubeObject> extends MenuActionsProps { export interface KubeObjectMenuProps<TKubeObject> extends MenuActionsProps {
object: TKubeObject | null | undefined; object: TKubeObject | null | undefined;
editable?: boolean; editable?: boolean;
@ -37,15 +36,18 @@ export interface KubeObjectMenuProps<TKubeObject> extends MenuActionsProps {
toolbar?: boolean; toolbar?: boolean;
} }
interface KubeObjectMenuDependencies<TKubeObject> extends KubeObjectMenuProps<TKubeObject>{ interface KubeObjectMenuDependencies<TKubeObject>
apiManager: IGettableStore, extends KubeObjectMenuProps<TKubeObject> {
kubeObjectMenuRegistry: IHasGettableItemsForKind apiManager: IGettableStore;
cluster: IHasName, kubeObjectMenuRegistry: IHasGettableItemsForKind;
hideDetails: () => void, cluster: IHasName;
editResourceTab: (kubeObject: TKubeObject) => void, hideDetails: () => void;
editResourceTab: (kubeObject: TKubeObject) => void;
} }
export class KubeObjectMenu<TKubeObject extends KubeObject> extends React.Component<KubeObjectMenuDependencies<TKubeObject>> { export class KubeObjectMenu<
TKubeObject extends KubeObject,
> extends React.Component<KubeObjectMenuDependencies<TKubeObject>> {
get dependencies() { get dependencies() {
const { const {
apiManager, apiManager,
@ -113,7 +115,9 @@ export class KubeObjectMenu<TKubeObject extends KubeObject> extends React.Compon
const breadcrumb = breadcrumbParts.filter(identity).join("/"); const breadcrumb = breadcrumbParts.filter(identity).join("/");
return ( return (
<p>Remove <b>{breadcrumb}</b>?</p> <p>
Remove <b>{breadcrumb}</b>?
</p>
); );
} }
@ -126,15 +130,21 @@ export class KubeObjectMenu<TKubeObject extends KubeObject> extends React.Compon
return this.dependencies.kubeObjectMenuRegistry return this.dependencies.kubeObjectMenuRegistry
.getItemsForKind(object.kind, object.apiVersion) .getItemsForKind(object.kind, object.apiVersion)
.map(({ components: { MenuItem }}: { components: { MenuItem: React.ReactType<any> }}, index: number) => ( .map(
<MenuItem (
object={object} {
toolbar={toolbar} components: { MenuItem },
}: { components: { MenuItem: React.ReactType<any> }},
// TODO: Fix misuse of index in key index: number,
key={`menu-item-${index}`} ) => (
/> <MenuItem
)); object={object}
toolbar={toolbar}
// TODO: Fix misuse of index in key
key={`menu-item-${index}`}
/>
),
);
} }
render() { render() {