diff --git a/src/common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable.ts b/src/common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable.ts index 77fae74011..3d9aebddf5 100644 --- a/src/common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable.ts +++ b/src/common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable.ts @@ -16,8 +16,7 @@ const navigateToHelmReleasesInjectable = getInjectable({ const navigateToRoute = di.inject(navigateToRouteInjectionToken); const route = di.inject(helmReleasesRouteInjectable); - return (parameters) => - navigateToRoute(route, { parameters }); + return (parameters) => navigateToRoute(route, { parameters }); }, }); diff --git a/src/common/fs/exec-file.injectable.ts b/src/common/fs/exec-file.injectable.ts index 510fa025e4..15d0ad48dc 100644 --- a/src/common/fs/exec-file.injectable.ts +++ b/src/common/fs/exec-file.injectable.ts @@ -3,20 +3,23 @@ * Licensed under MIT License. See LICENSE in root directory for more information. */ import { getInjectable } from "@ogre-tools/injectable"; +import type { ExecFileOptions } from "child_process"; import { execFile } from "child_process"; import { promisify } from "util"; -export type ExecFile = (filePath: string, args: string[]) => Promise; +export type ExecFile = (filePath: string, args: string[], options: ExecFileOptions) => Promise; const execFileInjectable = getInjectable({ id: "exec-file", - instantiate: (): ExecFile => async (filePath, args) => { + instantiate: (): ExecFile => { const asyncExecFile = promisify(execFile); - const result = await asyncExecFile(filePath, args); + return async (filePath, args, options) => { + const result = await asyncExecFile(filePath, args, options); - return result.stdout; + return result.stdout; + }; }, causesSideEffects: true, diff --git a/src/features/helm-charts/add-custom-helm-repository-in-preferences.test.ts b/src/features/helm-charts/add-custom-helm-repository-in-preferences.test.ts index d8e14d25fa..f77a550575 100644 --- a/src/features/helm-charts/add-custom-helm-repository-in-preferences.test.ts +++ b/src/features/helm-charts/add-custom-helm-repository-in-preferences.test.ts @@ -167,6 +167,7 @@ describe("add custom helm repository in preferences", () => { expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "add", "some-custom-repository", "http://some.url"], + { "maxBuffer": 34359738368 }, ); }); @@ -365,6 +366,7 @@ describe("add custom helm repository in preferences", () => { "--cert-file", "some-cert-file", ], + { "maxBuffer": 34359738368 }, ); }); }); diff --git a/src/features/helm-charts/add-helm-repository-from-list-in-preferences.test.ts b/src/features/helm-charts/add-helm-repository-from-list-in-preferences.test.ts index c46c30086e..98e94321bd 100644 --- a/src/features/helm-charts/add-helm-repository-from-list-in-preferences.test.ts +++ b/src/features/helm-charts/add-helm-repository-from-list-in-preferences.test.ts @@ -119,6 +119,7 @@ describe("add helm repository from list in preferences", () => { expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "add", "Some to be added repository", "some-other-url"], + { "maxBuffer": 34359738368 }, ); }); @@ -227,6 +228,7 @@ describe("add helm repository from list in preferences", () => { expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "remove", "Some already active repository"], + { "maxBuffer": 34359738368 }, ); }); diff --git a/src/features/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap b/src/features/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap index dee4f06b14..15c98bdca1 100644 --- a/src/features/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap +++ b/src/features/helm-charts/installing-chart/__snapshots__/installing-helm-chart-from-new-tab.test.ts.snap @@ -11496,7 +11496,21 @@ exports[`installing helm chart from new tab given tab for installing chart was n
- + some-release + + + content_copy + + +
+ Copy +
{ let builder: ApplicationBuilder; @@ -50,6 +52,9 @@ describe("installing helm chart from new tab", () => { callForCreateHelmReleaseMock = asyncFn(); builder.beforeWindowStart((windowDi) => { + windowDi.override(callForHelmReleasesInjectable, () => async () => []); + windowDi.override(callForHelmReleaseDetailsInjectable, () => () => new Promise(() => {})); + windowDi.override( directoryForLensLocalStorageInjectable, () => "/some-directory-for-lens-local-storage", diff --git a/src/features/helm-charts/listing-active-helm-repositories-in-preferences.test.ts b/src/features/helm-charts/listing-active-helm-repositories-in-preferences.test.ts index 395b4c2c8a..c8407767ef 100644 --- a/src/features/helm-charts/listing-active-helm-repositories-in-preferences.test.ts +++ b/src/features/helm-charts/listing-active-helm-repositories-in-preferences.test.ts @@ -69,6 +69,7 @@ describe("listing active helm repositories in preferences", () => { expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["env"], + { "maxBuffer": 34359738368 }, ); }); @@ -76,6 +77,7 @@ describe("listing active helm repositories in preferences", () => { expect(execFileMock).not.toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "update"], + { "maxBuffer": 34359738368 }, ); }); @@ -207,6 +209,7 @@ describe("listing active helm repositories in preferences", () => { expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "update"], + { "maxBuffer": 34359738368 }, ); }); @@ -265,6 +268,7 @@ describe("listing active helm repositories in preferences", () => { expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "add", "bitnami", "https://charts.bitnami.com/bitnami"], + { "maxBuffer": 34359738368 }, ); }); @@ -400,6 +404,7 @@ describe("listing active helm repositories in preferences", () => { expect(execFileMock).not.toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "add", "bitnami", "https://charts.bitnami.com/bitnami"], + { "maxBuffer": 34359738368 }, ); }); diff --git a/src/features/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts b/src/features/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts index 1eb6b7b832..7a3e787a53 100644 --- a/src/features/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts +++ b/src/features/helm-charts/remove-helm-repository-from-list-of-active-repository-in-preferences.test.ts @@ -86,6 +86,7 @@ describe("remove helm repository from list of active repositories in preferences expect(execFileMock).toHaveBeenCalledWith( "some-helm-binary-path", ["repo", "remove", "some-active-repository"], + { "maxBuffer": 34359738368 }, ); }); diff --git a/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap b/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap index 11d171ceb1..ced68044ac 100644 --- a/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap +++ b/src/features/helm-releases/__snapshots__/showing-details-for-helm-release.test.ts.snap @@ -3314,7 +3314,21 @@ exports[`showing details for helm release given application is started when navi
- + some-name + + + content_copy + + +
+ Copy +
`; +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + close + + +
+ Close +
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + + close + + +
+ Close +
+
+
+
+
+ + Chart + + +
+ + some-chart + + +
+ +
+
+ + Updated + + + NaNy ago (some-updated) + +
+
+ + Namespace + + + some-namespace + +
+
+ + Version + + +
+ +
+ +
+
+ + Status + + +
+ Some-status +
+ +
+
+
+ Values +
+
+ + + +
+
+
+ Notes +
+
+ some-notes +
+
+ Resources +
+
+
+ some-kind + +
+
+
+
+ Name +
+
+ Namespace +
+
+ Age +
+
+
+
+ some-resource +
+
+ some-namespace +
+
+ 0s +
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves when changing the configuration renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + + close + + +
+ Close +
+
+
+
+
+ + Chart + + +
+ + some-chart + + +
+ +
+
+ + Updated + + + NaNy ago (some-updated) + +
+
+ + Namespace + + + some-namespace + +
+
+ + Version + + +
+ +
+ +
+
+ + Status + + +
+ Some-status +
+ +
+
+
+ Values +
+
+ + + +
+
+
+ Notes +
+
+ some-notes +
+
+ Resources +
+
+
+ some-kind + +
+
+
+
+ Name +
+
+ Namespace +
+
+ Age +
+
+
+
+ some-resource +
+
+ some-namespace +
+
+ 0s +
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves when changing the configuration when saving renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + + close + + +
+ Close +
+
+
+
+
+ + Chart + + +
+ + some-chart + + +
+ +
+
+ + Updated + + + NaNy ago (some-updated) + +
+
+ + Namespace + + + some-namespace + +
+
+ + Version + + +
+ +
+ +
+
+ + Status + + +
+ Some-status +
+ +
+
+
+ Values +
+
+ + + +
+
+
+ Notes +
+
+ some-notes +
+
+ Resources +
+
+
+ some-kind + +
+
+
+
+ Name +
+
+ Namespace +
+
+ Age +
+
+
+
+ some-resource +
+
+ some-namespace +
+
+ 0s +
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves when changing the configuration when saving when update resolves with failure renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 0 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + + close + + +
+ Close +
+
+
+
+
+ + Chart + + +
+ + some-chart + + +
+ +
+
+ + Updated + + + NaNy ago (some-updated) + +
+
+ + Namespace + + + some-namespace + +
+
+ + Version + + +
+ +
+ +
+
+ + Status + + +
+ Some-status +
+ +
+
+
+ Values +
+
+ + + +
+
+
+ Notes +
+
+ some-notes +
+
+ Resources +
+
+
+ some-kind + +
+
+
+
+ Name +
+
+ Namespace +
+
+ Age +
+
+
+
+ some-resource +
+
+ some-namespace +
+
+ 0s +
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves when changing the configuration when saving when update resolves with success renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 0 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + + close + + +
+ Close +
+
+
+
+
+ + Chart + + +
+ + some-chart + + +
+ +
+
+ + Updated + + + NaNy ago (some-updated) + +
+
+ + Namespace + + + some-namespace + +
+
+ + Version + + +
+ +
+ +
+
+ + Status + + +
+ Some-status +
+ +
+
+
+ Values +
+
+ + + +
+
+
+ Notes +
+
+ some-notes +
+
+ Resources +
+
+
+ some-kind + +
+
+
+
+ Name +
+
+ Namespace +
+
+ Age +
+
+
+
+ some-resource +
+
+ some-namespace +
+
+ 0s +
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves when changing the configuration when toggling to see only user defined values when configuration resolves renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + + close + + +
+ Close +
+
+
+
+
+ + Chart + + +
+ + some-chart + + +
+ +
+
+ + Updated + + + NaNy ago (some-updated) + +
+
+ + Namespace + + + some-namespace + +
+
+ + Version + + +
+ +
+ +
+
+ + Status + + +
+ Some-status +
+ +
+
+
+ Values +
+
+ + + +
+
+
+ Notes +
+
+ some-notes +
+
+ Resources +
+
+
+ some-kind + +
+
+
+
+ Name +
+
+ Namespace +
+
+ Age +
+
+
+
+ some-resource +
+
+ some-namespace +
+
+ 0s +
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolve with release when configuration resolves when selecting to upgrade chart renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ + +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_down + + +
+ Minimize +
+
+
+
+
+
+
+
+
+
+ +`; + +exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when call for release resolves with error renders 1`] = ` + +
+
+
+
+
+
+
+ ?? +
+
+
+
+
+ + + + + + Workloads + + + + keyboard_arrow_down + + + +
+
+ + + + list + + + + Config + + +
+
+ + + + device_hub + + + + Network + + + + keyboard_arrow_down + + + +
+
+ + + + storage + + + + Storage + + +
+
+ + + + + + Helm + + + + keyboard_arrow_down + + + +
+
+ + + + security + + + + Access Control + + +
+
+ + + + extension + + + + Custom Resources + + + + keyboard_arrow_down + + + +
+
+
+
+
+
+
+
+ + +
+
+
+
+
+ Releases +
+
+ 2 items +
+
+
+ + +
+
+
+ Namespaces: some-namespace, some-other-namespace +
+
+ +
+
+
+ + +
+
+
+
+
+ +
+
+
+
+
+
+
+ +
+
+
+ Name +
+ + + arrow_drop_down + + +
+
+
+ Namespace +
+ + + arrow_drop_down + + +
+
+
+ Chart +
+ + + arrow_drop_down + + +
+
+
+ Revision +
+ + + arrow_drop_down + + +
+
+
+ Version +
+
+
+
+ App Version +
+
+
+
+ Status +
+ + + arrow_drop_down + + +
+
+
+ Updated +
+ + + arrow_drop_down + + +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+ +
+
+ some-name +
+
+ some-namespace +
+
+ some-chart +
+
+ NaN +
+
+ +
+
+ some-app-version +
+
+ Some-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+ +
+
+ some-other-name +
+
+ some-other-namespace +
+
+ some-other-chart +
+
+ NaN +
+
+ +
+
+ some-other-app-version +
+
+ Some-other-status +
+
+ NaNy +
+
+
+ + + more_vert + + +
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ +
+
+
+
+ + + add + + +
+ New tab +
+
+ + + fullscreen + + +
+ Fit to window +
+ + + keyboard_arrow_up + + +
+ Open +
+
+
+
+
+
+
+
+
+
+
+ some-name + + + content_copy + + +
+ Copy +
+
+ + + close + + +
+ Close +
+
+
+
+ Failed to load release: + + some-error +
+
+
+
+
+ +`; + exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details is closed renders 1`] = `
@@ -5183,7 +15113,21 @@ exports[`showing details for helm release given application is started when navi
- + some-name + + + content_copy + + +
+ Copy +
`; -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- -
- - - close - - -
- Close -
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- some-name - - - content_copy - - -
- Copy -
-
- - - - close - - -
- Close -
-
-
-
-
- - Chart - - -
- - some-chart - - -
- -
-
- - Updated - - - NaNy - ago (some-updated) - -
-
- - Namespace - - - some-namespace - -
-
- - Version - - -
- -
- -
-
- - Status - - -
- Some-status -
- -
-
-
- Values -
-
- - - -
-
-
- Notes -
-
- some-notes -
-
- Resources -
-
-
- some-kind - -
-
-
-
- Name -
-
- Namespace -
-
- Age -
-
-
-
- some-resource -
-
- some-namespace -
-
- 0s -
-
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves when changing the configuration renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- some-name - - - content_copy - - -
- Copy -
-
- - - - close - - -
- Close -
-
-
-
-
- - Chart - - -
- - some-chart - - -
- -
-
- - Updated - - - NaNy - ago (some-updated) - -
-
- - Namespace - - - some-namespace - -
-
- - Version - - -
- -
- -
-
- - Status - - -
- Some-status -
- -
-
-
- Values -
-
- - - -
-
-
- Notes -
-
- some-notes -
-
- Resources -
-
-
- some-kind - -
-
-
-
- Name -
-
- Namespace -
-
- Age -
-
-
-
- some-resource -
-
- some-namespace -
-
- 0s -
-
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves when changing the configuration when saving renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- some-name - - - content_copy - - -
- Copy -
-
- - - - close - - -
- Close -
-
-
-
-
- - Chart - - -
- - some-chart - - -
- -
-
- - Updated - - - NaNy - ago (some-updated) - -
-
- - Namespace - - - some-namespace - -
-
- - Version - - -
- -
- -
-
- - Status - - -
- Some-status -
- -
-
-
- Values -
-
- - - -
-
-
- Notes -
-
- some-notes -
-
- Resources -
-
-
- some-kind - -
-
-
-
- Name -
-
- Namespace -
-
- Age -
-
-
-
- some-resource -
-
- some-namespace -
-
- 0s -
-
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves when changing the configuration when saving when update resolves with failure renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 0 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- some-name - - - content_copy - - -
- Copy -
-
- - - - close - - -
- Close -
-
-
-
-
- - Chart - - -
- - some-chart - - -
- -
-
- - Updated - - - NaNy - ago (some-updated) - -
-
- - Namespace - - - some-namespace - -
-
- - Version - - -
- -
- -
-
- - Status - - -
- Some-status -
- -
-
-
- Values -
-
- - - -
-
-
- Notes -
-
- some-notes -
-
- Resources -
-
-
- some-kind - -
-
-
-
- Name -
-
- Namespace -
-
- Age -
-
-
-
- some-resource -
-
- some-namespace -
-
- 0s -
-
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves when changing the configuration when saving when update resolves with success renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 0 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- some-name - - - content_copy - - -
- Copy -
-
- - - - close - - -
- Close -
-
-
-
-
- - Chart - - -
- - some-chart - - -
- -
-
- - Updated - - - NaNy - ago (some-updated) - -
-
- - Namespace - - - some-namespace - -
-
- - Version - - -
- -
- -
-
- - Status - - -
- Some-status -
- -
-
-
- Values -
-
- - - -
-
-
- Notes -
-
- some-notes -
-
- Resources -
-
-
- some-kind - -
-
-
-
- Name -
-
- Namespace -
-
- Age -
-
-
-
- some-resource -
-
- some-namespace -
-
- 0s -
-
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves when changing the configuration when toggling to see only user defined values when configuration resolves renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- some-name - - - content_copy - - -
- Copy -
-
- - - - close - - -
- Close -
-
-
-
-
- - Chart - - -
- - some-chart - - -
- -
-
- - Updated - - - NaNy - ago (some-updated) - -
-
- - Namespace - - - some-namespace - -
-
- - Version - - -
- -
- -
-
- - Status - - -
- Some-status -
- -
-
-
- Values -
-
- - - -
-
-
- Notes -
-
- some-notes -
-
- Resources -
-
-
- some-kind - -
-
-
-
- Name -
-
- Namespace -
-
- Age -
-
-
-
- some-resource -
-
- some-namespace -
-
- 0s -
-
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when details resolve when configuration resolves when selecting to upgrade chart renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- - -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_down - - -
- Minimize -
-
-
-
-
-
-
-
-
-
- -`; - exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when opening details for second release renders 1`] = `
@@ -15074,965 +16085,21 @@ exports[`showing details for helm release given application is started when navi
- -
- - - close - - -
- Close -
-
-
-
-
-
-
-
- -`; - -exports[`showing details for helm release given application is started when navigating to helm releases when releases resolve when selecting release to see details when release resolve with no data, renders 1`] = ` - -
-
-
-
-
-
-
- ?? -
-
-
-
-
- - - - - - Workloads - - - - keyboard_arrow_down - - - -
-
- - - - list - - - - Config - - -
-
- - - - device_hub - - - - Network - - - - keyboard_arrow_down - - - -
-
- - - - storage - - - - Storage - - -
-
- - - - - - Helm - - - - keyboard_arrow_down - - - -
-
- - - - security - - - - Access Control - - -
-
- - - - extension - - - - Custom Resources - - - - keyboard_arrow_down - - - -
-
-
-
-
-
-
-
- - -
-
-
-
-
- Releases -
-
- 2 items -
-
-
- - -
-
-
- Namespaces: some-namespace, some-other-namespace -
-
- -
-
-
- - -
-
-
-
-
- -
-
-
-
-
-
-
- -
-
-
- Name -
- - - arrow_drop_down - - -
-
-
- Namespace -
- - - arrow_drop_down - - -
-
-
- Chart -
- - - arrow_drop_down - - -
-
-
- Revision -
- - - arrow_drop_down - - -
-
-
- Version -
-
-
-
- App Version -
-
-
-
- Status -
- - - arrow_drop_down - - -
-
-
- Updated -
- - - arrow_drop_down - - -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
- -
-
- some-name -
-
- some-namespace -
-
- some-chart -
-
- NaN -
-
- -
-
- some-app-version -
-
- Some-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
- -
-
- some-other-name -
-
- some-other-namespace -
-
- some-other-chart -
-
- NaN -
-
- -
-
- some-other-app-version -
-
- Some-other-status -
-
- NaNy -
-
-
- - - more_vert - - -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- -
-
-
-
- - - add - - -
- New tab -
-
- - - fullscreen - - -
- Fit to window -
- - - keyboard_arrow_up - - -
- Open -
-
-
-
-
-
-
-
-
-
-
- + some-other-name + + + content_copy + + +
+ Copy +
{ }); }); - it("when release resolve with no data, renders", async () => { - await callForHelmReleaseMock.resolve(undefined); - expect(rendered.baseElement).toMatchSnapshot(); + describe("when call for release resolves with error", () => { + beforeEach(async () => { + await callForHelmReleaseMock.resolve({ + callWasSuccessful: false, + error: "some-error", + }); + }); + + it("renders", async () => { + expect(rendered.baseElement).toMatchSnapshot(); + }); + + it("does not show spinner anymore", () => { + expect( + rendered.queryByTestId("helm-release-detail-content-spinner"), + ).not.toBeInTheDocument(); + }); + + it("shows error message about missing release", () => { + expect( + rendered.getByTestId("helm-release-detail-error"), + ).toBeInTheDocument(); + }); + + it("does not call for release configuration", () => { + expect(callForHelmReleaseConfigurationMock).not.toHaveBeenCalled(); + }); }); - describe("when details resolve", () => { + describe("when call for release resolve with release", () => { beforeEach(async () => { - await callForHelmReleaseMock.resolve(detailedReleaseFake); + await callForHelmReleaseMock.resolve({ + callWasSuccessful: true, + response: detailedReleaseFake, + }); }); it("renders", () => { diff --git a/src/main/getDiForUnitTesting.ts b/src/main/getDiForUnitTesting.ts index b7a5bf2431..f63e6f0518 100644 --- a/src/main/getDiForUnitTesting.ts +++ b/src/main/getDiForUnitTesting.ts @@ -83,12 +83,10 @@ import getHelmChartValuesInjectable from "./helm/helm-service/get-helm-chart-val import listHelmChartsInjectable from "./helm/helm-service/list-helm-charts.injectable"; import deleteHelmReleaseInjectable from "./helm/helm-service/delete-helm-release.injectable"; import getHelmReleaseHistoryInjectable from "./helm/helm-service/get-helm-release-history.injectable"; -import getHelmReleaseInjectable from "./helm/helm-service/get-helm-release.injectable"; import getHelmReleaseValuesInjectable from "./helm/helm-service/get-helm-release-values.injectable"; import installHelmChartInjectable from "./helm/helm-service/install-helm-chart.injectable"; import listHelmReleasesInjectable from "./helm/helm-service/list-helm-releases.injectable"; import rollbackHelmReleaseInjectable from "./helm/helm-service/rollback-helm-release.injectable"; -import updateHelmReleaseInjectable from "./helm/helm-service/update-helm-release.injectable"; import waitUntilBundledExtensionsAreLoadedInjectable from "./start-main-application/lens-window/application-window/wait-until-bundled-extensions-are-loaded.injectable"; import { registerMobX } from "@ogre-tools/injectable-extension-for-mobx"; import electronInjectable from "./utils/resolve-system-proxy/electron.injectable"; @@ -168,12 +166,10 @@ export function getDiForUnitTesting(opts: { doGeneralOverrides?: boolean } = {}) listHelmChartsInjectable, deleteHelmReleaseInjectable, getHelmReleaseHistoryInjectable, - getHelmReleaseInjectable, getHelmReleaseValuesInjectable, installHelmChartInjectable, listHelmReleasesInjectable, rollbackHelmReleaseInjectable, - updateHelmReleaseInjectable, writeJsonFileInjectable, readJsonFileInjectable, readFileInjectable, diff --git a/src/main/helm/exec-helm/exec-helm.injectable.ts b/src/main/helm/exec-helm/exec-helm.injectable.ts index a97953706d..dbe65eda34 100644 --- a/src/main/helm/exec-helm/exec-helm.injectable.ts +++ b/src/main/helm/exec-helm/exec-helm.injectable.ts @@ -8,16 +8,20 @@ import helmBinaryPathInjectable from "../helm-binary-path.injectable"; import type { AsyncResult } from "../../../common/utils/async-result"; import { getErrorMessage } from "../../../common/utils/get-error-message"; +export type ExecHelm = (args: string[]) => Promise>; + const execHelmInjectable = getInjectable({ id: "exec-helm", - instantiate: (di) => { + instantiate: (di): ExecHelm => { const execFile = di.inject(execFileInjectable); const helmBinaryPath = di.inject(helmBinaryPathInjectable); - return async (...args: string[]): Promise> => { + return async (args) => { try { - const response = await execFile(helmBinaryPath, args); + const response = await execFile(helmBinaryPath, args, { + maxBuffer: 32 * 1024 * 1024 * 1024, // 32 MiB + }); return { callWasSuccessful: true, response }; } catch (error) { diff --git a/src/main/helm/get-helm-env/get-helm-env.injectable.ts b/src/main/helm/get-helm-env/get-helm-env.injectable.ts index f4bf4cf739..d6c362a17b 100644 --- a/src/main/helm/get-helm-env/get-helm-env.injectable.ts +++ b/src/main/helm/get-helm-env/get-helm-env.injectable.ts @@ -18,7 +18,7 @@ const getHelmEnvInjectable = getInjectable({ const execHelm = di.inject(execHelmInjectable); return async (): Promise> => { - const result = await execHelm("env"); + const result = await execHelm(["env"]); if (!result.callWasSuccessful) { return { callWasSuccessful: false, error: result.error }; diff --git a/src/main/helm/helm-release-manager.ts b/src/main/helm/helm-release-manager.ts index f0907dc3c2..29bbbdd830 100644 --- a/src/main/helm/helm-release-manager.ts +++ b/src/main/helm/helm-release-manager.ts @@ -7,10 +7,8 @@ import tempy from "tempy"; import fse from "fs-extra"; import * as yaml from "js-yaml"; import { toCamelCase } from "../../common/utils/camelCase"; -import { execFile } from "child_process"; import { execHelm } from "./exec"; -import assert from "assert"; -import type { JsonObject, JsonValue } from "type-fest"; +import type { JsonValue } from "type-fest"; import { isObject, json } from "../../common/utils"; export async function listReleases(pathToKubeconfig: string, namespace?: string): Promise[]> { @@ -77,55 +75,6 @@ export async function installChart(chart: string, values: JsonValue, name: strin } } -export async function upgradeRelease(name: string, chart: string, values: any, namespace: string, version: string, kubeconfigPath: string, kubectlPath: string) { - const valuesFilePath = tempy.file({ name: "values.yaml" }); - - await fse.writeFile(valuesFilePath, yaml.dump(values)); - - const args = [ - "upgrade", - name, - chart, - "--version", version, - "--values", valuesFilePath, - "--namespace", namespace, - "--kubeconfig", kubeconfigPath, - ]; - - try { - const output = await execHelm(args); - - return { - log: output, - release: await getRelease(name, namespace, kubeconfigPath, kubectlPath), - }; - } finally { - await fse.unlink(valuesFilePath); - } -} - -export async function getRelease(name: string, namespace: string, kubeconfigPath: string, kubectlPath: string) { - const args = [ - "status", - name, - "--namespace", namespace, - "--kubeconfig", kubeconfigPath, - "--output", "json", - ]; - - const release = json.parse(await execHelm(args, { - maxBuffer: 32 * 1024 * 1024 * 1024, // 32 MiB - })); - - if (!isObject(release) || Array.isArray(release)) { - return undefined; - } - - release.resources = await getResources(name, namespace, kubeconfigPath, kubectlPath); - - return release; -} - export async function deleteRelease(name: string, namespace: string, kubeconfigPath: string) { return execHelm([ "delete", @@ -180,62 +129,3 @@ export async function rollback(name: string, namespace: string, revision: number "--kubeconfig", kubeconfigPath, ]); } - -async function getResources(name: string, namespace: string, kubeconfigPath: string, kubectlPath: string) { - const helmArgs = [ - "get", - "manifest", - name, - "--namespace", namespace, - "--kubeconfig", kubeconfigPath, - ]; - const kubectlArgs = [ - "get", - "--kubeconfig", kubeconfigPath, - "-f", "-", - "--output", "json", - // Temporary workaround for https://github.com/lensapp/lens/issues/6031 - // and other potential issues where resources can't be found. Showing - // no resources is better than the app hard-locking, and at least - // the helm metadata is shown. - "--ignore-not-found", - ]; - - try { - const helmOutput = await execHelm(helmArgs); - - return new Promise((resolve, reject) => { - let stdout = ""; - let stderr = ""; - const kubectl = execFile(kubectlPath, kubectlArgs); - - kubectl - .on("exit", (code, signal) => { - if (typeof code === "number") { - if (code === 0) { - if (stdout === "") { - resolve([]); - } else { - const output = json.parse(stdout) as { items: JsonObject[] }; - - resolve(output.items); - } - } else { - reject(stderr); - } - } else { - reject(new Error(`Kubectl exited with signal ${signal}`)); - } - }) - .on("error", reject); - - assert(kubectl.stderr && kubectl.stdout && kubectl.stdin, "For some reason the IO streams are undefined"); - - kubectl.stderr.on("data", output => stderr += output); - kubectl.stdout.on("data", output => stdout += output); - kubectl.stdin.end(helmOutput); - }); - } catch { - return []; - } -} diff --git a/src/main/helm/helm-service/get-helm-release-resources/call-for-helm-manifest/call-for-helm-manifest.injectable.ts b/src/main/helm/helm-service/get-helm-release-resources/call-for-helm-manifest/call-for-helm-manifest.injectable.ts new file mode 100644 index 0000000000..490c67273e --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/call-for-helm-manifest/call-for-helm-manifest.injectable.ts @@ -0,0 +1,47 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import type { AsyncResult } from "../../../../../common/utils/async-result"; +import execHelmInjectable from "../../../exec-helm/exec-helm.injectable"; +import yaml from "js-yaml"; +import type { KubeJsonApiData } from "../../../../../common/k8s-api/kube-json-api"; + +const callForHelmManifestInjectable = getInjectable({ + id: "call-for-helm-manifest", + + instantiate: (di) => { + const execHelm = di.inject(execHelmInjectable); + + return async ( + name: string, + namespace: string, + kubeconfigPath: string, + ): Promise> => { + const result = await execHelm([ + "get", + "manifest", + name, + "--namespace", + namespace, + "--kubeconfig", + kubeconfigPath, + ]); + + if (!result.callWasSuccessful) { + return { callWasSuccessful: false, error: result.error }; + } + + return { + callWasSuccessful: true, + response: yaml + .loadAll(result.response) + .filter((manifest) => !!manifest) as KubeJsonApiData[], + }; + }; + + }, +}); + +export default callForHelmManifestInjectable; diff --git a/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/call-for-kube-resources-by-manifest.injectable.ts b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/call-for-kube-resources-by-manifest.injectable.ts new file mode 100644 index 0000000000..71a38abf6b --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/call-for-kube-resources-by-manifest.injectable.ts @@ -0,0 +1,73 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import type { JsonObject } from "type-fest"; +import { json } from "../../../../../common/utils"; +import yaml from "js-yaml"; +import execFileWithInputInjectable from "./exec-file-with-input/exec-file-with-input.injectable"; +import { getErrorMessage } from "../../../../../common/utils/get-error-message"; +import { map } from "lodash/fp"; +import { pipeline } from "@ogre-tools/fp"; +import type { KubeJsonApiData } from "../../../../../common/k8s-api/kube-json-api"; + +export type CallForKubeResourcesByManifest = ( + namespace: string, + kubeconfigPath: string, + kubectlPath: string, + resourceManifests: KubeJsonApiData[] +) => Promise; + +const callForKubeResourcesByManifestInjectable = getInjectable({ + id: "call-for-kube-resources-by-manifest", + + instantiate: (di): CallForKubeResourcesByManifest => { + const execFileWithInput = di.inject(execFileWithInputInjectable); + + return async ( + namespace, + kubeconfigPath, + kubectlPath, + resourceManifests, + ) => { + const input = pipeline( + resourceManifests, + map((manifest) => yaml.dump(manifest)), + wideJoin("---\n"), + ); + + const result = await execFileWithInput({ + filePath: kubectlPath, + input, + + commandArguments: [ + "get", + "--kubeconfig", + kubeconfigPath, + "-f", + "-", + "--namespace", + namespace, + "--output", + "json", + ], + }); + + if (!result.callWasSuccessful) { + const errorMessage = getErrorMessage(result.error); + + throw new Error(errorMessage); + } + + const output = json.parse(result.response) as { items: JsonObject[] }; + + return output.items; + }; + }, +}); + +export default callForKubeResourcesByManifestInjectable; + +const wideJoin = (joiner: string) => (items: string[]) => + `${joiner}${items.join(joiner)}${joiner}`; diff --git a/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.global-override-for-injectable.ts b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.global-override-for-injectable.ts new file mode 100644 index 0000000000..70b4771468 --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.global-override-for-injectable.ts @@ -0,0 +1,12 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getGlobalOverride } from "../../../../../../common/test-utils/get-global-override"; +import execFileWithInputInjectable from "./exec-file-with-input.injectable"; + +export default getGlobalOverride(execFileWithInputInjectable, () => () => { + throw new Error( + "Tried to call exec file with input without explicit override", + ); +}); diff --git a/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.injectable.ts b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.injectable.ts new file mode 100644 index 0000000000..49a1c644f2 --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.injectable.ts @@ -0,0 +1,92 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import type { AsyncResult } from "../../../../../../common/utils/async-result"; +import nonPromiseExecFileInjectable from "./non-promise-exec-file.injectable"; +import { isNumber } from "../../../../../../common/utils"; +import assert from "assert"; +import type { ChildProcess } from "child_process"; + +export type ExecFileWithInput = (options: { + filePath: string; + commandArguments: string[]; + input: string; +}) => Promise>; + +const execFileWithInputInjectable = getInjectable({ + id: "exec-file-with-input", + + instantiate: (di): ExecFileWithInput => { + const execFile = di.inject(nonPromiseExecFileInjectable); + + return async ({ filePath, commandArguments, input }) => + new Promise((resolve) => { + let execution: ChildProcess; + + try { + execution = execFile(filePath, commandArguments, { + maxBuffer: 8 * 1024 * 1024 * 1024, // 8 MiB + }); + } catch (e) { + resolve({ callWasSuccessful: false, error: e }); + + return; + } + + assert(execution.stdout, "stdout is not defined"); + assert(execution.stderr, "stderr is not defined"); + assert(execution.stdin, "stdin is not defined"); + + let stdout = ""; + let stderr = ""; + + execution.stdout.on("data", (data) => { + stdout += data; + }); + + execution.stderr.on("data", (data) => { + stderr += data; + }); + + execution.on("error", (error) => + resolve({ callWasSuccessful: false, error }), + ); + + execution.on("exit", (code, signal) => { + if (!isNumber(code)) { + /** + * According to https://nodejs.org/api/child_process.html#class-childprocess (section about the "exit" event) + * it says the following: + * + * If the process exited, code is the final exit code of the process, otherwise null. + * If the process terminated due to receipt of a signal, signal is the string name of the signal, otherwise null. + * One of the two will always be non-null. + */ + resolve({ + callWasSuccessful: false, + error: `Exited via ${signal}`, + }); + + return; + } + + if (code !== 0) { + resolve({ + callWasSuccessful: false, + error: stderr ? stderr : `Failed with error: ${signal}`, + }); + + return; + } + + resolve({ callWasSuccessful: true, response: stdout }); + }); + + execution.stdin.end(input); + }); + }, +}); + +export default execFileWithInputInjectable; diff --git a/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.test.ts b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.test.ts new file mode 100644 index 0000000000..3468a9cb31 --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.test.ts @@ -0,0 +1,215 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getDiForUnitTesting } from "../../../../../getDiForUnitTesting"; +import type { ExecFileWithInput } from "./exec-file-with-input.injectable"; +import execFileWithInputInjectable from "./exec-file-with-input.injectable"; +import type { AsyncResult } from "../../../../../../common/utils/async-result"; +import nonPromiseExecFileInjectable from "./non-promise-exec-file.injectable"; +import { getPromiseStatus } from "../../../../../../common/test-utils/get-promise-status"; +import EventEmitter from "events"; + +describe("exec-file-with-input", () => { + let execFileWithInput: ExecFileWithInput; + let execFileMock: jest.Mock; + + let executionStub: EventEmitter & { + stdin: { end: (chunk: any) => void }; + stdout: EventEmitter; + stderr: EventEmitter; + }; + + beforeEach(() => { + const di = getDiForUnitTesting({ doGeneralOverrides: true }); + + di.unoverride(execFileWithInputInjectable); + + executionStub = Object.assign(new EventEmitter(), { + stdin: { end: jest.fn() }, + stdout: new EventEmitter(), + stderr: new EventEmitter(), + }); + + execFileMock = jest.fn(() => executionStub); + + di.override(nonPromiseExecFileInjectable, () => execFileMock as any); + + execFileWithInput = di.inject(execFileWithInputInjectable); + }); + + it("given call, when throws synchronously, resolves with failure", async () => { + execFileMock.mockImplementation(() => { + throw new Error("some-error"); + }); + + const actual = await execFileWithInput({ + filePath: "./irrelevant", + commandArguments: ["irrelevant"], + input: "irrelevant", + }); + + expect(actual).toEqual({ + callWasSuccessful: false, + error: expect.any(Error), + }); + }); + + describe("when called", () => { + let actualPromise: Promise>; + + beforeEach(() => { + actualPromise = execFileWithInput({ + filePath: "./some-file-path", + commandArguments: ["some-arg", "some-other-arg"], + input: "some-input", + }); + }); + + it("calls for file with arguments", () => { + expect(execFileMock).toHaveBeenCalledWith( + "./some-file-path", + [ + "some-arg", + "some-other-arg", + ], + { "maxBuffer": 8589934592 }, + ); + }); + + it("calls with input", () => { + expect(executionStub.stdin.end).toHaveBeenCalledWith("some-input"); + }); + + it("does not resolve yet", async () => { + const promiseStatus = await getPromiseStatus(actualPromise); + + expect(promiseStatus.fulfilled).toBe(false); + }); + + describe("when stdout receives data", () => { + beforeEach(() => { + executionStub.stdout.emit("data", "some-data"); + }); + + it("does not resolve yet", async () => { + const promiseStatus = await getPromiseStatus(actualPromise); + + expect(promiseStatus.fulfilled).toBe(false); + }); + + describe("when stdout receives more data", () => { + beforeEach(() => { + executionStub.stdout.emit("data", "some-other-data"); + }); + + it("does not resolve yet", async () => { + const promiseStatus = await getPromiseStatus(actualPromise); + + expect(promiseStatus.fulfilled).toBe(false); + }); + + it("when execution exits with success, resolves with result", async () => { + executionStub.emit("exit", 0); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: true, + response: "some-datasome-other-data", + }); + }); + + it("when execution exits without exit code, resolves with failure", async () => { + executionStub.emit("exit", null, "SIGKILL"); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: false, + error: "Exited via SIGKILL", + }); + }); + + it("when execution exits with failure, resolves with failure", async () => { + executionStub.emit("exit", 42, "some-signal"); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: false, + error: "Failed with error: some-signal", + }); + }); + + describe("when stderr receives data", () => { + beforeEach(() => { + executionStub.stderr.emit("data", "some-error"); + }); + + it("does not resolve yet", async () => { + const promiseStatus = await getPromiseStatus(actualPromise); + + expect(promiseStatus.fulfilled).toBe(false); + }); + + describe("when stderr receives more data", () => { + beforeEach(() => { + executionStub.stderr.emit("data", "some-other-error"); + }); + + it("does not resolve yet", async () => { + const promiseStatus = await getPromiseStatus(actualPromise); + + expect(promiseStatus.fulfilled).toBe(false); + }); + + it("when execution exits with success, resolves with result", async () => { + executionStub.emit("exit", 0); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: true, + response: "some-datasome-other-data", + }); + }); + + it("when execution exits without exit code, resolves with failure", async () => { + executionStub.emit("exit", null, "some-signal"); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: false, + error: "Exited via some-signal", + }); + }); + + it("when execution exits with failure, resolves with errors", async () => { + executionStub.emit("exit", 42, "irrelevant"); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: false, + error: "some-errorsome-other-error", + }); + }); + }); + }); + }); + }); + + it("when execution receives error, resolves with error", async () => { + executionStub.emit("error", new Error("some-error")); + + const actual = await actualPromise; + + expect(actual).toEqual({ + callWasSuccessful: false, + error: expect.any(Error), + }); + }); + }); +}); diff --git a/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/non-promise-exec-file.injectable.ts b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/non-promise-exec-file.injectable.ts new file mode 100644 index 0000000000..034f5e3055 --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/call-for-kube-resources-by-manifest/exec-file-with-input/non-promise-exec-file.injectable.ts @@ -0,0 +1,14 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import { execFile } from "child_process"; + +const nonPromiseExecFileInjectable = getInjectable({ + id: "non-promise-exec-file", + instantiate: () => execFile, + causesSideEffects: true, +}); + +export default nonPromiseExecFileInjectable; diff --git a/src/main/helm/helm-service/get-helm-release-resources/get-helm-release-resources.injectable.ts b/src/main/helm/helm-service/get-helm-release-resources/get-helm-release-resources.injectable.ts new file mode 100644 index 0000000000..025aab6b4d --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/get-helm-release-resources.injectable.ts @@ -0,0 +1,52 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import callForKubeResourcesByManifestInjectable from "./call-for-kube-resources-by-manifest/call-for-kube-resources-by-manifest.injectable"; +import { groupBy, map } from "lodash/fp"; +import type { JsonObject } from "type-fest"; +import { pipeline } from "@ogre-tools/fp"; +import callForHelmManifestInjectable from "./call-for-helm-manifest/call-for-helm-manifest.injectable"; + +export type GetHelmReleaseResources = ( + name: string, + namespace: string, + kubeconfigPath: string, + kubectlPath: string +) => Promise; + +const getHelmReleaseResourcesInjectable = getInjectable({ + id: "get-helm-release-resources", + + instantiate: (di): GetHelmReleaseResources => { + const callForHelmManifest = di.inject(callForHelmManifestInjectable); + const callForKubeResourcesByManifest = di.inject(callForKubeResourcesByManifestInjectable); + + return async (name, namespace, kubeconfigPath, kubectlPath) => { + const result = await callForHelmManifest(name, namespace, kubeconfigPath); + + if (!result.callWasSuccessful) { + throw new Error(result.error); + } + + const results = await pipeline( + result.response, + + groupBy((item) => item.metadata.namespace || namespace), + + (x) => Object.entries(x), + + map(([namespace, manifest]) => + callForKubeResourcesByManifest(namespace, kubeconfigPath, kubectlPath, manifest), + ), + + promises => Promise.all(promises), + ); + + return results.flat(1); + }; + }, +}); + +export default getHelmReleaseResourcesInjectable; diff --git a/src/main/helm/helm-service/get-helm-release-resources/get-helm-release-resources.test.ts b/src/main/helm/helm-service/get-helm-release-resources/get-helm-release-resources.test.ts new file mode 100644 index 0000000000..6c1b1c0566 --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release-resources/get-helm-release-resources.test.ts @@ -0,0 +1,215 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ + +import { getDiForUnitTesting } from "../../../getDiForUnitTesting"; +import type { GetHelmReleaseResources } from "./get-helm-release-resources.injectable"; +import getHelmReleaseResourcesInjectable from "./get-helm-release-resources.injectable"; +import type { ExecHelm } from "../../exec-helm/exec-helm.injectable"; +import execHelmInjectable from "../../exec-helm/exec-helm.injectable"; +import type { AsyncFnMock } from "@async-fn/jest"; +import asyncFn from "@async-fn/jest"; +import type { JsonObject } from "type-fest"; +import type { ExecFileWithInput } from "./call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.injectable"; +import execFileWithInputInjectable from "./call-for-kube-resources-by-manifest/exec-file-with-input/exec-file-with-input.injectable"; + +describe("get helm release resources", () => { + let getHelmReleaseResources: GetHelmReleaseResources; + let execHelmMock: AsyncFnMock; + let execFileWithStreamInputMock: AsyncFnMock; + + beforeEach(() => { + const di = getDiForUnitTesting({ doGeneralOverrides: true }); + + execHelmMock = asyncFn(); + execFileWithStreamInputMock = asyncFn(); + + di.override(execHelmInjectable, () => execHelmMock); + + di.override( + execFileWithInputInjectable, + () => execFileWithStreamInputMock, + ); + + getHelmReleaseResources = di.inject(getHelmReleaseResourcesInjectable); + }); + + describe("when called", () => { + let actualPromise: Promise; + + beforeEach(() => { + actualPromise = getHelmReleaseResources( + "some-release", + "some-namespace", + "/some-kubeconfig-path", + "/some-kubectl-path", + ); + }); + + it("calls for release manifest", () => { + expect(execHelmMock).toHaveBeenCalledWith([ + "get", "manifest", "some-release", "--namespace", "some-namespace", "--kubeconfig", "/some-kubeconfig-path", + ]); + }); + + it("does not call for resources yet", () => { + expect(execFileWithStreamInputMock).not.toHaveBeenCalled(); + }); + + it("when call for manifest resolves without resources, resolves without resources", async () => { + await execHelmMock.resolve({ + callWasSuccessful: true, + response: "", + }); + + const actual = await actualPromise; + + expect(actual).toEqual([]); + }); + + describe("when call for manifest resolves", () => { + beforeEach(async () => { + await execHelmMock.resolve({ + callWasSuccessful: true, + response: `--- +apiVersion: v1 +kind: SomeKind +metadata: + name: some-resource-with-same-namespace + namespace: some-namespace +--- +apiVersion: v1 +kind: SomeKind +metadata: + name: some-resource-without-namespace +--- +apiVersion: v1 +kind: SomeKind +metadata: + name: some-resource-with-different-namespace + namespace: some-other-namespace +--- +`, + }); + }); + + it("calls for resources from each namespace separately using the manifest as input", () => { + expect(execFileWithStreamInputMock.mock.calls).toEqual([ + [ + { + filePath: "/some-kubectl-path", + commandArguments: ["get", "--kubeconfig", "/some-kubeconfig-path", "-f", "-", "--namespace", "some-namespace", "--output", "json"], + input: `--- +apiVersion: v1 +kind: SomeKind +metadata: + name: some-resource-with-same-namespace + namespace: some-namespace +--- +apiVersion: v1 +kind: SomeKind +metadata: + name: some-resource-without-namespace +--- +`, + }, + ], + + [ + { + filePath: "/some-kubectl-path", + commandArguments: ["get", "--kubeconfig", "/some-kubeconfig-path", "-f", "-", "--namespace", "some-other-namespace", "--output", "json"], + input: `--- +apiVersion: v1 +kind: SomeKind +metadata: + name: some-resource-with-different-namespace + namespace: some-other-namespace +--- +`, + }, + ], + ]); + }); + + it("when all calls for resources resolve, resolves with combined result", async () => { + await execFileWithStreamInputMock.resolveSpecific( + ([{ commandArguments }]) => + commandArguments.includes("some-namespace"), + { + callWasSuccessful: true, + + response: JSON.stringify({ + items: [{ some: "item" }], + + kind: "List", + + metadata: { + resourceVersion: "", + selfLink: "", + }, + }), + }, + ); + + await execFileWithStreamInputMock.resolveSpecific( + ([{ commandArguments }]) => + commandArguments.includes("some-other-namespace"), + { + callWasSuccessful: true, + + response: JSON.stringify({ + items: [{ some: "other-item" }], + + kind: "List", + + metadata: { + resourceVersion: "", + selfLink: "", + }, + }), + }, + ); + + const actual = await actualPromise; + + expect(actual).toEqual([{ some: "item" }, { some: "other-item" }]); + }); + + it("given some call fails, when all calls have finished, rejects with failure", async () => { + await execFileWithStreamInputMock.resolveSpecific( + ([{ commandArguments }]) => + commandArguments.includes("some-namespace"), + + { + callWasSuccessful: true, + + response: JSON.stringify({ + items: [{ some: "item" }], + + kind: "List", + + metadata: { + resourceVersion: "", + selfLink: "", + }, + }), + }, + ); + + execFileWithStreamInputMock.resolveSpecific( + ([{ commandArguments }]) => + commandArguments.includes("some-other-namespace"), + + { + callWasSuccessful: false, + error: "some-error", + }, + ); + + return expect(actualPromise).rejects.toEqual(expect.any(Error)); + }); + }); + }); +}); diff --git a/src/main/helm/helm-service/get-helm-release.global-override-for-injectable.ts b/src/main/helm/helm-service/get-helm-release.global-override-for-injectable.ts new file mode 100644 index 0000000000..0d124468f2 --- /dev/null +++ b/src/main/helm/helm-service/get-helm-release.global-override-for-injectable.ts @@ -0,0 +1,10 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getGlobalOverride } from "../../../common/test-utils/get-global-override"; +import getHelmReleaseInjectable from "./get-helm-release.injectable"; + +export default getGlobalOverride(getHelmReleaseInjectable, () => () => { + throw new Error("Tried to get helm release without explicit override"); +}); diff --git a/src/main/helm/helm-service/get-helm-release.injectable.ts b/src/main/helm/helm-service/get-helm-release.injectable.ts index 130d94af52..3733b2816d 100644 --- a/src/main/helm/helm-service/get-helm-release.injectable.ts +++ b/src/main/helm/helm-service/get-helm-release.injectable.ts @@ -4,14 +4,18 @@ */ import { getInjectable } from "@ogre-tools/injectable"; import type { Cluster } from "../../../common/cluster/cluster"; -import { getRelease } from "../helm-release-manager"; import loggerInjectable from "../../../common/logger.injectable"; +import { isObject, json } from "../../../common/utils"; +import execHelmInjectable from "../exec-helm/exec-helm.injectable"; +import getHelmReleaseResourcesInjectable from "./get-helm-release-resources/get-helm-release-resources.injectable"; const getHelmReleaseInjectable = getInjectable({ id: "get-helm-release", instantiate: (di) => { const logger = di.inject(loggerInjectable); + const execHelm = di.inject(execHelmInjectable); + const getHelmReleaseResources = di.inject(getHelmReleaseResourcesInjectable); return async (cluster: Cluster, releaseName: string, namespace: string) => { const kubeconfigPath = await cluster.getProxyKubeconfigPath(); @@ -20,7 +24,37 @@ const getHelmReleaseInjectable = getInjectable({ logger.debug("Fetch release"); - return getRelease(releaseName, namespace, kubeconfigPath, kubectlPath); + const args = [ + "status", + releaseName, + "--namespace", + namespace, + "--kubeconfig", + kubeconfigPath, + "--output", + "json", + ]; + + const result = await execHelm(args); + + if (!result.callWasSuccessful) { + return undefined; + } + + const release = json.parse(result.response); + + if (!isObject(release) || Array.isArray(release)) { + return undefined; + } + + release.resources = await getHelmReleaseResources( + releaseName, + namespace, + kubeconfigPath, + kubectlPath, + ); + + return release; }; }, diff --git a/src/main/helm/helm-service/update-helm-release.global-override-for-injectable.ts b/src/main/helm/helm-service/update-helm-release.global-override-for-injectable.ts new file mode 100644 index 0000000000..dc2d8b596f --- /dev/null +++ b/src/main/helm/helm-service/update-helm-release.global-override-for-injectable.ts @@ -0,0 +1,10 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getGlobalOverride } from "../../../common/test-utils/get-global-override"; +import updateHelmReleaseInjectable from "./update-helm-release.injectable"; + +export default getGlobalOverride(updateHelmReleaseInjectable, () => () => { + throw new Error("Tried to update helm release without explicit override"); +}); diff --git a/src/main/helm/helm-service/update-helm-release.injectable.ts b/src/main/helm/helm-service/update-helm-release.injectable.ts index 96e0e0050b..e07269ce6a 100644 --- a/src/main/helm/helm-service/update-helm-release.injectable.ts +++ b/src/main/helm/helm-service/update-helm-release.injectable.ts @@ -4,9 +4,13 @@ */ import { getInjectable } from "@ogre-tools/injectable"; import type { Cluster } from "../../../common/cluster/cluster"; -import { upgradeRelease } from "../helm-release-manager"; import loggerInjectable from "../../../common/logger.injectable"; import type { JsonObject } from "type-fest"; +import { execHelm } from "../exec"; +import tempy from "tempy"; +import fse from "fs-extra"; +import yaml from "js-yaml"; +import getHelmReleaseInjectable from "./get-helm-release.injectable"; export interface UpdateChartArgs { chart: string; @@ -19,23 +23,37 @@ const updateHelmReleaseInjectable = getInjectable({ instantiate: (di) => { const logger = di.inject(loggerInjectable); + const getHelmRelease = di.inject(getHelmReleaseInjectable); return async (cluster: Cluster, releaseName: string, namespace: string, data: UpdateChartArgs) => { const proxyKubeconfig = await cluster.getProxyKubeconfigPath(); - const kubectl = await cluster.ensureKubectl(); - const kubectlPath = await kubectl.getPath(); logger.debug("Upgrade release"); - return upgradeRelease( + const valuesFilePath = tempy.file({ name: "values.yaml" }); + + await fse.writeFile(valuesFilePath, yaml.dump(data.values)); + + const args = [ + "upgrade", releaseName, data.chart, - data.values, - namespace, - data.version, - proxyKubeconfig, - kubectlPath, - ); + "--version", data.version, + "--values", valuesFilePath, + "--namespace", namespace, + "--kubeconfig", proxyKubeconfig, + ]; + + try { + const output = await execHelm(args); + + return { + log: output, + release: await getHelmRelease(cluster, releaseName, namespace), + }; + } finally { + await fse.unlink(valuesFilePath); + } }; }, @@ -43,3 +61,4 @@ const updateHelmReleaseInjectable = getInjectable({ }); export default updateHelmReleaseInjectable; + diff --git a/src/main/helm/repositories/add-helm-repository/add-helm-repository.injectable.ts b/src/main/helm/repositories/add-helm-repository/add-helm-repository.injectable.ts index aa898eb099..73283884c3 100644 --- a/src/main/helm/repositories/add-helm-repository/add-helm-repository.injectable.ts +++ b/src/main/helm/repositories/add-helm-repository/add-helm-repository.injectable.ts @@ -54,7 +54,7 @@ const addHelmRepositoryInjectable = getInjectable({ args.push("--cert-file", certFile); } - return await execHelm(...args); + return await execHelm(args); }; }, }); diff --git a/src/main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable.ts b/src/main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable.ts index d1b0c64311..c4fb86451b 100644 --- a/src/main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable.ts +++ b/src/main/helm/repositories/get-active-helm-repositories/get-active-helm-repositories.injectable.ts @@ -75,7 +75,7 @@ const getActiveHelmRepositoriesInjectable = getInjectable({ }; } - const updateResult = await execHelm("repo", "update"); + const updateResult = await execHelm(["repo", "update"]); if (!updateResult.callWasSuccessful) { if (!updateResult.error.includes(internalHelmErrorForNoRepositoriesFound)) { @@ -84,7 +84,7 @@ const getActiveHelmRepositoriesInjectable = getInjectable({ error: `Error updating Helm repositories: ${updateResult.error}`, }; } - const resultOfAddingDefaultRepository = await execHelm("repo", "add", "bitnami", "https://charts.bitnami.com/bitnami"); + const resultOfAddingDefaultRepository = await execHelm(["repo", "add", "bitnami", "https://charts.bitnami.com/bitnami"]); if (!resultOfAddingDefaultRepository.callWasSuccessful) { return { diff --git a/src/main/helm/repositories/remove-helm-repository/remove-helm-repository.injectable.ts b/src/main/helm/repositories/remove-helm-repository/remove-helm-repository.injectable.ts index 21f37490bc..c858667f6a 100644 --- a/src/main/helm/repositories/remove-helm-repository/remove-helm-repository.injectable.ts +++ b/src/main/helm/repositories/remove-helm-repository/remove-helm-repository.injectable.ts @@ -17,11 +17,11 @@ const removeHelmRepositoryInjectable = getInjectable({ return async (repo: HelmRepo) => { logger.info(`[HELM]: removing repo ${repo.name} (${repo.url})`); - return execHelm( + return execHelm([ "repo", "remove", repo.name, - ); + ]); }; }, }); diff --git a/src/renderer/components/+helm-releases/release-details/release-details-content.tsx b/src/renderer/components/+helm-releases/release-details/release-details-content.tsx index b03f23de34..b2bacbd479 100644 --- a/src/renderer/components/+helm-releases/release-details/release-details-content.tsx +++ b/src/renderer/components/+helm-releases/release-details/release-details-content.tsx @@ -8,8 +8,8 @@ import "./release-details.scss"; import React from "react"; import { Link } from "react-router-dom"; -import { Drawer, DrawerItem, DrawerTitle } from "../../drawer"; -import { cssNames, stopPropagation } from "../../../utils"; +import { DrawerItem, DrawerTitle } from "../../drawer"; +import { stopPropagation } from "../../../utils"; import { observer } from "mobx-react"; import { withInjectables } from "@ogre-tools/injectable-react"; import type { ConfigurationInput, MinimalResourceGroup, OnlyUserSuppliedValuesAreShownToggle, ReleaseDetailsModel } from "./release-details-model/release-details-model.injectable"; @@ -20,7 +20,6 @@ import { Badge } from "../../badge"; import { SubTitle } from "../../layout/sub-title"; import { Table, TableCell, TableHead, TableRow } from "../../table"; import { ReactiveDuration } from "../../duration/reactive-duration"; -import { HelmReleaseMenu } from "../release-menu"; import { Checkbox } from "../../checkbox"; import { MonacoEditor } from "../../monaco-editor"; import { Spinner } from "../../spinner"; @@ -35,97 +34,86 @@ interface Dependencies { } const NonInjectedReleaseDetailsContent = observer(({ model }: Dependencies & ReleaseDetailsContentProps) => { - const isLoading = model.isLoading.get(); + const loadingError = model.loadingError.get(); + + if (loadingError) { + return ( +
+ Failed to load release: + {" "} + {loadingError} +
+ ); + } + return ( - + +
+ {model.release.chart} + +
- + + {`${model.release.getUpdated()} ago (${model.release.updated})`} + - - {model.release.getUpdated()} - {` ago (${model.release.updated})`} - + {model.release.getNs()} - {model.release.getNs()} + +
+ {model.release.getVersion()} +
+ - -
- {model.release.getVersion()} -
- + + + - - - + - + Notes - Notes + {model.notes &&
{model.notes}
} - {model.notes &&
{model.notes}
} + Resources - Resources - - {model.groupedResources.length > 0 && ( -
- {model.groupedResources.map((group) => ( - - ))} -
- )} + {model.groupedResources.length > 0 && ( +
+ {model.groupedResources.map((group) => ( + + ))}
)} - +
); }); export const ReleaseDetailsContent = withInjectables(NonInjectedReleaseDetailsContent, { - getProps: (di, props) => ({ - model: di.inject(releaseDetailsModelInjectable, props.targetRelease), + getPlaceholder: () => , + + getProps: async (di, props) => ({ + model: await di.inject(releaseDetailsModelInjectable, props.targetRelease), ...props, }), }); diff --git a/src/renderer/components/+helm-releases/release-details/release-details-drawer-toolbar.tsx b/src/renderer/components/+helm-releases/release-details/release-details-drawer-toolbar.tsx new file mode 100644 index 0000000000..cb7d5009ec --- /dev/null +++ b/src/renderer/components/+helm-releases/release-details/release-details-drawer-toolbar.tsx @@ -0,0 +1,53 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ + +import "./release-details.scss"; + +import React from "react"; + +import { observer } from "mobx-react"; +import { withInjectables } from "@ogre-tools/injectable-react"; +import type { TargetHelmRelease } from "./target-helm-release.injectable"; +import navigateToHelmReleasesInjectable from "../../../../common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable"; +import type { ReleaseDetailsModel } from "./release-details-model/release-details-model.injectable"; +import releaseDetailsModelInjectable from "./release-details-model/release-details-model.injectable"; +import { HelmReleaseMenu } from "../release-menu"; + +interface ReleaseDetailsDrawerProps { + targetRelease: TargetHelmRelease; +} + +interface Dependencies { + model: ReleaseDetailsModel; + navigateToHelmReleases: () => void; +} + +const NonInjectedReleaseDetailsDrawerToolbar = observer(({ + model, + navigateToHelmReleases, +}: Dependencies & ReleaseDetailsDrawerProps) => ( + model.loadingError.get() + ? null + : ( + + ) +)); + +export const ReleaseDetailsDrawerToolbar = withInjectables< + Dependencies, + ReleaseDetailsDrawerProps +>(NonInjectedReleaseDetailsDrawerToolbar, { + getPlaceholder: () => <>, + + getProps: async (di, props) => ({ + model: await di.inject(releaseDetailsModelInjectable, props.targetRelease), + navigateToHelmReleases: di.inject(navigateToHelmReleasesInjectable), + ...props, + }), +}); diff --git a/src/renderer/components/+helm-releases/release-details/release-details-drawer.tsx b/src/renderer/components/+helm-releases/release-details/release-details-drawer.tsx new file mode 100644 index 0000000000..67676ce337 --- /dev/null +++ b/src/renderer/components/+helm-releases/release-details/release-details-drawer.tsx @@ -0,0 +1,58 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ + +import "./release-details.scss"; + +import React from "react"; + +import { Drawer } from "../../drawer"; +import { cssNames } from "../../../utils"; +import { observer } from "mobx-react"; +import { withInjectables } from "@ogre-tools/injectable-react"; +import type { TargetHelmRelease } from "./target-helm-release.injectable"; +import type { ActiveThemeType } from "../../../themes/active-type.injectable"; +import activeThemeTypeInjectable from "../../../themes/active-type.injectable"; +import { ReleaseDetailsContent } from "./release-details-content"; +import navigateToHelmReleasesInjectable from "../../../../common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable"; +import { ReleaseDetailsDrawerToolbar } from "./release-details-drawer-toolbar"; + +interface ReleaseDetailsDrawerProps { + targetRelease: TargetHelmRelease; +} + +interface Dependencies { + activeThemeType: ActiveThemeType; + closeDrawer: () => void; +} + +const NonInjectedReleaseDetailsDrawer = observer(({ + activeThemeType, + closeDrawer, + targetRelease, +}: Dependencies & ReleaseDetailsDrawerProps) => ( + } + data-testid={`helm-release-details-for-${targetRelease.namespace}/${targetRelease.name}`} + > + + +)); + +export const ReleaseDetailsDrawer = withInjectables< + Dependencies, + ReleaseDetailsDrawerProps +>(NonInjectedReleaseDetailsDrawer, { + getProps: (di, props) => ({ + activeThemeType: di.inject(activeThemeTypeInjectable), + closeDrawer: di.inject(navigateToHelmReleasesInjectable), + ...props, + }), +}); diff --git a/src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release.injectable.ts b/src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release.injectable.ts index fcf1496ba7..bfcc947d08 100644 --- a/src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release.injectable.ts +++ b/src/renderer/components/+helm-releases/release-details/release-details-model/call-for-helm-release/call-for-helm-release.injectable.ts @@ -7,6 +7,7 @@ import type { HelmReleaseDto } from "../../../../../../common/k8s-api/endpoints/ import callForHelmReleasesInjectable from "../../../call-for-helm-releases/call-for-helm-releases.injectable"; import type { HelmReleaseDetails } from "./call-for-helm-release-details/call-for-helm-release-details.injectable"; import callForHelmReleaseDetailsInjectable from "./call-for-helm-release-details/call-for-helm-release-details.injectable"; +import type { AsyncResult } from "../../../../../../common/utils/async-result"; export interface DetailedHelmRelease { release: HelmReleaseDto; @@ -16,7 +17,7 @@ export interface DetailedHelmRelease { export type CallForHelmRelease = ( name: string, namespace: string -) => Promise; +) => Promise>; const callForHelmReleaseInjectable = getInjectable({ id: "call-for-helm-release", @@ -36,10 +37,13 @@ const callForHelmReleaseInjectable = getInjectable({ ); if (!release) { - return undefined; + return { + callWasSuccessful: false, + error: `Release ${name} didn't exist in ${namespace} namespace.`, + }; } - return { release, details }; + return { callWasSuccessful: true, response: { release, details }}; }; }, }); diff --git a/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx b/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx index f36e3c8cce..ebedbcdcdf 100644 --- a/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx +++ b/src/renderer/components/+helm-releases/release-details/release-details-model/release-details-model.injectable.tsx @@ -26,16 +26,14 @@ import showSuccessNotificationInjectable from "../../../notifications/show-succe import React from "react"; import createUpgradeChartTabInjectable from "../../../dock/upgrade-chart/create-upgrade-chart-tab.injectable"; import type { HelmRelease } from "../../../../../common/k8s-api/endpoints/helm-releases.api"; -import type { NavigateToHelmReleases } from "../../../../../common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable"; import navigateToHelmReleasesInjectable from "../../../../../common/front-end-routing/routes/cluster/helm/releases/navigate-to-helm-releases.injectable"; import assert from "assert"; -import withOrphanPromiseInjectable from "../../../../../common/utils/with-orphan-promise/with-orphan-promise.injectable"; import activeThemeInjectable from "../../../../themes/active.injectable"; const releaseDetailsModelInjectable = getInjectable({ id: "release-details-model", - instantiate: (di, targetRelease: TargetHelmRelease) => { + instantiate: async (di, targetRelease: TargetHelmRelease) => { const callForHelmRelease = di.inject(callForHelmReleaseInjectable); const callForHelmReleaseConfiguration = di.inject(callForHelmReleaseConfigurationInjectable); const activeTheme = di.inject(activeThemeInjectable); @@ -45,7 +43,6 @@ const releaseDetailsModelInjectable = getInjectable({ const showSuccessNotification = di.inject(showSuccessNotificationInjectable); const createUpgradeChartTab = di.inject(createUpgradeChartTabInjectable); const navigateToHelmReleases = di.inject(navigateToHelmReleasesInjectable); - const withOrphanPromise = di.inject(withOrphanPromiseInjectable); const model = new ReleaseDetailsModel({ callForHelmRelease, @@ -60,56 +57,52 @@ const releaseDetailsModelInjectable = getInjectable({ navigateToHelmReleases, }); - const load = withOrphanPromise(model.load); - - // TODO: Reorganize Drawer to allow setting of header-bar in children to make "getPlaceholder" from injectable usable. - load(); + await model.load(); return model; }, lifecycle: lifecycleEnum.keyedSingleton({ - getInstanceKey: (di, release: TargetHelmRelease) => - `${release.namespace}/${release.name}`, + getInstanceKey: (di, release: TargetHelmRelease) => `${release.namespace}/${release.name}`, }), }); export default releaseDetailsModelInjectable; export interface OnlyUserSuppliedValuesAreShownToggle { - value: IObservableValue; + readonly value: IObservableValue; toggle: () => Promise; } export interface ConfigurationInput { - nonSavedValue: IObservableValue; - isLoading: IObservableValue; - isSaving: IObservableValue; + readonly nonSavedValue: IObservableValue; + readonly isLoading: IObservableValue; + readonly isSaving: IObservableValue; onChange: (value: string) => void; save: () => Promise; } interface Dependencies { + readonly targetRelease: TargetHelmRelease; + readonly activeTheme: IComputedValue; callForHelmRelease: CallForHelmRelease; - targetRelease: TargetHelmRelease; - activeTheme: IComputedValue; callForHelmReleaseConfiguration: CallForHelmReleaseConfiguration; getResourceDetailsUrl: GetResourceDetailsUrl; updateRelease: CallForHelmReleaseUpdate; showCheckedErrorNotification: ShowCheckedErrorNotification; showSuccessNotification: ShowNotification; createUpgradeChartTab: (release: HelmRelease) => string; - navigateToHelmReleases: NavigateToHelmReleases; + navigateToHelmReleases: () => void; } export class ReleaseDetailsModel { - id = `${this.dependencies.targetRelease.namespace}/${this.dependencies.targetRelease.name}`; + readonly id = `${this.dependencies.targetRelease.namespace}/${this.dependencies.targetRelease.name}`; - constructor(private dependencies: Dependencies) {} + constructor(private readonly dependencies: Dependencies) {} - private detailedRelease = observable.box(); + private readonly detailedRelease = observable.box(); - readonly isLoading = observable.box(false); + readonly loadingError = observable.box(); readonly configuration: ConfigurationInput = { nonSavedValue: observable.box(""), @@ -176,26 +169,26 @@ export class ReleaseDetailsModel { }; load = async () => { - runInAction(() => { - this.isLoading.set(true); - }); - const { name, namespace } = this.dependencies.targetRelease; - const detailedRelease = await this.dependencies.callForHelmRelease( + const result = await this.dependencies.callForHelmRelease( name, namespace, ); + if (!result.callWasSuccessful) { + runInAction(() => { + this.loadingError.set(result.error); + }); + + return; + } + runInAction(() => { - this.detailedRelease.set(detailedRelease); + this.detailedRelease.set(result.response); }); await this.loadConfiguration(); - - runInAction(() => { - this.isLoading.set(false); - }); }; private loadConfiguration = async () => { @@ -269,7 +262,7 @@ export class ReleaseDetailsModel { startUpgradeProcess = () => { this.dependencies.createUpgradeChartTab(this.release); - this.close(); + this.dependencies.navigateToHelmReleases(); }; } diff --git a/src/renderer/components/+helm-releases/release-details/release-details.scss b/src/renderer/components/+helm-releases/release-details/release-details.scss index 780d3df401..c061b7d782 100644 --- a/src/renderer/components/+helm-releases/release-details/release-details.scss +++ b/src/renderer/components/+helm-releases/release-details/release-details.scss @@ -49,16 +49,19 @@ .TableCell { text-overflow: unset; word-break: break-word; - min-width: 100px; &.name { - flex-basis: auto; - flex-grow: 0; - width: 230px; + flex-grow: 3; } - &.volume { - flex-basis: 30%; + &.namespace { + flex-grow: 1; + } + + &.age { + flex-basis: 100px; + flex-grow: 0; + flex-shrink: 0; } } } diff --git a/src/renderer/components/+helm-releases/release-details/release-details.tsx b/src/renderer/components/+helm-releases/release-details/release-details.tsx index 254d9e1edc..53fc2adc35 100644 --- a/src/renderer/components/+helm-releases/release-details/release-details.tsx +++ b/src/renderer/components/+helm-releases/release-details/release-details.tsx @@ -11,9 +11,9 @@ import { observer } from "mobx-react"; import { withInjectables } from "@ogre-tools/injectable-react"; import type { IComputedValue } from "mobx"; -import { ReleaseDetailsContent } from "./release-details-content"; import type { TargetHelmRelease } from "./target-helm-release.injectable"; import targetHelmReleaseInjectable from "./target-helm-release.injectable"; +import { ReleaseDetailsDrawer } from "./release-details-drawer"; interface Dependencies { targetRelease: IComputedValue< @@ -25,7 +25,7 @@ const NonInjectedReleaseDetails = observer( ({ targetRelease }: Dependencies) => { const release = targetRelease.get(); - return release ? : null; + return release ? : null; }, ); diff --git a/src/renderer/themes/active-type.injectable.ts b/src/renderer/themes/active-type.injectable.ts new file mode 100644 index 0000000000..9c67454d50 --- /dev/null +++ b/src/renderer/themes/active-type.injectable.ts @@ -0,0 +1,23 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import type { IComputedValue } from "mobx"; +import { computed } from "mobx"; +import type { LensThemeType } from "./store"; +import themeStoreInjectable from "./store.injectable"; + +export type ActiveThemeType = IComputedValue; + +const activeThemeTypeInjectable = getInjectable({ + id: "active-theme-type", + + instantiate: (di) => { + const store = di.inject(themeStoreInjectable); + + return computed(() => store.activeTheme.type); + }, +}); + +export default activeThemeTypeInjectable; diff --git a/src/renderer/themes/store.ts b/src/renderer/themes/store.ts index 28abba7816..1845d17f95 100644 --- a/src/renderer/themes/store.ts +++ b/src/renderer/themes/store.ts @@ -17,10 +17,10 @@ import type { ReadonlyDeep } from "type-fest/source/readonly-deep"; import assert from "assert"; export type ThemeId = string; - +export type LensThemeType = "dark" | "light"; export interface LensTheme { name: string; - type: "dark" | "light"; + type: LensThemeType; colors: Record; description: string; author: string;