hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Prevent shell sync commands from polluting history (#6668)

Browse Source 
* Prevent shell sync commands from polluting history

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix tests

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2022-12-20 05:33:48 -08:00 committed by GitHub
parent 8db81a4731
commit ed26e245e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/features/shell-sync/main/compute-unix-shell-environment.injectable.ts
View File

@ -84,6 +84,7 @@ const computeUnixShellEnvironmentInjectable = getInjectable({
} else if (!cshLikeShellName.test(shellName)) {
// zsh (at least, maybe others) don't load RC files when in non-interactive mode, even when using -l (login) option
shellArgs.push("-i");
command = ` ${command}`; // This prevents the command from being added to the history
} else {
// Some shells don't support any other options when providing the -l (login) shell option
}

2
src/features/shell-sync/main/compute-unix-shell-environment.test.ts
View File

@ -218,7 +218,7 @@ describe("computeUnixShellEnvironment technical tests", () => {
});
it("should send the command via stdin", () => {
expect(stdinValue).toBe(`'/some/process/exec/path' -p '"deadbeef" + JSON.stringify(process.env) + "deadbeef"'`);
expect(stdinValue).toBe(` '/some/process/exec/path' -p '"deadbeef" + JSON.stringify(process.env) + "deadbeef"'`);
});
it("should close stdin", () => {