From efc79729c438fdfc6109ab6a4a5ae3ae0dec721e Mon Sep 17 00:00:00 2001
From: Alex Andreev <alex.andreev.email@gmail.com>
Date: Mon, 28 Nov 2022 11:51:51 +0300
Subject: [PATCH] Fixing log-search tests

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
---
 .../dock/logs/__test__/log-search.test.tsx    | 27 ++++++++++++++-----
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/src/renderer/components/dock/logs/__test__/log-search.test.tsx b/src/renderer/components/dock/logs/__test__/log-search.test.tsx
index cf503772aa..ce697f4451 100644
--- a/src/renderer/components/dock/logs/__test__/log-search.test.tsx
+++ b/src/renderer/components/dock/logs/__test__/log-search.test.tsx
@@ -63,13 +63,28 @@ const getOnePodViewModel = (tabId: TabId, deps: Partial<LogTabViewModelDependenc
 
 describe("LogSearch tests", () => {
   let render: DiRender;
+  let setPrevOverlayActiveMock: jest.SpyInstance<void, []>;
+  let setNextOverlayActiveMock: jest.SpyInstance<void, []>;
 
   beforeEach(() => {
     const di = getDiForUnitTesting({ doGeneralOverrides: true });
 
+    setPrevOverlayActiveMock = jest
+      .spyOn(SearchStore.prototype, "setPrevOverlayActive")
+      .mockImplementation(() => jest.fn());
+
+    setNextOverlayActiveMock = jest
+      .spyOn(SearchStore.prototype, "setNextOverlayActive")
+      .mockImplementation(() => jest.fn());
+
     render = renderFor(di);
   });
 
+  afterEach(() => {
+    setNextOverlayActiveMock.mockClear();
+    setPrevOverlayActiveMock.mockClear();
+  });
+
   it("renders w/o errors", () => {
     const model = getOnePodViewModel("foobar");
     const { container } = render(
@@ -80,7 +95,6 @@ describe("LogSearch tests", () => {
   });
 
   it("should scroll to new active overlay when clicking the previous button", async () => {
-    const scrollToOverlay = jest.fn();
     const model = getOnePodViewModel("foobar", {
       getLogsWithoutTimestamps: () => [
         "hello",
@@ -91,15 +105,14 @@ describe("LogSearch tests", () => {
     render(
       <LogSearch model={model}/>,
     );
-
+    
     userEvent.click(await screen.findByPlaceholderText("Search..."));
     userEvent.keyboard("o");
     userEvent.click(await screen.findByText("keyboard_arrow_up"));
-    expect(scrollToOverlay).toBeCalled();
+    expect(setPrevOverlayActiveMock).toHaveBeenCalled();
   });
 
   it("should scroll to new active overlay when clicking the next button", async () => {
-    const scrollToOverlay = jest.fn();
     const model = getOnePodViewModel("foobar", {
       getLogsWithoutTimestamps: () => [
         "hello",
@@ -114,11 +127,10 @@ describe("LogSearch tests", () => {
     userEvent.click(await screen.findByPlaceholderText("Search..."));
     userEvent.keyboard("o");
     userEvent.click(await screen.findByText("keyboard_arrow_down"));
-    expect(scrollToOverlay).toBeCalled();
+    expect(setNextOverlayActiveMock).toBeCalled();
   });
 
   it("next and previous should be disabled initially", async () => {
-    const scrollToOverlay = jest.fn();
     const model = getOnePodViewModel("foobar", {
       getLogsWithoutTimestamps: () => [
         "hello",
@@ -132,6 +144,7 @@ describe("LogSearch tests", () => {
 
     userEvent.click(await screen.findByText("keyboard_arrow_down"));
     userEvent.click(await screen.findByText("keyboard_arrow_up"));
-    expect(scrollToOverlay).not.toBeCalled();
+    expect(setNextOverlayActiveMock).not.toBeCalled();
+    expect(setPrevOverlayActiveMock).not.toBeCalled();
   });
 });