From f12b0658bae1ecbd5f9cf625a15c1d2f729d9199 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Mon, 18 Oct 2021 09:38:10 -0400 Subject: [PATCH] Add URL display to weblink URLs (#4046) --- src/common/catalog-entities/web-link.ts | 7 +++++-- .../catalog-entity-detail-registry.tsx | 18 ++++++++++++++++-- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/common/catalog-entities/web-link.ts b/src/common/catalog-entities/web-link.ts index 8309945f24..a613a7e44e 100644 --- a/src/common/catalog-entities/web-link.ts +++ b/src/common/catalog-entities/web-link.ts @@ -35,8 +35,11 @@ export type WebLinkSpec = { }; export class WebLink extends CatalogEntity { - public readonly apiVersion = "entity.k8slens.dev/v1alpha1"; - public readonly kind = "WebLink"; + public static readonly apiVersion = "entity.k8slens.dev/v1alpha1"; + public static readonly kind = "WebLink"; + + public readonly apiVersion = WebLink.apiVersion; + public readonly kind = WebLink.kind; async onRun() { window.open(this.spec.url, "_blank"); diff --git a/src/renderer/initializers/catalog-entity-detail-registry.tsx b/src/renderer/initializers/catalog-entity-detail-registry.tsx index 8cae26afbf..90605a084f 100644 --- a/src/renderer/initializers/catalog-entity-detail-registry.tsx +++ b/src/renderer/initializers/catalog-entity-detail-registry.tsx @@ -20,7 +20,7 @@ */ import React from "react"; -import { KubernetesCluster } from "../../common/catalog-entities"; +import { KubernetesCluster, WebLink } from "../../common/catalog-entities"; import { CatalogEntityDetailRegistry, CatalogEntityDetailsProps } from "../../extensions/registries"; import { DrawerItem, DrawerTitle } from "../components/drawer"; @@ -45,6 +45,20 @@ export function initCatalogEntityDetailRegistry() { ), }, - } + }, + { + apiVersions: [WebLink.apiVersion], + kind: WebLink.kind, + components: { + Details: ({ entity }: CatalogEntityDetailsProps) => ( + <> + + + {entity.spec.url} + + + ), + }, + }, ]); }