From f21e42d7e7e547f146970b58b059e181292751d5 Mon Sep 17 00:00:00 2001 From: Sebastian Malton Date: Wed, 3 May 2023 11:22:16 -0400 Subject: [PATCH] chore: Fix type errors Signed-off-by: Sebastian Malton --- .../adding-of-public-helm-repository.tsx | 2 +- .../telemetry/renderer/emit-telemetry.injectable.ts | 2 +- packages/core/src/main/__test__/cluster.test.ts | 7 ++++++- .../src/main/catalog-sources/kubeconfig-sync/manager.ts | 3 +-- .../shell-request-authenticator.ts | 2 +- .../workload-overview-detail-injection-token.ts | 2 +- .../port-forward/port-forward-store/port-forward-store.ts | 4 ++-- 7 files changed, 13 insertions(+), 9 deletions(-) diff --git a/packages/core/src/features/helm-charts/child-features/preferences/renderer/adding-of-public-helm-repository/adding-of-public-helm-repository.tsx b/packages/core/src/features/helm-charts/child-features/preferences/renderer/adding-of-public-helm-repository/adding-of-public-helm-repository.tsx index 8f96c530a3..fd3113f395 100644 --- a/packages/core/src/features/helm-charts/child-features/preferences/renderer/adding-of-public-helm-repository/adding-of-public-helm-repository.tsx +++ b/packages/core/src/features/helm-charts/child-features/preferences/renderer/adding-of-public-helm-repository/adding-of-public-helm-repository.tsx @@ -45,7 +45,7 @@ const NonInjectedAddingOfPublicHelmRepository = observer(({ isLoading={valuesAreLoading} isDisabled={valuesAreLoading} options={repositoryOptions} - onChange={(...args) => void selectRepository(...args)} + onChange={(value) => void selectRepository(value)} value={dereferencesPublicRepositories} formatOptionLabel={formatOptionLabel} controlShouldRenderValue={false} diff --git a/packages/core/src/features/telemetry/renderer/emit-telemetry.injectable.ts b/packages/core/src/features/telemetry/renderer/emit-telemetry.injectable.ts index 5fbc2f4b38..3b82102324 100644 --- a/packages/core/src/features/telemetry/renderer/emit-telemetry.injectable.ts +++ b/packages/core/src/features/telemetry/renderer/emit-telemetry.injectable.ts @@ -12,7 +12,7 @@ const emitTelemetryInjectable = getInjectable({ instantiate: (di) => { const emitEvent = di.inject(emitEventInjectable); - return ({ action, params }: { action: string; params?: object }) => { + return ({ action, params }: { action: string; params?: Record }) => { emitEvent({ destination: "auto-capture", action: "telemetry-from-business-action", diff --git a/packages/core/src/main/__test__/cluster.test.ts b/packages/core/src/main/__test__/cluster.test.ts index fa7505f719..c5b32e75b3 100644 --- a/packages/core/src/main/__test__/cluster.test.ts +++ b/packages/core/src/main/__test__/cluster.test.ts @@ -21,6 +21,7 @@ import createListNamespacesInjectable from "../../common/cluster/list-namespaces import prometheusHandlerInjectable from "../cluster/prometheus-handler/prometheus-handler.injectable"; import writeJsonSyncInjectable from "../../common/fs/write-json-sync.injectable"; import addClusterInjectable from "../../features/cluster/storage/common/add.injectable"; +import assert from "assert"; describe("create clusters", () => { let cluster: Cluster; @@ -75,11 +76,15 @@ describe("create clusters", () => { const addCluster = di.inject(addClusterInjectable); - cluster = addCluster({ + const clusterResult = addCluster({ id: "foo", contextName: "minikube", kubeConfigPath: "/minikube-config.yml", }); + + assert(clusterResult.isOk); + + cluster = clusterResult.value; clusterConnection = di.inject(clusterConnectionInjectable, cluster); }); diff --git a/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts b/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts index b815e46f4c..3e4611dcaa 100644 --- a/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts +++ b/packages/core/src/main/catalog-sources/kubeconfig-sync/manager.ts @@ -10,12 +10,11 @@ import type { Disposer } from "@k8slens/utilities"; import { iter } from "@k8slens/utilities"; import type { Logger } from "@k8slens/logger"; import type { WatchKubeconfigFileChanges } from "./watch-file-changes.injectable"; -import type { KubeconfigSyncValue } from "../../../features/user-preferences/common/preferences-helpers"; interface KubeconfigSyncManagerDependencies { readonly directoryForKubeConfigs: string; readonly logger: Logger; - readonly kubeconfigSyncs: ObservableMap; + readonly kubeconfigSyncs: ObservableMap; watchKubeconfigFileChanges: WatchKubeconfigFileChanges; } diff --git a/packages/core/src/main/lens-proxy/proxy-functions/shell-request-authenticator/shell-request-authenticator.ts b/packages/core/src/main/lens-proxy/proxy-functions/shell-request-authenticator/shell-request-authenticator.ts index 91d4161164..d88ef39679 100644 --- a/packages/core/src/main/lens-proxy/proxy-functions/shell-request-authenticator/shell-request-authenticator.ts +++ b/packages/core/src/main/lens-proxy/proxy-functions/shell-request-authenticator/shell-request-authenticator.ts @@ -18,7 +18,7 @@ export class ShellRequestAuthenticator { const authToken = Uint8Array.from(await randomBytes(128)); const forCluster = getOrInsertMap(this.tokens, clusterId); - forCluster.set(tabId, authToken); + forCluster.set(tabId as string, authToken); return authToken; }); diff --git a/packages/core/src/renderer/components/workloads-overview/workload-overview-details/workload-overview-detail-injection-token.ts b/packages/core/src/renderer/components/workloads-overview/workload-overview-details/workload-overview-detail-injection-token.ts index 985ee1937d..d6e742678c 100644 --- a/packages/core/src/renderer/components/workloads-overview/workload-overview-details/workload-overview-detail-injection-token.ts +++ b/packages/core/src/renderer/components/workloads-overview/workload-overview-details/workload-overview-detail-injection-token.ts @@ -8,7 +8,7 @@ import type React from "react"; export interface WorkloadOverviewDetail { orderNumber: number; - Component: React.ElementType; + Component: React.ElementType; enabled: IComputedValue; } diff --git a/packages/core/src/renderer/port-forward/port-forward-store/port-forward-store.ts b/packages/core/src/renderer/port-forward/port-forward-store/port-forward-store.ts index 7ca10ea3e5..5c64a5be3f 100644 --- a/packages/core/src/renderer/port-forward/port-forward-store/port-forward-store.ts +++ b/packages/core/src/renderer/port-forward/port-forward-store/port-forward-store.ts @@ -65,8 +65,8 @@ export class PortForwardStore extends ItemStore { ); } - loadAll() { - return this.loadItems(() => { + async loadAll() { + await this.loadItems(() => { const portForwards = this.getPortForwards(); this.dependencies.storage.set(portForwards);