Fix installation of helm charts (#5841)

* Relax validator for installing charts

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Tweak spacing between words in confirmation dialog

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Add mocks for monaco editor and virtualized auto sizer to allow components to be rendered in unit tests

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Improve typing for a function

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Remove usage of shared global state from a component

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Provide a way to unit test usages of storages

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Add way to get current value from select in behavioural unit tests

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Rework installation of helm charts to get rid of the majority of bugs

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Update snapshots

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Remove technical test for being covered in behaviours

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Split behaviour to smaller pieces

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Add tests accidentally removed back

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Mark functions causing side effects

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Remove behaviour covered by other behaviours

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Tweak naming

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

* Remove unused dependency

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>

src/renderer/utils/create-storage/create-storage.injectable.ts

@@ -11,6 +11,7 @@ import { observable } from "mobx";
 import loggerInjectable from "../../../common/logger.injectable";
 import getAbsolutePathInjectable from "../../../common/path/get-absolute-path.injectable";
 import hostedClusterIdInjectable from "../../cluster-frame-context/hosted-cluster-id.injectable";
+import storageSaveDelayInjectable from "./storage-save-delay.injectable";
 
 const createStorageInjectable = getInjectable({
   id: "create-storage",
@@ -27,6 +28,7 @@ const createStorageInjectable = getInjectable({
     directoryForLensLocalStorage: di.inject(directoryForLensLocalStorageInjectable),
     getAbsolutePath: di.inject(getAbsolutePathInjectable),
     hostedClusterId: di.inject(hostedClusterIdInjectable),
+    saveDelay: di.inject(storageSaveDelayInjectable),
   }),
 });
 

src/renderer/utils/create-storage/create-storage.ts

@@ -21,6 +21,7 @@ interface Dependencies {
   writeJsonFile: (filePath: string, contentObject: JsonObject) => Promise<void>;
   getAbsolutePath: GetAbsolutePath;
   hostedClusterId: string | undefined;
+  saveDelay: number;
 }
 
 export type CreateStorage = <T>(key: string, defaultValue: T) => StorageLayer<T>;
@@ -36,6 +37,7 @@ export const createStorage = ({
   readJsonFile,
   writeJsonFile,
   hostedClusterId,
+  saveDelay,
 }: Dependencies): CreateStorage => (key, defaultValue) => {
   const { logPrefix } = StorageHelper;
 
@@ -59,7 +61,7 @@ export const createStorage = ({
 
       // bind auto-saving data changes to %storage-file.json
       reaction(() => toJS(storage.data), saveFile, {
-        delay: 250, // lazy, avoid excessive writes to fs
+        delay: saveDelay, // lazy, avoid excessive writes to fs
         equals: comparer.structural, // save only when something really changed
       });
 

src/renderer/utils/create-storage/storage-save-delay.injectable.ts

@@ -0,0 +1,12 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import { getInjectable } from "@ogre-tools/injectable";
+
+const storageSaveDelayInjectable = getInjectable({
+  id: "storage-save-delay",
+  instantiate: () => 250,
+});
+
+export default storageSaveDelayInjectable;

src/renderer/utils/create-storage/storages-are-ready.ts

@@ -0,0 +1,26 @@
+/**
+ * Copyright (c) OpenLens Authors. All rights reserved.
+ * Licensed under MIT License. See LICENSE in root directory for more information.
+ */
+import type { DiContainer } from "@ogre-tools/injectable";
+import type { CreateStorage } from "./create-storage";
+import createStorageInjectable from "./create-storage.injectable";
+
+export const controlWhenStoragesAreReady = (di: DiContainer) => {
+  const storagesAreReady: Promise<void>[] = [];
+
+  const decorated =
+        (toBeDecorated: CreateStorage) =>
+          (key: string, defaultValue: any) => {
+            const storage = toBeDecorated(key, defaultValue);
+
+            storagesAreReady.push(storage.whenReady);
+
+            return storage;
+          };
+
+  // TODO: Remove when typing is added to the library
+  (di as any).decorateFunction(createStorageInjectable, decorated);
+
+  return async () => void await Promise.all(storagesAreReady);
+};