From f3c34533087477706bd0124a49f3fd4baab79273 Mon Sep 17 00:00:00 2001 From: Jim Ehrismann Date: Fri, 5 Nov 2021 13:13:12 -0400 Subject: [PATCH] address review comment Signed-off-by: Jim Ehrismann --- .../components/+network-services/service-port-component.tsx | 6 +++--- .../components/+workloads-pods/pod-container-port.tsx | 6 +++--- src/renderer/port-forward/port-forward-dialog.tsx | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/renderer/components/+network-services/service-port-component.tsx b/src/renderer/components/+network-services/service-port-component.tsx index 78885b714c..301b21f1f3 100644 --- a/src/renderer/components/+network-services/service-port-component.tsx +++ b/src/renderer/components/+network-services/service-port-component.tsx @@ -92,10 +92,10 @@ export class ServicePortComponent extends React.Component { this.waiting = true; - // determine how many port-forwards are already active - const { length } = await getPortForwards(); - try { + // determine how many port-forwards are already active + const { length } = await getPortForwards(); + this.forwardPort = await addPortForward(portForward); if (this.forwardPort) { diff --git a/src/renderer/components/+workloads-pods/pod-container-port.tsx b/src/renderer/components/+workloads-pods/pod-container-port.tsx index e9bf322afb..c8beecc334 100644 --- a/src/renderer/components/+workloads-pods/pod-container-port.tsx +++ b/src/renderer/components/+workloads-pods/pod-container-port.tsx @@ -96,10 +96,10 @@ export class PodContainerPort extends React.Component { this.waiting = true; - // determine how many port-forwards are already active - const { length } = await getPortForwards(); - try { + // determine how many port-forwards are already active + const { length } = await getPortForwards(); + this.forwardPort = await addPortForward(portForward); if (this.forwardPort) { diff --git a/src/renderer/port-forward/port-forward-dialog.tsx b/src/renderer/port-forward/port-forward-dialog.tsx index 500f64a056..bacfff9fa0 100644 --- a/src/renderer/port-forward/port-forward-dialog.tsx +++ b/src/renderer/port-forward/port-forward-dialog.tsx @@ -95,10 +95,10 @@ export class PortForwardDialog extends Component { const { portForward } = this; const { currentPort, desiredPort, close } = this; - // determine how many port-forwards are already active - const { length } = await getPortForwards(); - try { + // determine how many port-forwards are already active + const { length } = await getPortForwards(); + let port: number; portForward.protocol = dialogState.useHttps ? "https" : "http";