hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

Fixing app crash when iterating Events without 'kind' prop defined (#743)

Browse Source 
* Checking for 'kind' to be defined
Inside 'involvedObject' of Event

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fixing resource var definition

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Reverting to link rendering in Events

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Explicitly return emty link if no 'kind' available

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Removing lowercase of url path

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2020-09-01 10:36:44 +03:00 committed by GitHub
parent 505a5c7d9f
commit f4d262b294
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/renderer/api/kube-api-parse.ts
View File

@ -121,6 +121,8 @@ export function lookupApiLink(ref: IKubeObjectRef, parentObject: KubeObject): st
namespace = parentObject.getNs() namespace = parentObject.getNs()
} = ref; } = ref;
if (!kind) return "";
// search in registered apis by 'kind' & 'apiVersion' // search in registered apis by 'kind' & 'apiVersion'
const api = apiManager.getApi(api => api.kind === kind && api.apiVersionWithGroup == apiVersion) const api = apiManager.getApi(api => api.kind === kind && api.apiVersionWithGroup == apiVersion)
if (api) { if (api) {
@ -129,7 +131,7 @@ export function lookupApiLink(ref: IKubeObjectRef, parentObject: KubeObject): st
// lookup api by generated resource link // lookup api by generated resource link
const apiPrefixes = ["/apis", "/api"]; const apiPrefixes = ["/apis", "/api"];
const resource = kind.toLowerCase() + kind.endsWith("s") ? "es" : "s"; const resource = kind.endsWith("s") ? `${kind.toLowerCase()}es` : `${kind.toLowerCase()}s`;
for (const apiPrefix of apiPrefixes) { for (const apiPrefix of apiPrefixes) {
const apiLink = createKubeApiURL({ apiPrefix, apiVersion, name, namespace, resource }); const apiLink = createKubeApiURL({ apiPrefix, apiVersion, name, namespace, resource });
if (apiManager.getApi(apiLink)) { if (apiManager.getApi(apiLink)) {

1
src/renderer/navigation.ts
View File

@ -69,6 +69,7 @@ export function getSelectedDetails() {
} }
export function getDetailsUrl(details: string) { export function getDetailsUrl(details: string) {
if (!details) return "";
return getQueryString({ return getQueryString({
details: details, details: details,
selected: getSelectedDetails(), selected: getSelectedDetails(),