From f56b48fea73a7e6623182f655b480fc4b162b7d0 Mon Sep 17 00:00:00 2001 From: Iku-turso Date: Tue, 21 Jun 2022 13:30:50 +0300 Subject: [PATCH] Extract minimal abstraction for specifically logging error instead of also warn, info, etc. Co-authored-by: Janne Savolainen Signed-off-by: Iku-turso --- src/common/log-error.injectable.ts | 13 +++++++++++++ .../with-error-logging.injectable.ts | 8 ++++---- 2 files changed, 17 insertions(+), 4 deletions(-) create mode 100644 src/common/log-error.injectable.ts diff --git a/src/common/log-error.injectable.ts b/src/common/log-error.injectable.ts new file mode 100644 index 0000000000..4fab2cd546 --- /dev/null +++ b/src/common/log-error.injectable.ts @@ -0,0 +1,13 @@ +/** + * Copyright (c) OpenLens Authors. All rights reserved. + * Licensed under MIT License. See LICENSE in root directory for more information. + */ +import { getInjectable } from "@ogre-tools/injectable"; +import loggerInjectable from "./logger.injectable"; + +const logErrorInjectable = getInjectable({ + id: "log-error", + instantiate: (di) => di.inject(loggerInjectable).error, +}); + +export default logErrorInjectable; diff --git a/src/common/utils/with-error-logging/with-error-logging.injectable.ts b/src/common/utils/with-error-logging/with-error-logging.injectable.ts index 12b48c6204..e184bfc247 100644 --- a/src/common/utils/with-error-logging/with-error-logging.injectable.ts +++ b/src/common/utils/with-error-logging/with-error-logging.injectable.ts @@ -3,8 +3,8 @@ * Licensed under MIT License. See LICENSE in root directory for more information. */ import { getInjectable } from "@ogre-tools/injectable"; -import loggerInjectable from "../../logger.injectable"; import { isPromise } from "../is-promise/is-promise"; +import logErrorInjectable from "../../log-error.injectable"; export type WithErrorLoggingFor = ( getErrorMessage: (error: unknown) => string @@ -16,7 +16,7 @@ const withErrorLoggingInjectable = getInjectable({ id: "with-error-logging", instantiate: (di): WithErrorLoggingFor => { - const logger = di.inject(loggerInjectable); + const logError = di.inject(logErrorInjectable); return (getErrorMessage) => (toBeDecorated) => @@ -28,7 +28,7 @@ const withErrorLoggingInjectable = getInjectable({ returnValue.catch((e) => { const errorMessage = getErrorMessage(e); - logger.error(errorMessage, e); + logError(errorMessage, e); }); } @@ -36,7 +36,7 @@ const withErrorLoggingInjectable = getInjectable({ } catch (e) { const errorMessage = getErrorMessage(e); - logger.error(errorMessage, e); + logError(errorMessage, e); throw e; }