1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00

Styling empty states a bit

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
This commit is contained in:
Alex Andreev 2022-01-10 14:21:46 +03:00
parent 2f1c81a0f5
commit f698a792e0
3 changed files with 31 additions and 7 deletions

View File

@ -0,0 +1,26 @@
/**
* Copyright (c) 2021 OpenLens Authors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy of
* this software and associated documentation files (the "Software"), to deal in
* the Software without restriction, including without limitation the rights to
* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
* the Software, and to permit persons to whom the Software is furnished to do so,
* subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
.noItems {
height: calc(100vh - 120px);
display: grid;
place-content: center;
}

View File

@ -19,10 +19,13 @@
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/ */
import styles from "./extension-settings-page.module.scss";
import React from "react"; import React from "react";
import { matchPath, RouteComponentProps } from "react-router"; import { matchPath, RouteComponentProps } from "react-router";
import { extensionSettingsRoute } from "../../../common/routes"; import { extensionSettingsRoute } from "../../../common/routes";
import { AppPreferenceRegistry } from "../../../extensions/registries"; import { AppPreferenceRegistry } from "../../../extensions/registries";
import { Icon } from "../icon";
import { ExtensionSettings } from "./extension-settings"; import { ExtensionSettings } from "./extension-settings";
interface Props extends RouteComponentProps<{ extensionId?: string }> { interface Props extends RouteComponentProps<{ extensionId?: string }> {
@ -37,7 +40,7 @@ export const ExtensionSettingsPage = (props: Props) => {
if (!match?.params.extensionId) { if (!match?.params.extensionId) {
return ( return (
<div>No extension id provided in URL</div> <div className={styles.noItems}><span><Icon material="info"/> No extension id provided in URL.</span></div>
); );
} }
@ -48,7 +51,7 @@ export const ExtensionSettingsPage = (props: Props) => {
const renderContent = () => { const renderContent = () => {
if (!currentSettings.length) { if (!currentSettings.length) {
return ( return (
<div>No settings found</div> <div className={styles.noItems}><span><Icon material="info"/> No settings found.</span></div>
); );
} }

View File

@ -27,8 +27,6 @@ import {
appRoute, appRoute,
appURL, appURL,
editorURL, editorURL,
extensionRoute,
extensionURL,
kubernetesRoute, kubernetesRoute,
kubernetesURL, kubernetesURL,
preferencesURL, preferencesURL,
@ -90,9 +88,6 @@ class Preferences extends React.Component<Dependencies> {
{(telemetryExtensions.length > 0 || !!sentryDsn) && {(telemetryExtensions.length > 0 || !!sentryDsn) &&
<Tab value={telemetryURL()} label="Telemetry" data-testid="telemetry-tab" active={isActive(telemetryRoute)}/> <Tab value={telemetryURL()} label="Telemetry" data-testid="telemetry-tab" active={isActive(telemetryRoute)}/>
} }
{preferenceRegistries.filter(e => !e.showInPreferencesTab).length > 0 &&
<Tab value={extensionURL()} label="Extensions" data-testid="extensions-tab" active={isActive(extensionRoute)}/>
}
{extensionsWithSettings.length > 0 && ( {extensionsWithSettings.length > 0 && (
<div data-testid="custom-settings"> <div data-testid="custom-settings">
<hr/> <hr/>