Trivial tweaks accidentally left from other PR (#5679)

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

src/extensions/extension-loader/extension-installation-counter.injectable.ts

@@ -1,12 +0,0 @@
-/**
- * Copyright (c) OpenLens Authors. All rights reserved.
- * Licensed under MIT License. See LICENSE in root directory for more information.
- */
-import { getInjectable } from "@ogre-tools/injectable";
-
-const extensionInstallationCounterInjectable = getInjectable({
-  id: "extension-installation-counter",
-  instantiate: () => new Map<string, number>(),
-});
-
-export default extensionInstallationCounterInjectable;

src/extensions/extension-loader/extension-loader.injectable.ts

@@ -5,7 +5,6 @@
 import { getInjectable } from "@ogre-tools/injectable";
 import { ExtensionLoader } from "./extension-loader";
 import updateExtensionsStateInjectable from "./update-extensions-state/update-extensions-state.injectable";
-import extensionInstallationCounterInjectable from "./extension-installation-counter.injectable";
 import { createExtensionInstanceInjectionToken } from "./create-extension-instance.token";
 import extensionInstancesInjectable from "./extension-instances.injectable";
 import type { LensExtension } from "../lens-extension";
@@ -17,7 +16,6 @@ const extensionLoaderInjectable = getInjectable({
   instantiate: (di) => new ExtensionLoader({
     updateExtensionsState: di.inject(updateExtensionsStateInjectable),
     createExtensionInstance: di.inject(createExtensionInstanceInjectionToken),
-    extensionInstallationCounter: di.inject(extensionInstallationCounterInjectable),
     extensionInstances: di.inject(extensionInstancesInjectable),
     getExtension: (instance: LensExtension) => di.inject(extensionInjectable, instance),
   }),

src/extensions/extension-loader/extension-loader.ts

@@ -30,7 +30,6 @@ const logModule = "[EXTENSIONS-LOADER]";
 interface Dependencies {
   updateExtensionsState: (extensionsState: Record<LensExtensionId, LensExtensionState>) => void;
   createExtensionInstance: CreateExtensionInstance;
-  readonly extensionInstallationCounter: Map<string, number>;
   readonly extensionInstances: ObservableMap<LensExtensionId, LensExtension>;
   getExtension: (instance: LensExtension) => Extension;
 }
@@ -171,9 +170,9 @@ export class ExtensionLoader {
     try {
       instance.disable();
 
-      const registeredExtension = this.dependencies.getExtension(instance);
+      const extension = this.dependencies.getExtension(instance);
 
-      registeredExtension.deregister();
+      extension.deregister();
 
       this.onRemoveExtensionId.emit(instance.id);
       this.dependencies.extensionInstances.delete(lensExtensionId);
@@ -360,9 +359,9 @@ export class ExtensionLoader {
     );
 
     extensions.forEach(({ instance }) => {
-      const getExtension = this.dependencies.getExtension(instance);
+      const extension = this.dependencies.getExtension(instance);
 
-      getExtension.register();
+      extension.register();
     });
 
     // Return ExtensionLoading[]

src/extensions/extension-loader/extension/extension.injectable.ts

@@ -43,7 +43,7 @@ const extensionInjectable = getInjectable({
   },
 
   lifecycle: lifecycleEnum.keyedSingleton({
-    getInstanceKey: (di, extension: LensExtension) => extension,
+    getInstanceKey: (di, instance: LensExtension) => instance,
   }),
 });