hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity

actual fix

Browse Source 
Signed-off-by: Roman <ixrock@gmail.com>
This commit is contained in:
Roman 2020-09-10 17:16:24 +03:00
parent e212fc364a
commit fa93618234
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/renderer/components/cluster-manager/lens-views.ts
View File

@ -25,10 +25,10 @@ export async function initView(clusterId: ClusterId) {
const iframe = document.createElement("iframe"); const iframe = document.createElement("iframe");
iframe.name = cluster.contextName; iframe.name = cluster.contextName;
iframe.setAttribute("src", getClusterFrameUrl(clusterId)) iframe.setAttribute("src", getClusterFrameUrl(clusterId))
iframe.addEventListener("load", async () => { iframe.addEventListener("load", () => {
logger.info(`[LENS-VIEW]: loaded from ${iframe.src}`) logger.info(`[LENS-VIEW]: loaded from ${iframe.src}`)
lensViews.get(clusterId).isLoaded = true; lensViews.get(clusterId).isLoaded = true;
}) }, { once: true });
lensViews.set(clusterId, { clusterId, view: iframe }); lensViews.set(clusterId, { clusterId, view: iframe });
parentElem.appendChild(iframe); parentElem.appendChild(iframe);
await autoCleanOnRemove(clusterId, iframe); await autoCleanOnRemove(clusterId, iframe);
@ -37,8 +37,14 @@ export async function initView(clusterId: ClusterId) {
export async function autoCleanOnRemove(clusterId: ClusterId, iframe: HTMLIFrameElement) { export async function autoCleanOnRemove(clusterId: ClusterId, iframe: HTMLIFrameElement) {
await when(() => !clusterStore.getById(clusterId)); await when(() => !clusterStore.getById(clusterId));
logger.info(`[LENS-VIEW]: remove dashboard, clusterId=${clusterId}`) logger.info(`[LENS-VIEW]: remove dashboard, clusterId=${clusterId}`)
iframe.parentElement.removeChild(iframe);
lensViews.delete(clusterId) lensViews.delete(clusterId)
// Keep frame in DOM to avoid possible bugs when same cluster re-created after being removed.
// In that case for some reasons `webFrame.routingId` returns some previous frameId (usage in app.tsx)
// Issue: https://github.com/lensapp/lens/issues/811
iframe.dataset.meta = `${iframe.name} was removed at ${new Date().toLocaleString()}`;
iframe.removeAttribute("src")
iframe.removeAttribute("name")
} }
export function refreshViews() { export function refreshViews() {