From ff93760dc4c6394c86b244de9871ac5c6986733b Mon Sep 17 00:00:00 2001 From: Panu Horsmalahti Date: Tue, 24 Nov 2020 13:16:35 +0200 Subject: [PATCH] Enable object-shorthand rule (#1500) Signed-off-by: Panu Horsmalahti --- .eslintrc.js | 3 +++ src/common/cluster-store.ts | 2 +- src/common/user-store.ts | 2 +- src/extensions/lens-main-extension.ts | 2 +- src/extensions/lens-renderer-extension.ts | 2 +- src/main/cluster-detectors/cluster-id-detector.ts | 2 +- src/main/context-handler.ts | 2 +- src/main/helm/helm-cli.ts | 2 +- src/main/helm/helm-release-manager.ts | 2 +- src/main/router.ts | 8 ++++---- src/main/routes/port-forward-route.ts | 6 +++--- src/main/shell-session.ts | 2 +- src/main/window-manager.ts | 2 +- src/migrations/cluster-store/2.6.0-beta.3.ts | 2 +- src/renderer/api/endpoints/cluster.api.ts | 2 +- src/renderer/api/endpoints/deployment.api.ts | 2 +- src/renderer/api/endpoints/helm-releases.api.ts | 2 +- src/renderer/api/json-api.ts | 4 ++-- src/renderer/api/kube-api.ts | 6 +++--- src/renderer/components/+add-cluster/add-cluster.tsx | 2 +- .../components/+apps-helm-charts/helm-chart.store.ts | 2 +- src/renderer/components/+cluster/cluster-metrics.tsx | 2 +- .../components/+config-secrets/add-secret-dialog.tsx | 6 +++--- src/renderer/components/+namespaces/namespace.store.ts | 2 +- .../add-role-binding-dialog.tsx | 2 +- .../service-accounts-details.tsx | 2 +- src/renderer/components/app.tsx | 2 +- src/renderer/components/checkbox/checkbox.tsx | 2 +- src/renderer/components/dock/edit-resource.tsx | 2 +- src/renderer/components/input/file-input.tsx | 2 +- src/renderer/components/input/input.tsx | 10 +++++----- src/renderer/components/menu/menu-actions.tsx | 2 +- .../components/notifications/notifications.tsx | 6 +++--- src/renderer/components/radio/radio.tsx | 6 +++--- src/renderer/components/table/table-cell.tsx | 2 +- src/renderer/components/table/table.tsx | 2 +- src/renderer/components/tabs/tabs.tsx | 10 +++++----- src/renderer/components/tooltip/tooltip.tsx | 4 ++-- src/renderer/kube-object.store.ts | 2 +- src/renderer/navigation.ts | 2 +- src/renderer/utils/downloadFile.ts | 2 +- src/renderer/utils/interval.ts | 6 +++--- 42 files changed, 69 insertions(+), 66 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 5a377b06e0..913d959a97 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -26,6 +26,7 @@ module.exports = { }], "no-unused-vars": "off", "semi": ["error", "always"], + "object-shorthand": "error", } }, { @@ -58,6 +59,7 @@ module.exports = { }], "semi": "off", "@typescript-eslint/semi": ["error"], + "object-shorthand": "error", }, }, { @@ -90,6 +92,7 @@ module.exports = { }], "semi": "off", "@typescript-eslint/semi": ["error"], + "object-shorthand": "error", }, } ] diff --git a/src/common/cluster-store.ts b/src/common/cluster-store.ts index 4a5f358571..907f9b7aad 100644 --- a/src/common/cluster-store.ts +++ b/src/common/cluster-store.ts @@ -84,7 +84,7 @@ export class ClusterStore extends BaseStore { super({ configName: "lens-cluster-store", accessPropertiesByDotNotation: false, // To make dots safe in cluster context names - migrations: migrations, + migrations, }); this.pushStateToViewsAutomatically(); diff --git a/src/common/user-store.ts b/src/common/user-store.ts index c1eba70a43..2de6bcba6d 100644 --- a/src/common/user-store.ts +++ b/src/common/user-store.ts @@ -36,7 +36,7 @@ export class UserStore extends BaseStore { private constructor() { super({ // configName: "lens-user-store", // todo: migrate from default "config.json" - migrations: migrations, + migrations, }); this.handleOnLoad(); diff --git a/src/extensions/lens-main-extension.ts b/src/extensions/lens-main-extension.ts index b425c5bf46..bdea1506e8 100644 --- a/src/extensions/lens-main-extension.ts +++ b/src/extensions/lens-main-extension.ts @@ -11,7 +11,7 @@ export class LensMainExtension extends LensExtension { const windowManager = WindowManager.getInstance(); const pageUrl = getExtensionPageUrl({ extensionId: this.name, - pageId: pageId, + pageId, params: params ?? {}, // compile to url with params }); await windowManager.navigate(pageUrl, frameId); diff --git a/src/extensions/lens-renderer-extension.ts b/src/extensions/lens-renderer-extension.ts index 56ed90684f..c1769f0953 100644 --- a/src/extensions/lens-renderer-extension.ts +++ b/src/extensions/lens-renderer-extension.ts @@ -19,7 +19,7 @@ export class LensRendererExtension extends LensExtension { const { navigate } = await import("../renderer/navigation"); const pageUrl = getExtensionPageUrl({ extensionId: this.name, - pageId: pageId, + pageId, params: params ?? {}, // compile to url with params }); navigate(pageUrl); diff --git a/src/main/cluster-detectors/cluster-id-detector.ts b/src/main/cluster-detectors/cluster-id-detector.ts index 8419ae9db4..2605ca269f 100644 --- a/src/main/cluster-detectors/cluster-id-detector.ts +++ b/src/main/cluster-detectors/cluster-id-detector.ts @@ -13,7 +13,7 @@ export class ClusterIdDetector extends BaseClusterDetector { id = this.cluster.apiUrl; } const value = createHash("sha256").update(id).digest("hex"); - return { value: value, accuracy: 100 }; + return { value, accuracy: 100 }; } protected async getDefaultNamespaceId() { diff --git a/src/main/context-handler.ts b/src/main/context-handler.ts index 10f84ced6d..a1ef58ad0f 100644 --- a/src/main/context-handler.ts +++ b/src/main/context-handler.ts @@ -91,7 +91,7 @@ export class ContextHandler { return { target: proxyUrl, changeOrigin: true, - timeout: timeout, + timeout, headers: { "Host": this.clusterUrl.hostname, }, diff --git a/src/main/helm/helm-cli.ts b/src/main/helm/helm-cli.ts index 34a3becc33..c06386a1a8 100644 --- a/src/main/helm/helm-cli.ts +++ b/src/main/helm/helm-cli.ts @@ -8,7 +8,7 @@ export class HelmCli extends LensBinary { public constructor(baseDir: string, version: string) { const opts: LensBinaryOpts = { version, - baseDir: baseDir, + baseDir, originalBinaryName: "helm", newBinaryName: "helm3" }; diff --git a/src/main/helm/helm-release-manager.ts b/src/main/helm/helm-release-manager.ts index 3a8b4707ba..e468cdaef7 100644 --- a/src/main/helm/helm-release-manager.ts +++ b/src/main/helm/helm-release-manager.ts @@ -40,7 +40,7 @@ export class HelmReleaseManager { log: stdout, release: { name: releaseName, - namespace: namespace + namespace } }; } finally { diff --git a/src/main/router.ts b/src/main/router.ts index ed072836b9..a386ef221b 100644 --- a/src/main/router.ts +++ b/src/main/router.ts @@ -67,15 +67,15 @@ export class Router { output: "data", }); return { - cluster: cluster, + cluster, path: url.pathname, raw: { - req: req, + req, }, response: res, query: url.searchParams, - payload: payload, - params: params + payload, + params }; } diff --git a/src/main/routes/port-forward-route.ts b/src/main/routes/port-forward-route.ts index 55402ff72f..967783aa3f 100644 --- a/src/main/routes/port-forward-route.ts +++ b/src/main/routes/port-forward-route.ts @@ -78,16 +78,16 @@ class PortForwardRoute extends LensApi { let portForward = PortForward.getPortforward({ clusterId: cluster.id, kind: resourceType, name: resourceName, - namespace: namespace, port: port + namespace, port }); if (!portForward) { logger.info(`Creating a new port-forward ${namespace}/${resourceType}/${resourceName}:${port}`); portForward = new PortForward({ clusterId: cluster.id, kind: resourceType, - namespace: namespace, + namespace, name: resourceName, - port: port, + port, kubeConfig: cluster.getProxyKubeconfigPath() }); const started = await portForward.start(); diff --git a/src/main/shell-session.ts b/src/main/shell-session.ts index 23a163b341..3614abe28f 100644 --- a/src/main/shell-session.ts +++ b/src/main/shell-session.ts @@ -47,7 +47,7 @@ export class ShellSession extends EventEmitter { this.shellProcess = pty.spawn(shell, args, { cols: 80, cwd: this.cwd() || env.HOME, - env: env, + env, name: "xterm-256color", rows: 30, }); diff --git a/src/main/window-manager.ts b/src/main/window-manager.ts index 00fbdd4243..1fa2614c50 100644 --- a/src/main/window-manager.ts +++ b/src/main/window-manager.ts @@ -124,7 +124,7 @@ export class WindowManager extends Singleton { await this.ensureMainWindow(); this.sendToView({ channel: "renderer:navigate", - frameId: frameId, + frameId, data: [url], }); } diff --git a/src/migrations/cluster-store/2.6.0-beta.3.ts b/src/migrations/cluster-store/2.6.0-beta.3.ts index 7f17440e60..eae6a137be 100644 --- a/src/migrations/cluster-store/2.6.0-beta.3.ts +++ b/src/migrations/cluster-store/2.6.0-beta.3.ts @@ -26,7 +26,7 @@ export default migration({ user["auth-provider"].config = authConfig; kubeConfig.users = [{ name: userObj.name, - user: user + user }]; cluster.kubeConfig = yaml.safeDump(kubeConfig); store.set(clusterKey, cluster); diff --git a/src/renderer/api/endpoints/cluster.api.ts b/src/renderer/api/endpoints/cluster.api.ts index 43783e1c00..d3017c691a 100644 --- a/src/renderer/api/endpoints/cluster.api.ts +++ b/src/renderer/api/endpoints/cluster.api.ts @@ -8,7 +8,7 @@ export class ClusterApi extends KubeApi { async getMetrics(nodeNames: string[], params?: IMetricsReqParams): Promise { const nodes = nodeNames.join("|"); - const opts = { category: "cluster", nodes: nodes }; + const opts = { category: "cluster", nodes }; return metricsApi.getMetrics({ memoryUsage: opts, diff --git a/src/renderer/api/endpoints/deployment.api.ts b/src/renderer/api/endpoints/deployment.api.ts index 28ed71f86a..0279d63ed1 100644 --- a/src/renderer/api/endpoints/deployment.api.ts +++ b/src/renderer/api/endpoints/deployment.api.ts @@ -20,7 +20,7 @@ export class DeploymentApi extends KubeApi { data: { metadata: params, spec: { - replicas: replicas + replicas } } }); diff --git a/src/renderer/api/endpoints/helm-releases.api.ts b/src/renderer/api/endpoints/helm-releases.api.ts index 0ddbf1c734..1969919e6c 100644 --- a/src/renderer/api/endpoints/helm-releases.api.ts +++ b/src/renderer/api/endpoints/helm-releases.api.ts @@ -119,7 +119,7 @@ export const helmReleasesApi = { const path = endpoint({ name, namespace }) + "/rollback"; return apiBase.put(path, { data: { - revision: revision + revision } }); } diff --git a/src/renderer/api/json-api.ts b/src/renderer/api/json-api.ts index cc239a804e..8d30f08a57 100644 --- a/src/renderer/api/json-api.ts +++ b/src/renderer/api/json-api.ts @@ -84,8 +84,8 @@ export class JsonApi { } const infoLog: JsonApiLog = { method: reqInit.method.toUpperCase(), - reqUrl: reqUrl, - reqInit: reqInit, + reqUrl, + reqInit, }; return cancelableFetch(reqUrl, reqInit).then(res => { return this.parseResponse(res, infoLog); diff --git a/src/renderer/api/kube-api.ts b/src/renderer/api/kube-api.ts index 0a0d153e18..7350bfc729 100644 --- a/src/renderer/api/kube-api.ts +++ b/src/renderer/api/kube-api.ts @@ -73,7 +73,7 @@ export function forCluster(cluster: IKubeApiCluster, kubeC }); return new KubeApi({ objectConstructor: kubeClass, - request: request + request }); } @@ -228,7 +228,7 @@ export class KubeApi { apiVersion: this.apiVersionWithGroup, resource: this.apiResource, namespace: this.isNamespaced ? namespace : undefined, - name: name, + name, }); return resourcePath + (query ? `?` + stringify(this.normalizeQuery(query)) : ""); } @@ -256,7 +256,7 @@ export class KubeApi { this.setResourceVersion("", metadata.resourceVersion); return items.map(item => new KubeObjectConstructor({ kind: this.kind, - apiVersion: apiVersion, + apiVersion, ...item, })); } diff --git a/src/renderer/components/+add-cluster/add-cluster.tsx b/src/renderer/components/+add-cluster/add-cluster.tsx index 3639ac968c..57f84d45ac 100644 --- a/src/renderer/components/+add-cluster/add-cluster.tsx +++ b/src/renderer/components/+add-cluster/add-cluster.tsx @@ -152,7 +152,7 @@ export class AddCluster extends React.Component { : ClusterStore.embedCustomKubeConfig(clusterId, kubeConfig); // save in app-files folder return { id: clusterId, - kubeConfigPath: kubeConfigPath, + kubeConfigPath, workspace: workspaceStore.currentWorkspaceId, contextName: kubeConfig.currentContext, preferences: { diff --git a/src/renderer/components/+apps-helm-charts/helm-chart.store.ts b/src/renderer/components/+apps-helm-charts/helm-chart.store.ts index 65e73b556f..5ebc264224 100644 --- a/src/renderer/components/+apps-helm-charts/helm-chart.store.ts +++ b/src/renderer/components/+apps-helm-charts/helm-chart.store.ts @@ -36,7 +36,7 @@ export class HelmChartStore extends ItemStore { const loadVersions = (repo: string) => { return helmChartsApi.get(repo, chartName).then(({ versions }) => { return versions.map(chart => ({ - repo: repo, + repo, version: chart.getVersion() })); }); diff --git a/src/renderer/components/+cluster/cluster-metrics.tsx b/src/renderer/components/+cluster/cluster-metrics.tsx index 12973b1514..fecddde7e6 100644 --- a/src/renderer/components/+cluster/cluster-metrics.tsx +++ b/src/renderer/components/+cluster/cluster-metrics.tsx @@ -27,7 +27,7 @@ export const ClusterMetrics = observer(() => { id: metricType + metricNodeRole, label: metricType.toUpperCase() + " usage", borderColor: colors[metricType], - data: data + data }]; const cpuOptions: ChartOptions = { scales: { diff --git a/src/renderer/components/+config-secrets/add-secret-dialog.tsx b/src/renderer/components/+config-secrets/add-secret-dialog.tsx index 8519be5bda..339f418d65 100644 --- a/src/renderer/components/+config-secrets/add-secret-dialog.tsx +++ b/src/renderer/components/+config-secrets/add-secret-dialog.tsx @@ -92,11 +92,11 @@ export class AddSecretDialog extends React.Component { const { name, namespace, type } = this; const { data = [], labels = [], annotations = [] } = this.secret[type]; const secret: Partial = { - type: type, + type, data: this.getDataFromFields(data, val => val ? base64.encode(val) : ""), metadata: { - name: name, - namespace: namespace, + name, + namespace, annotations: this.getDataFromFields(annotations), labels: this.getDataFromFields(labels), } as IKubeObjectMetadata diff --git a/src/renderer/components/+namespaces/namespace.store.ts b/src/renderer/components/+namespaces/namespace.store.ts index dabde6b47d..d754c78ed0 100644 --- a/src/renderer/components/+namespaces/namespace.store.ts +++ b/src/renderer/components/+namespaces/namespace.store.ts @@ -60,7 +60,7 @@ export class NamespaceStore extends KubeObjectStore { kind: "Namespace", apiVersion: "v1", metadata: { - name: name, + name, uid: "", resourceVersion: "", selfLink: `/api/v1/namespaces/${name}` diff --git a/src/renderer/components/+user-management-roles-bindings/add-role-binding-dialog.tsx b/src/renderer/components/+user-management-roles-bindings/add-role-binding-dialog.tsx index 227b2d936e..ddc4cf2160 100644 --- a/src/renderer/components/+user-management-roles-bindings/add-role-binding-dialog.tsx +++ b/src/renderer/components/+user-management-roles-bindings/add-role-binding-dialog.tsx @@ -137,7 +137,7 @@ export class AddRoleBindingDialog extends React.Component { else { const name = useRoleForBindingName ? selectedRole.getName() : bindingName; roleBinding = await roleBindingsStore.create({ name, namespace }, { - subjects: subjects, + subjects, roleRef: { name: selectedRole.getName(), kind: selectedRole.kind, diff --git a/src/renderer/components/+user-management-service-accounts/service-accounts-details.tsx b/src/renderer/components/+user-management-service-accounts/service-accounts-details.tsx index d560cd9199..70aea97d00 100644 --- a/src/renderer/components/+user-management-service-accounts/service-accounts-details.tsx +++ b/src/renderer/components/+user-management-service-accounts/service-accounts-details.tsx @@ -88,7 +88,7 @@ export class ServiceAccountsDetails extends React.Component { apiVersion: "v1", kind: "Secret", metadata: { - name: name, + name, uid: null, selfLink: null, resourceVersion: null diff --git a/src/renderer/components/app.tsx b/src/renderer/components/app.tsx index fb7d4a7df0..2be6949411 100755 --- a/src/renderer/components/app.tsx +++ b/src/renderer/components/app.tsx @@ -59,7 +59,7 @@ export class App extends React.Component { name: "cluster", action: "open", params: { - clusterId: clusterId + clusterId } }); window.addEventListener("online", () => { diff --git a/src/renderer/components/checkbox/checkbox.tsx b/src/renderer/components/checkbox/checkbox.tsx index 5d2eeafc89..2efa6adc6f 100644 --- a/src/renderer/components/checkbox/checkbox.tsx +++ b/src/renderer/components/checkbox/checkbox.tsx @@ -30,7 +30,7 @@ export class Checkbox extends React.PureComponent { render() { const { label, inline, className, value, theme, children, ...inputProps } = this.props; const componentClass = cssNames('Checkbox flex', className, { - inline: inline, + inline, checked: value, disabled: this.props.disabled, ["theme-" + theme]: theme, diff --git a/src/renderer/components/dock/edit-resource.tsx b/src/renderer/components/dock/edit-resource.tsx index 471a6aa75c..478192b35a 100644 --- a/src/renderer/components/dock/edit-resource.tsx +++ b/src/renderer/components/dock/edit-resource.tsx @@ -55,7 +55,7 @@ export class EditResource extends React.Component { } editResourceStore.setData(this.tabId, { ...this.tabData, - draft: draft, + draft, }); } diff --git a/src/renderer/components/input/file-input.tsx b/src/renderer/components/input/file-input.tsx index 1293163797..f4d83bce14 100644 --- a/src/renderer/components/input/file-input.tsx +++ b/src/renderer/components/input/file-input.tsx @@ -38,7 +38,7 @@ export class FileInput extends React.Component { const reader = new FileReader(); reader.onloadend = () => { resolve({ - file: file, + file, data: reader.result, error: reader.error ? String(reader.error) : null, }); diff --git a/src/renderer/components/input/input.tsx b/src/renderer/components/input/input.tsx index 78dc1ebba5..1b4f575b26 100644 --- a/src/renderer/components/input/input.tsx +++ b/src/renderer/components/input/input.tsx @@ -149,7 +149,7 @@ export class Input extends React.Component { this.setState({ validating: false, valid: !errors.length, - errors: errors, + errors, }); } @@ -273,11 +273,11 @@ export class Input extends React.Component { const className = cssNames("Input", this.props.className, { [`theme ${theme}`]: theme, - focused: focused, - disabled: disabled, + focused, + disabled, invalid: !valid, - dirty: dirty, - validating: validating, + dirty, + validating, validatingLine: validating && showValidationLine, }); diff --git a/src/renderer/components/menu/menu-actions.tsx b/src/renderer/components/menu/menu-actions.tsx index 9f6908d1e9..39b0ce46ea 100644 --- a/src/renderer/components/menu/menu-actions.tsx +++ b/src/renderer/components/menu/menu-actions.tsx @@ -81,7 +81,7 @@ export class MenuActions extends React.Component { ...menuProps } = this.props; const menuClassName = cssNames("MenuActions flex", className, { - toolbar: toolbar, + toolbar, gaps: toolbar, // add spacing for .flex }); const autoClose = !toolbar; diff --git a/src/renderer/components/notifications/notifications.tsx b/src/renderer/components/notifications/notifications.tsx index 44d6a90db0..4667b69f30 100644 --- a/src/renderer/components/notifications/notifications.tsx +++ b/src/renderer/components/notifications/notifications.tsx @@ -15,7 +15,7 @@ export class Notifications extends React.Component { static ok(message: NotificationMessage) { notificationsStore.add({ - message: message, + message, timeout: 2500, status: NotificationStatus.OK }); @@ -23,7 +23,7 @@ export class Notifications extends React.Component { static error(message: NotificationMessage) { notificationsStore.add({ - message: message, + message, timeout: 10000, status: NotificationStatus.ERROR }); @@ -33,7 +33,7 @@ export class Notifications extends React.Component { return notificationsStore.add({ status: NotificationStatus.INFO, timeout: 0, - message: message, + message, ...customOpts, }); } diff --git a/src/renderer/components/radio/radio.tsx b/src/renderer/components/radio/radio.tsx index 6153cb5b09..671248ba0c 100644 --- a/src/renderer/components/radio/radio.tsx +++ b/src/renderer/components/radio/radio.tsx @@ -24,10 +24,10 @@ export class RadioGroup extends React.Component {
{radios.map(radio => { return React.cloneElement(radio, { - name: name, + name, disabled: disabled !== undefined ? disabled : radio.props.disabled, checked: radio.props.value === value, - onChange: onChange + onChange } as any); })}
@@ -66,7 +66,7 @@ export class Radio extends React.Component { render() { const { className, label, checked, children, ...inputProps } = this.props; const componentClass = cssNames('Radio flex align-center', className, { - checked: checked, + checked, disabled: this.props.disabled, }); return ( diff --git a/src/renderer/components/table/table-cell.tsx b/src/renderer/components/table/table-cell.tsx index 4264434093..bc3696a5b3 100644 --- a/src/renderer/components/table/table-cell.tsx +++ b/src/renderer/components/table/table-cell.tsx @@ -60,7 +60,7 @@ export class TableCell extends React.Component { render() { const { className, checkbox, isChecked, sortBy, _sort, _sorting, _nowrap, children, title, renderBoolean: displayBoolean, ...cellProps } = this.props; const classNames = cssNames("TableCell", className, { - checkbox: checkbox, + checkbox, nowrap: _nowrap, sorting: this.isSortable, }); diff --git a/src/renderer/components/table/table.tsx b/src/renderer/components/table/table.tsx index 0822beee8d..78450b10a2 100644 --- a/src/renderer/components/table/table.tsx +++ b/src/renderer/components/table/table.tsx @@ -82,7 +82,7 @@ export class Table extends React.Component { typeof elem.props.children === "string" ? elem.props.children : undefined ); return React.cloneElement(elem, { - title: title, + title, _sort: this.sort, _sorting: this.sortParams, _nowrap: headElem.props.nowrap, diff --git a/src/renderer/components/tabs/tabs.tsx b/src/renderer/components/tabs/tabs.tsx index 027631ed3d..71ef27a098 100644 --- a/src/renderer/components/tabs/tabs.tsx +++ b/src/renderer/components/tabs/tabs.tsx @@ -32,10 +32,10 @@ export class Tabs extends React.PureComponent { render() { const { center, wrap, onChange, value, autoFocus, scrollable = true, withBorder, ...elemProps } = this.props; const className = cssNames("Tabs", this.props.className, { - center: center, - wrap: wrap, - scrollable: scrollable, - withBorder: withBorder, + center, + wrap, + scrollable, + withBorder, }); return ( @@ -120,7 +120,7 @@ export class Tab extends React.PureComponent { let { className } = this.props; className = cssNames("Tab flex gaps align-center", className, { "active": this.isActive, - "disabled": disabled, + disabled, }); return (
{ break; } return { - left: left, - top: top, + left, + top, right: left + tooltipBounds.width, bottom: top + tooltipBounds.height, }; diff --git a/src/renderer/kube-object.store.ts b/src/renderer/kube-object.store.ts index 1a6d0e5470..80995559c6 100644 --- a/src/renderer/kube-object.store.ts +++ b/src/renderer/kube-object.store.ts @@ -146,7 +146,7 @@ export abstract class KubeObjectStore extends ItemSt protected bindWatchEventsUpdater(delay = 1000) { return reaction(() => this.eventsBuffer.toJS()[0], this.updateFromEventsBuffer, { - delay: delay + delay }); } diff --git a/src/renderer/navigation.ts b/src/renderer/navigation.ts index 8a9416b39c..eee1f5dfaa 100644 --- a/src/renderer/navigation.ts +++ b/src/renderer/navigation.ts @@ -67,7 +67,7 @@ export function getSelectedDetails() { export function getDetailsUrl(details: string) { if (!details) return ""; return getQueryString({ - details: details, + details, selected: getSelectedDetails(), }); } diff --git a/src/renderer/utils/downloadFile.ts b/src/renderer/utils/downloadFile.ts index 6a8b7e55e5..2eab03e467 100644 --- a/src/renderer/utils/downloadFile.ts +++ b/src/renderer/utils/downloadFile.ts @@ -1,5 +1,5 @@ export function downloadFile(filename: string, contents: any, type: string) { - const data = new Blob([contents], { type: type }); + const data = new Blob([contents], { type }); const url = URL.createObjectURL(data); const link = document.createElement("a"); link.href = url; diff --git a/src/renderer/utils/interval.ts b/src/renderer/utils/interval.ts index 37bfc7200d..a2dba715a2 100644 --- a/src/renderer/utils/interval.ts +++ b/src/renderer/utils/interval.ts @@ -7,19 +7,19 @@ export function interval(timeSec = 1, callback: IntervalCallback, autoRun = fals let timer = -1; let isRunning = false; const intervalManager = { - start: function (runImmediately = false) { + start (runImmediately = false) { if (isRunning) return; const tick = () => callback(++count); isRunning = true; timer = window.setInterval(tick, 1000 * timeSec); if (runImmediately) tick(); }, - stop: function () { + stop () { count = 0; isRunning = false; clearInterval(timer); }, - restart: function (runImmediately = false) { + restart (runImmediately = false) { this.stop(); this.start(runImmediately); },