1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Commit Graph

2552 Commits

Author SHA1 Message Date
Janne Savolainen
cf052b9070
Deprecate some globals
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:29 +03:00
Janne Savolainen
8d2639532b
Abstract command line arguments to make them overridable in tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:29 +03:00
Janne Savolainen
605ab0683a
Consolidate all setupping related to single feature to same runnable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:29 +03:00
Janne Savolainen
1e4a140a55
Make temporal dependency apparent
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:28 +03:00
Iku-turso
c9832a2702
Extract "isIntegrationTesting" as dependency for having a side-effect
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:28 +03:00
Iku-turso
9b48478c2d
Make startable-stoppable also restartable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:28 +03:00
Iku-turso
bcf1a2aaf0
Bump async-fn
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:28 +03:00
Iku-turso
fa80d9b6be
Make running of many delegatees able to be hierarchical
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:25:28 +03:00
Janne Savolainen
672e96ee64
Override dependency for causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:28 +03:00
Janne Savolainen
b76ff351ac
Abstract even more Electron specifics to make them overridable in unit tests
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:25:26 +03:00
Janne Savolainen
068f9f67da
Introduce more abstractions for electron
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:24:22 +03:00
Janne Savolainen
bace3c84d7
Introduce abstractions for electron application events
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:24:21 +03:00
Iku-turso
f2d52066f3
Consolidate more startables and stoppables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:21 +03:00
Iku-turso
960d76b0f5
Consolidate naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:21 +03:00
Iku-turso
cd811cc1f2
Consolidate implementation of something startable and stoppable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:21 +03:00
Iku-turso
0650d345c7
Introduce function to remove duplication from things that are startable and stoppable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:21 +03:00
Iku-turso
d915b2377a
Consolidate event naming
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:21 +03:00
Iku-turso
7f54ef5a35
Move directories for timing windows among peers
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:20 +03:00
Iku-turso
81eeb33e81
Consolidate naming of event timing window
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:20 +03:00
Iku-turso
e991b22781
Extract implementation for intent over technical phenomena (here electron events)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-05-11 08:24:20 +03:00
Janne Savolainen
abee24ce8b
Remove recently reimplemented stuff from index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:24:18 +03:00
Janne Savolainen
4eb4edaed9
Remove multiple usages of shared global state
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:20:38 +03:00
Janne Savolainen
8204dc5a9a
Reimplement setup for root frame using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:20:38 +03:00
Janne Savolainen
e15be51557
Reimplement setup for deep linking using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:20:37 +03:00
Janne Savolainen
ca6ab58459
Reimplement setup for application tray using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:20:35 +03:00
Janne Savolainen
9d193c672f
Reimplement setup for after application is ready using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:36 +03:00
Janne Savolainen
00325229f4
Reimplement setup for application quit using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:36 +03:00
Janne Savolainen
9b5bbb99f9
Reimplement setup for main window visibility using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:36 +03:00
Janne Savolainen
0bbc97e166
Reimplement setup for system shutdown using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:36 +03:00
Janne Savolainen
2e6d54e3f9
Reimplement setup for system certifications using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:36 +03:00
Janne Savolainen
65d6ce4630
Reimplement setup for application proxy using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:35 +03:00
Janne Savolainen
32f4c961fc
Reimplement setup for MobX strictness using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:35 +03:00
Janne Savolainen
0276078d1f
Reimplement setup for immer using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:35 +03:00
Janne Savolainen
74f8d7462e
Reimplement setup for electron application name using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:35 +03:00
Janne Savolainen
9c3c075887
Reimplement setup for application menu using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:35 +03:00
Janne Savolainen
9a7741f7cd
Reimplement setup for catalog syncing using runnables instead of non-OCP in index.ts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:35 +03:00
Janne Savolainen
0d3728dba3
Consolidate setup events to more granular timeslots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:34 +03:00
Janne Savolainen
6fe0c2fce5
Introduce tokens for runnables of specific application events for Open Closed Principle
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:34 +03:00
Janne Savolainen
bc0b342602
Simplify late registrations
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:34 +03:00
Janne Savolainen
a85f2fc206
Adapt injectable to auto register using a plugin instead of internal feature that no longer exists
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:34 +03:00
Janne Savolainen
df646b3fd8
Flag injectable causing side effects
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:34 +03:00
Janne Savolainen
18abef67bb
Consolidate loading of extensions to injectable instead of setup-code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:34 +03:00
Janne Savolainen
5c31203e50
Deprecate vars in favor of injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:33 +03:00
Janne Savolainen
f1e0fd081d
Introduce concept of runnable as a way to delegate runs to Open Closed Principle compliant runnables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:33 +03:00
Janne Savolainen
3e64b6bad5
Update injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:33 +03:00
Janne Savolainen
c441ad1496
Adapt to typing changes in injectable
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:33 +03:00
Janne Savolainen
71f74de570
Switch to running injection token based setups over legacy DI setups in application roots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:33 +03:00
Janne Savolainen
d5ab2ab000
Consolidate naming for running setups
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:33 +03:00
Janne Savolainen
cf87bc14d9
Switch to running injection token based setups over legacy DI setups in unit tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:32 +03:00
Janne Savolainen
4d79d25b6e
Stop running setups in unit tests without need
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-05-11 08:18:32 +03:00