Commit Graph
34 Commits
Author SHA1 Message Date
Panu Horsmalahti 1a29759bff Enable consistent-type-imports eslint rule (#5205) 2022-04-06 10:34:16 -04:00
Iku-turso 6b28f9e9c3 Bump injectable to 5.1.2 (#5010) 2022-03-17 08:15:21 -04:00
Sebastian Malton a19f094a0d Consolidate downloading binaries into one script (#4942)
* Consolidate downloading binaries into one script

- Upgrade lens-k8s-proxy to 0.1.5 which allows us to remove the trailing
  slash in KubeAuthProxy

- Consolidate nromalizing arch and os strings

- Remove LensBinary as HelmCli is not just a raw object since it is
  always bundled

- Introduce OnceCell and use it for the binary paths

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fully remove helmCli, move associated variable to vars

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix helm downloading on windows

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Don't download binaries for unsupported windows

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Arch specific paths

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix downloading helm on windows

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* rename once-cell file to lazy-initialized

Signed-off-by: Sebastian Malton <sebastian@malton.name>
2022-03-09 17:51:51 -05:00
Janne SavolainenandMikko Aspiala b65f6e00ec Update injectable library (#4842)
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
2022-02-25 11:10:13 -05:00
Sebastian Malton 600bd659f6 Enforce member-delimiter-style using eslint (#4870) 2022-02-16 14:43:03 -05:00
Jim Ehrismann 9b9b8e0d05 ShellEnv extension api (#4802)
* adding extension api for terminal environment variables

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* modified shell env api to work as a transformer (WIP)

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* address some review comments

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* shell env modifiers now take a CatalogEntity in ShellEnvContext param

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* tweaks and bug fix

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* refactored to remove ShellEnvModifier code from shell-session to local-shell-session

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* further refactoring and documentation

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* added comment

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
2022-02-10 16:01:59 -05:00
Jari Kolehmainen 6ebfd76644 Use system-node-critical priorityClassName for node shell (#4800)
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
2022-02-03 07:37:21 +02:00
Janne Savolainen 589472c2b5 Shorten license header to reduce amount of clutter in top of the files (#4709)
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-01-18 10:18:10 +02:00
Janne Savolainen e1a6d4c4a9 Merge remote-tracking branch 'origin/master' into eliminate-gst-from-app-paths 2022-01-10 17:13:20 +02:00
Sebastian Malton fa3708c879 Add eslint:recommended lint rule (#4577) 2022-01-07 08:38:21 -05:00
Janne SavolainenandMikko Aspiala 9d33fff906 Cascade different refactorings to eliminate global shared state from app paths
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-01-05 13:26:49 +02:00
Sebastian Malton b665a2efe7 Fix freeze after closing terminal on windows (#4536) 2021-12-09 15:52:27 -05:00
Alex Andreev 3dd6b432c9 Export KubeJsonApi to extensions (#4496)
* Export KubeJsonApi to extensions

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Make forCluster() to consume clusterId as arg

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fix lint

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
2021-12-09 15:11:34 +03:00
Sebastian Malton 8c9e3b2fdc Fix cwd not being respected for local shells on windows (#4395) 2021-11-23 14:34:18 -05:00
Sebastian Malton 7c5a0a9a6d Improve local shell CWD setting (#4396) 2021-11-23 08:35:16 -05:00
Sebastian MaltonandJari Kolehmainen 0f2801552f Fix handling of PTYs when renderer is reloaded (#4346)
Co-authored-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
2021-11-17 13:48:46 -05:00
Sebastian Malton c37a8aee0a Correctly catch and notify user about NodeShell pod failures (#4244)
* Correctly catch and notify user about NodeShell pod failures

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix error throwing sometimes during Terminal.detach

Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-11-09 22:52:46 -05:00
Sebastian Malton e5bf5920fc Keep shell processes alive between network offline periods (#4258) 2021-11-09 12:30:55 -05:00
Sebastian Malton 5eb1b8553d Support window nodes for node-shells (#3624)
* Support window nodes for node-shells

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Also check beta.kubernetes/os label

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add comment about linux fallback

Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-11-08 20:11:40 -05:00
Sebastian Malton c09a57370e Block shell websocket connections from non-lens renderers (#4285)
* Block shell websocket connections from non-lens renderers

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Add IPC based authentication tokens

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix race condition on tab start

Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-11-08 19:02:10 -05:00
Sebastian Malton c6dce043a7 Lint: comma-spacing (error) & comma-dangle (error) (#4200)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-11-02 17:38:20 -04:00
Sebastian Malton d132a4c7e7 Fix node shell secret pulling (#3668)
- On some KE errors are thrown if trying to get a secret with an empty
  name, instead of just ignoring the entry

- Clean up the node shell settings

Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-09-01 12:49:00 +03:00
Alexandre Barone 8c5457cf89 Fix broken shell when workdir not exists (#3349)
Signed-off-by: devodev <abalexandrebarone@gmail.com>
2021-07-16 14:07:06 -04:00
Violetta Shakirova 621f5ba0b3 Make node shell image configurable (#3249)
Signed-off-by: vshakirova <vshakirova@mirantis.com>
2021-07-12 11:21:46 -04:00
Sebastian Malton b03eb443c9 Await kubeconfigPathP for fish shell args (#3286)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-07-07 09:20:17 +03:00
Jim Ehrismann 86d0a86ec9 Fix shell-env timeout (#2938) 2021-06-09 14:54:19 -04:00
Sebastian Malton 5ed4537979 Turn on noUnusedLocals, noImplicitReturns, importsNotUsedAsValues: error, and isolatedModules (#2777) 2021-05-19 12:11:54 -04:00
Lauri Nevala 0537792c56 Update node shell to use Alpine 3.13 (#2792)
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
2021-05-18 12:26:29 +03:00
Lauri Nevala e188cf45e6 Delete node shell container on exit (#2793)
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
2021-05-18 12:23:17 +03:00
Jari Kolehmainen 2d0609ed24 Check source files for license header (#2763)
* check source files for license header

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>

* tweak

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>

* add license header to all relevant source files

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
2021-05-12 18:33:26 +03:00
Sebastian Malton afa5379ba9 Flatten user preferences in user store (#2587)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-04-27 09:44:02 -04:00
Jari Kolehmainen 119d584bcb Fix zsh zdotdir (#2640)
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
2021-04-27 15:18:03 +03:00
Sebastian Malton 9563ead2e6 Fixing Singleton typing to correctly return child class (#1914)
- Add distinction between `getInstance` and `getInstanceOrCreate` since
  it is not always possible to create an instance (since you might not
  know the correct arguments)

- Remove all the `export const *Store = *Store.getInstance<*Store>();`
  calls as it defeats the purpose of `Singleton`. Plus with the typing
  changes the appropriate `*Store.getInstance()` is "short enough".

- Special case the two extension export facades to not need to use
  `getInstanceOrCreate`. Plus since they are just facades it is always
  possible to create them.

- Move some other types to be also `Singleton`'s: ExtensionLoader,
  ExtensionDiscovery, ThemeStore, LocalizationStore, ...

- Fixed dev-run always using the same port with electron inspect

- Update Store documentation with new recommendations about creating
  instances of singletons

- Fix all unit tests to create their dependent singletons

Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-04-21 09:59:59 -04:00
Sebastian Malton 743597e2f5 Cleanup shell sessions (#2469)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
2021-04-12 09:51:25 +03:00