hendrik/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity
3,156 Commits 268 Branches 11 Tags 985 MiB
1eb45ac1a4
Commit Graph

35 Commits

Author SHA1 Message Date
Janne Savolainen
1eb45ac1a4 Consolidate output of get-composite-path to match find-composite's input 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-24 09:28:46 +03:00
Iku-turso
20aaaafce3 Adapt application builder and tests to array-like paths over string-like paths 
Array-like paths do not have weakness for special characters as part of id, such as ".".

Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 16:04:17 +03:00
Iku-turso
4c31f4f6a7 Adapt application builder and tests to array-like paths over string-like paths 
Array-like paths do not have weakness for special characters as part of id, such as ".".

Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 15:20:01 +03:00
Janne Savolainen
8f39e86b15
Fix lint error 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:26 +03:00
Janne Savolainen
1a5073caad
Remove duplication from exhaustiveness checks for discriminating unions 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:25 +03:00
Janne Savolainen
dadb53b3e0
Remove dead code 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:24 +03:00
Janne Savolainen
68e38dd0a3
Relocate code under a sub-feature 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:24 +03:00
Janne Savolainen
042ae56ae1
Move code under a feature 
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:23 +03:00
Iku-turso
f88de99511
Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:23 +03:00
Janne Savolainen
95767e9d95
Move utility functions to common 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:21 +03:00
Janne Savolainen
f212c2a86d
Consolidate directory structure of composite 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:21 +03:00
Janne Savolainen
c96f562c69
Consolidate name of function 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Janne Savolainen
638ea2e12e
Clean public interface of a normalize composite 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-21 08:23:20 +03:00
Iku-turso
f48dcba59d
Introduce way to find out if composite has a descendant 
This will serve eg. hiding of empty preference tab groups.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-21 08:23:15 +03:00
Iku-turso
145958364a
Consolidate code to check for updates closer to feature 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-turso
27a94f4132
Rename id of menu item to keep it discoverable by existing extensions 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-turso
2c29fb7e00
Add logging for unrecognizable application menu item types 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-turso
66e4ec1f53
Make registrator for application menu items support all known scenarios 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-turso
9f19fdceb2
Simplify getting of composite paths 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-turso
fc77c41095
Reintroduce non-fatal handling of orphan application menu items 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-turso
db774c18d9
Defend against self-referencing composites 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-turso
822f4394fe
Make composite able to have custom handler for missing parent ids 
This will be useful next for application menu items, where a missing parent id cannot be fatal.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-turso
0e550d496c
Simplify creation of composite 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:18 +03:00
Iku-turso
9c927b7f2d
Update snapshot 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:18 +03:00
Janne Savolainen
a8cc1cd17c
Simplify hierarchy of application menu items using "single-root" composite 
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:39:16 +03:00
Janne Savolainen
159f2bb9c1
Migrate more application menu items to injectables 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:37:59 +03:00
Iku-turso
eba75af764
Implement hierarchy of application menu items using "many-root" composite 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:59 +03:00
Iku-turso
043afc3ac8
Introduce way to create hierarchical composites from a flat array 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:58 +03:00
Iku-turso
3add4255cf
Simplify a test 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:58 +03:00
Iku-turso
3d35ba5c24
Make global override less strict to simplify setup of many unit tests 
There's a better solution for this in the horizon, as this overridden thing is better faked than stubbed.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:28 +03:00
Iku-turso
cf9bf23ac5
Extract menu item for quitting application as injectable 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:14 +03:00
Iku-turso
0b39cc1044
Extract some operation system actions from application menu as injectables 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:14 +03:00
Iku-turso
2446f62da1
Remove duplication from separators in application menu 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:13 +03:00
Iku-turso
31de88dae4
Consolidate separators of application menu in single file 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:13 +03:00
Iku-turso
88ea157352
Migrate some application menu items to injectables 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:36:19 +03:00