* Split out use of httpsProxy preference
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Rename file
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add check for incomplete SelfSubjectRulesReview to fix GKE
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Adding namespaced for KubeApiResource
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactoring of AuthorizationNamespaceReview
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Removing dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactoring ListApiResources
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Extract ClusterContext into deps for KubeObjectStore to fix circular import
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix remaining type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash in frame by consolidating setup into runnables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors and remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix core resources not showing up
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix namespaces not being shown
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Simplify ClusterContext to remove something only NamespaceStore needs
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make sure the public API doesn't change
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix lint
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fixing namespace-select-filter tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix other tests requiring overrides
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix kludge in cluster-frame tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix remaining test failures
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix integration test due to incorrect casting
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix integration test and kube watches not working at all
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix secret details test
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix lint
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix non-ApplicationBuilder tests by adding overrides
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash due to trying to read hostedCluster too soon
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash due to timing issues
- Make injectable phases more explicit for renderer
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Load pods from all namespaces in Node details
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Lint fixes
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Change type of RequestHelmChartValues to be AsyncResult
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Fixing tests
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Linter fix
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Change request readme types to be AsyncResult
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Linter fix
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Replace apiBaseInjectionToken with tokens for configuration instead
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use new ordering to make openNodeShellSession non-special
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Support Events on CustomResourece details panel
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unnecessary check
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacy KubeObjectMeta use from non-metrics details
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change orderNumber of default KubeMetaDetails
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove last use of legacy global getActiveClusterEntity
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactor ResourceMetrics to use IAsyncComputed
- Introduce first use for namespace metrics
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce metrics details item for Ingress
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacyStore for nodes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacyStore for ingresses
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace NodeMetrics in details with injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change namespace metrics details to use more injectables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change ingress metrics details to use more injectables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change PersistentVolumeClaim metrics to be injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change DaemonSet metrics to be injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change Deployment metrics to be injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change Job metrics to be injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert Pod metrics to be injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make ReplicaSet metrics details injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make StatefulSet metrics component injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce fix for metrics components visible on all details
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use the new and correct enabled check
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacy global for daemonSetStore
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch components to be static to help with React performance
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacy store of CronJobs
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make DeploymentReplicaSets injectable to fix build error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix up remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Allow use of ResourceMetrics without IAsyncComputed
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix metrics not updating correctly
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots because moving KubeObjectMeta out of CustomResourceDetails
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update more snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test failures due to newer dep versions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors from new asyncComputed
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove Singleton from BaseStore to remove global shared state
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove more usages of Singleton
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of legacy global execHelm with injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove last use of legacy global execHelm
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Extract BaseStore deps into constructor argument
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce method to make store migrations injectable
- Use it for ClusterStore
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch HotbarStore to injectable migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch UserStore to injectable migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move migration utils into common/utils/
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch WeblinkStore to injectable migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error in base-store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove tests that reference lastSeenVersion
- That value is not used anywhere in code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove usage of legacy global .getInstance
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove usage of legacy global ClusterStore.getInstance
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add simple migrations dependency for stores without any preexisting migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix messed up import
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add typing to transient injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cleanup formatting
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix typing in tests to satisfy requirement to have cacheFile
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* More consistent use of BaseStore.displayName
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add catching of error while starting main application
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move initializing sentry to runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unneeded appPathsInjectionToken
- Only had once impl, which was in common anyway
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add support for multiple "runAfter" runnables
- Needed so that several dependencies can be declared
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use multiple runAfter support to fix crash on renderer
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove traces
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override to fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix base store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix runManyFor tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix hotbar store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix user store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override for getConfigurationFileModel to fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove overrides for configuration stores
- Now that there is an override for getConfiguration
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Overhaul FS fakes with full in-memory filesystem
- This increases our confidence in fs related logic
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove use of global shared Electron.App
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add fake access support
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Handle copy as part of fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add ensureDir/Sync support to fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use pathExistsSync instead of fsInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add createReadStream to fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add stat to fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test failures due to incomplete overrides
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fully injectable-ize BaseStore so that ApplicationBuilder tests work
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Consolidate more bootstrapping into startFrame
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move initializing CatalogCategories to runnable in bootstrap
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert contextMenuOpen initializers into runnables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert navigateForExtension init to runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make cluster state sync fully injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move init hotbar store into runnables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make LensTheme fully injectable and runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cleanup old code from missed from previous commit
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Manually split out terminal color names and fully type LensTheme
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix old imports
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unnecessart awaits
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fully cherry pick injectablizing custom monaco themes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix duplicate mock warning
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix incorrectly fully cherry picking new runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Complete cherry-pick of current cluster injcetablization
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix override file name
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix injecting before app paths are set up
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix injecting before app paths are set up
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix ordering of runnable and order of injection
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert all renderer runnables to late-inject style
- To help fix issues around injection time
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix react-beautiful-dnd mocks
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update and fix WriteJson(Sync) to fix error in tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix HotbarStore.load being called twice is being buggy
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update listing-active-helm-repositories-in-preferences snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix sidebar-and-tab-navigation-tests
- Move enabling extensions in tests to a proper location
- Fix flushing promises
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove props from dnd mock to make snapshot diffs smaller
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix import
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests by overriding things that are no longer overriden by default
- NOTE: They are overridden when using ApplicationBuilder
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix hotbar store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix cluster store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix extension-loader tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix extension-discovery tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix cluster-role-dialog tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix user store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix kubeconfig sync tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix sidebar and tab tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unused code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix pick paths import type error and simplify signature
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error in legacy ipc registration
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove another use of legacy requestOpenPathPicker
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of legacy global PathPicker.Pick
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix usage in light of changed prop names
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix catalog tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix more type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test flakiness by removing side effects from userStore preferences
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix loading
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cherry pick updated startFrameInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add tests to verify runMany behaviour in new possible incorrect configuration
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix init ordering during start frame
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix cluster state sync
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots after removing side-effects
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add override for technical test
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Correctly mark currentlyInClusterFrame as causedSideEffects
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Better formatting
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix behaviour regression
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add better logging
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix BaseStore sync
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update last snapshot
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override for randomBytes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make startMainApplication not an injection time side effect
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Choose better names for start-frame runnable tokens
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove duplication of code in RunManyFor
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add unit tests and fix handling empty runAfter array
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of mobx from runManyFor with custom barrier
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add missing test
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Using custom properties for z-index values
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Reorder values
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Remove unused styles
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Different set of z-index css vars
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Revert z-index to main layout
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
- The bug was that the user would cycle through all the settings viewed
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
- Clean up some of them to use more injectables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash when upgrading release
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash when upgrading helm releases
- Fixes not being able to upgrade helm releases as well.
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test failures
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make ClusterFrameManager fully injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Block renderering non http(s):// links via `<Icon>`
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Still render icon, just without href
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix unit tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add winston formatting support for error causes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix failing to run built version
- Finally make logger fully injectable
- Simplify startMainApplication to only have runMany(Sync) invocations
to fix time of use bugs related to logger
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacy type enforced ipc to fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
- It was only missing for users of newer versions of Kube
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix auto finding logic of preferred versions
- The kube preferred version might not contain the resource requested in
some kube versions. Whereas the resource does exist on some previous
api version
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Simplify getOrderedVersions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Split test file
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix grammer
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of legacy globals with injectables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix error shown to users when load fails
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch CronJob default apiBase
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix jsonPath functions
- Add handling of / shorthand
- Update tests to show new behaviour of safeJSONPathValue so that it is more usable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Defend CRDResourceDetails against bad jsonPaths
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update CRDResources for new behaviour of helper function
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove global version of appEventBus
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce a temporary but better shape of ExecFileInjectable error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move some code for application update to feature directory
The rest of the code could not be moved yet because of work-in-progress refactorings for OCP compliance.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce helper to get a global override for a function-injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract global override-files from bloated getDiForUnitTesting
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Move some more code for application update to feature directory
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce competition for top bar items to achieve OCP-compliance
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for opening context menu using the new competition
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for navigating to home as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for navigating to back as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for navigating to forward as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for application update as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Format code to make ongoing refactoring a bit easier
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add missing unit tests for top bar extendability using extension API
This makes ongoing refactoring easier.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Replace implementation for old top-bar items for losing competition
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for window controls as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce reusable component for spacing between other components
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce helper component to render list of React elements
Features:
- Placeholder for empty list
- Separators between items
- No boilerplate for "key" prop in React
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix double-clicking and dragging of window from top bar
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix stuff broken in rebase
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots after rebase
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make fake time have a default value for "now"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Migrate some application menu items to injectables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate separators of application menu in single file
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove duplication from separators in application menu
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract some operation system actions from application menu as injectables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract menu item for quitting application as injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce way to type narrow a string property
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make the di's for unit testing able to auto-register also named exports
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make global override less strict to simplify setup of many unit tests
There's a better solution for this in the horizon, as this overridden thing is better faked than stubbed.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify a test
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce way to create hierarchical composites from a flat array
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Implement hierarchy of application menu items using "many-root" composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Migrate more application menu items to injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Simplify hierarchy of application menu items using "single-root" composite
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify creation of composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite able to have custom handler for missing parent ids
This will be useful next for application menu items, where a missing parent id cannot be fatal.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Defend against self-referencing composites
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Reintroduce non-fatal handling of orphan application menu items
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make faked, yet weak, typing a bit stronger
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify getting of composite paths
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make registrator for application menu items support all known scenarios
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add logging for unrecognizable application menu item types
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Rename id of menu item to keep it discoverable by existing extensions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate code to check for updates closer to feature
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce reusable horizontal line
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for preferences as a Feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for terminal preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for editor preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for proxy preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for telemetry preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for application preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code related to helm chart preferences under related Feature in preparation for competition
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for kubernetes preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for application preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for editor preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for kubernetes preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for proxy preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add missing observer to make sure component updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for telemetry preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for terminal preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Tweak UI for preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Tweak more UI of preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Revert "Introduce reusable horizontal line"
This reverts commit 4d8c147fe0f1a14bd884f73cf345e7d3a28b954a.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce utility to find exactly one item from array
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for preferences navigation
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code under a Feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove usage of old code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add extensions tab group to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce way to find out if composite has a descendant
This will serve eg. hiding of empty preference tab groups.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make tab groups and tabs in preferences not render when there is no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove code made redundant with hiding of preference tabs without content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Tweak UI for preference navigation tab groups
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce test helper to abstract discovery of HTML elements
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate discovery of HTML elements in some tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt application builder to changes in preference navigation
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt test setup to changes in preference navigation
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove uninteresting technical tests that are covered by behavioural ones
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate discovery of HTML elements in a test
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove test ID made redundant by consolidating discovery of HTML elements
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove duplication from preference pages
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix import
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make queries in element discovery return matching attribute values for easier testing
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make element discovery able to do nested discovery
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make element discovery able to discover without value for attribute
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Implement registrator for preference items
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make styling less brittle by not relying on static HTML-element structures with CSS-rules
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add todo
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove "group" from preference types, as it is exact replica of "item"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Replace usages of react-component factory with actual components for simplicity
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Start considering application preferences as default tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make sense in horizontal lines
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Clean public interface of a normalize composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate name of function
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate directory structure of composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move utility functions to common
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Rename a preference item type to better communicate intent in UI
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move shared UI component to more common place
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate sizing of horizontal line to t-shirts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move application update related preferences under application update feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make winner of competition to use original route for preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make HTML element discovery require less parameters
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code under a feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate navigating to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code under a feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Relocate code under a sub-feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix merge conflicts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix import path after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove duplication from exhaustiveness checks for discriminating unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add TODO
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update link to a more recent article
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify static Showability of a PreferenceItem
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Move general function to general directory
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract responsibility of "separability"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make separator in Map-component know left and right item
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove additional separators when separated items are not shown for having no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix lint error
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt integration test to recent changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt more integration tests to recent changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make composite not care about in formatting of ids
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Adapt application builder and tests to array-like paths over string-like paths
Array-like paths do not have weakness for special characters as part of id, such as ".".
Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite not care about formatting of ids
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Adapt application builder and tests to array-like paths over string-like paths
Array-like paths do not have weakness for special characters as part of id, such as ".".
Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate output of get-composite-path to match find-composite's input
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make global overrides for functions log args of the call for devability
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make attempts to log error throw in unit tests
Errors cannot be allowed to happen without a unit test explicitly causing it. Errors cannot be allowed to happen without author of unit test knowing it.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite not know about how children are transformed
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove some duplication from tests of composite
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite unit test an unrealistic test scenario about undefined ids
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Kill dead code
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify unit tests for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate tests to now point-free composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify "Showable"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make non-shown application menu items not break composite structure
This was made apparent by adding related unit tests for all known environments.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify usages of Orderable and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract being maybe Showable as explicit composable responsibility
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make more showables maybe showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate logic for application menu for Windows to be based on composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Start using named export for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Rename type for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove unnecessary type and value
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composable responsibilities readonly to nudge towards immutability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove a bit of duplication to create TS-constants
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make a comment and test name make more sense
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify fallthrough in a switch/case
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Replace inline styles with proper CSS
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Switch to correct type to indicate "object which might not contain a property"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify overriding of platform in a unit test
Also make typing of platforms more strict, and remove some magic strings.
Also add a TODO for further OCP-ification.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate some "maybe-types" and arguments using them
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
* Save only used selectors from flex.box library
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Remove flex.box dependency
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Passing id to status-bar-items
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Add data-origin prop for status bar items
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Fixing status bar tests
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Update snapshots
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Fix linter
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Rename id -> origin because it is not unique
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Add better type safety around Channels
- Reallow non-JSON serializable complex types
- Remove unnecessary JSON serialization step to IPC
- Remove unnecesary injectable-ization of MessageChannel and
RequestChannel declarations
- Add channel listener injectable getter function to remove general need
for type casting and improve type safety
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add check to verify data in IPC related tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix implementation in light of new safety check in tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix listener ID clash potential
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch to not forcing split of request channel handlers being seperate from the listener decl
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move message channels to changed signature too
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix not registering listener
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test imports
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactor listening of different channel kinds
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add test covering new checking code for request channel handlers
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
- When used in non compact mode (eg KubeObjectMeta's age) the seconds
can be displayed but previously between 10m and 180m of age, the
display would only update every minute
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change notification when extension is not found
- Removes legacy downloadFile and downloadJson in favour of using
`node-fetch`
- A notification will be displayed if the URL provided results in a
status of 404
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Resolve PR comments
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Clickable links in pods details
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
* Make linter happy
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
* Use withInjectables
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
* ServiceAccounts are namespaced
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
* Revert legacy APIs
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
* Make linter happy
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
Signed-off-by: Piotr Roszatycki <piotr.roszatycki@gmail.com>
