1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Commit Graph

12 Commits

Author SHA1 Message Date
Iku-turso
2a7fe6223b Remove a bit of duplication to create TS-constants
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-26 10:59:13 +03:00
Iku-turso
635356517e Remove unnecessary type and value
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 15:22:09 +03:00
Iku-turso
a03a0e9352 Rename type for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 15:14:32 +03:00
Iku-turso
5b916be7c0 Start using named export for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 15:06:23 +03:00
Iku-turso
fc2cf4f457 Simplify usages of Orderable and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 14:39:32 +03:00
Iku-turso
b4f48a30cc Make non-shown application menu items not break composite structure
This was made apparent by adding related unit tests for all known environments.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-24 14:39:32 +03:00
Iku-turso
f88de99511
Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-21 08:23:23 +03:00
Janne Savolainen
95767e9d95
Move utility functions to common
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:21 +03:00
Janne Savolainen
f212c2a86d
Consolidate directory structure of composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-21 08:23:21 +03:00
Iku-turso
fc77c41095
Reintroduce non-fatal handling of orphan application menu items
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:19 +03:00
Iku-turso
0e550d496c
Simplify creation of composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-10-20 08:39:18 +03:00
Janne Savolainen
a8cc1cd17c
Simplify hierarchy of application menu items using "single-root" composite
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-10-20 08:39:16 +03:00