* Renderer file logging through IPC
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Remove pagehide event listener as it may cause UI to freeze
Pagehide was needed in cluster frame to better handle main frame close/reload situation. But even empty pagehide listener in cluster frame seems to freeze the UI at least on some situations (multiple clusters open).
Beforeunload is not always executed in cluster frame when main frame is reloaded/closed, leaving log files open. To fix that, `stopIpcLoggingInjectable` is introduced to close all log files.
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Remove unnecessary formatting changes
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Lint fix
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Winston logger override
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Remove usage of doGeneralOverrides as it has been removed
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Update imports to match the new base
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Remove unnecessary id
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Review improvements
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Extract beforeunload listener to injectable
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Typo fix
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
---------
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
Renderer file logging still caused UI freezing (at least on apple silicon macs) when cluster frame was open and main frame was reloaded.
See #544
This reverts commit ac2d0e46ff.
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Renderer file logging transport
Add file logging to renderer, writing separate log files for renderer main frame and each cluster frame.
Related to lensapp/support-lens-extension#118
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Switch renderer file log level to info
There is too much noise on debug level from api responses etc
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Unmount on pagehide instead of beforeunload
It seems cluster onbeforeunload is not triggered when iframe is removed from dom by the parent (when disconnecting a cluster).
While on root/main frame the beforeunload event does work, it seems to be adviced to use pagehide instead.
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Close log files on unmount
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Improve file handle closing in different situations
This should cover reloading main and cluster frames and closing cluster frame throught disconnecting cluster. No file handles should be left open now.
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Fix renderer log rotation
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Switch back to beforeunload in root frame
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
* Remove capturing phase event usage
Does not seem to be needed for log files to be successfully closed and caused integration tests to fail.
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
---------
Signed-off-by: Sami Tiilikainen <97873007+samitiilikainen@users.noreply.github.com>
