1
0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Commit Graph

7 Commits

Author SHA1 Message Date
Janne Savolainen
5113729e87
Remove unnecessary code style changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-03-31 15:13:33 +03:00
Iku-turso
9a5a210ed3
Migrate to actual typing for di.permitSideEffects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-03-31 15:13:30 +03:00
Iku-turso
03cd6aac87
Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-03-31 15:13:29 +03:00
Iku-turso
9c024b98d3
Require id for <Select /> to prevent non-deterministic renders
This was caused by global state in a 3rd party lib: "react-select".

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
2022-03-31 15:13:28 +03:00
Janne Savolainen
5c8ca2c038
Implement a lot of technical requirements for behavioural unit tests
Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced.

Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables.

Note: another chunk of global shared state is no more.

Note: a lot of explicit side effects have been cornered to injectables.

Note: a lot of stuff has become reactive as part if this.

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
2022-03-31 15:13:26 +03:00
Alex Andreev
dd5dfb393d
Add 'Sync with computer' theme option (#4973) 2022-03-09 08:08:24 -05:00
Dmitriy Noa
769a9441f8
Fix unselect. Add unit tests (#4961)
* Fix unselect. Add unit tests

Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>

* Cleanup

Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>

* Add additional test for undefined

Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
2022-03-04 10:09:15 +01:00