hendrik/lens
1
0 Fork 0
mirror of https://github.com/lensapp/lens.git synced 2025-05-20 05:10:56 +00:00
Code Issues Projects Releases Wiki Activity
3,165 Commits 268 Branches 11 Tags
7048683c146921a02b7f00347c14203b8389919b
Commit Graph
3165 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Janne SavolainenandMikko Aspiala 943bc6db77 Introduce competition for terminal preference tab 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:39:21 +03:00
Janne SavolainenandMikko Aspiala aa90e8e7d2 Introduce competition for preferences as a Feature 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:39:21 +03:00
Janne SavolainenandMikko Aspiala dfaf90a39f Introduce reusable horizontal line 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:39:21 +03:00
Iku-tursoandJanne Savolainen 145958364a Consolidate code to check for updates closer to feature 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 27a94f4132 Rename id of menu item to keep it discoverable by existing extensions 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 2c29fb7e00 Add logging for unrecognizable application menu item types 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 66e4ec1f53 Make registrator for application menu items support all known scenarios 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen 9f19fdceb2 Simplify getting of composite paths 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:20 +03:00
Iku-tursoandJanne Savolainen f2e6ce22aa Make faked, yet weak, typing a bit stronger 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen fc77c41095 Reintroduce non-fatal handling of orphan application menu items 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen db774c18d9 Defend against self-referencing composites 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen 822f4394fe Make composite able to have custom handler for missing parent ids 
This will be useful next for application menu items, where a missing parent id cannot be fatal.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:19 +03:00
Iku-tursoandJanne Savolainen 0e550d496c Simplify creation of composite 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:18 +03:00
Iku-tursoandJanne Savolainen 9c927b7f2d Update snapshot 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:39:18 +03:00
Janne SavolainenandMikko Aspiala a8cc1cd17c Simplify hierarchy of application menu items using "single-root" composite 
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:39:16 +03:00
Janne SavolainenandMikko Aspiala 159f2bb9c1 Migrate more application menu items to injectables 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:37:59 +03:00
Iku-tursoandJanne Savolainen eba75af764 Implement hierarchy of application menu items using "many-root" composite 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:59 +03:00
Iku-tursoandJanne Savolainen 043afc3ac8 Introduce way to create hierarchical composites from a flat array 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:58 +03:00
Iku-tursoandJanne Savolainen 3add4255cf Simplify a test 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:58 +03:00
Iku-tursoandJanne Savolainen 3d35ba5c24 Make global override less strict to simplify setup of many unit tests 
There's a better solution for this in the horizon, as this overridden thing is better faked than stubbed.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:28 +03:00
Iku-tursoandJanne Savolainen 55ad4ffcae Make the di's for unit testing able to auto-register also named exports 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:28 +03:00
Iku-tursoandJanne Savolainen a811b0948f Introduce way to type narrow a string property 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:14 +03:00
Iku-tursoandJanne Savolainen cf9bf23ac5 Extract menu item for quitting application as injectable 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:14 +03:00
Iku-tursoandJanne Savolainen 0b39cc1044 Extract some operation system actions from application menu as injectables 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:14 +03:00
Iku-tursoandJanne Savolainen 2446f62da1 Remove duplication from separators in application menu 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:13 +03:00
Iku-tursoandJanne Savolainen 31de88dae4 Consolidate separators of application menu in single file 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:37:13 +03:00
Iku-tursoandJanne Savolainen 88ea157352 Migrate some application menu items to injectables 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:36:19 +03:00
Iku-tursoandJanne Savolainen 18c2cdf851 Make fake time have a default value for "now" 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:36:00 +03:00
Iku-tursoandJanne Savolainen c7c45e017a Update snapshots after rebase 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:36:00 +03:00
Iku-tursoandJanne Savolainen 5ed014e69f Fix stuff broken in rebase 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:59 +03:00
Janne SavolainenandMikko Aspiala 415f1a830b Update snapshots 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:35:59 +03:00
Janne SavolainenandMikko Aspiala 2d97f2313b Fix double-clicking and dragging of window from top bar 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:35:59 +03:00
Janne SavolainenandMikko Aspiala 76991b59e6 Introduce helper component to render list of React elements 
Features:
- Placeholder for empty list
- Separators between items
- No boilerplate for "key" prop in React

Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:35:59 +03:00
Janne SavolainenandMikko Aspiala 43e0c49f06 Introduce reusable component for spacing between other components 
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>

Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
 2022-10-20 08:35:58 +03:00
Iku-tursoandJanne Savolainen d7de5ce467 Extract top menu item for window controls as OCP 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:58 +03:00
Iku-tursoandJanne Savolainen 23aeb96679 Replace implementation for old top-bar items for losing competition 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:58 +03:00
Iku-tursoandJanne Savolainen ba6c349b5e Add missing unit tests for top bar extendability using extension API 
This makes ongoing refactoring easier.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:58 +03:00
Iku-tursoandJanne Savolainen 1030135c9b Format code to make ongoing refactoring a bit easier 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:58 +03:00
Iku-tursoandJanne Savolainen b14400dd65 Extract top menu item for application update as OCP 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:57 +03:00
Iku-tursoandJanne Savolainen b8b14d82c3 Extract top menu item for navigating to forward as OCP 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:57 +03:00
Iku-tursoandJanne Savolainen c132ceaf2b Extract top menu item for navigating to back as OCP 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:57 +03:00
Iku-tursoandJanne Savolainen 7eacdd164b Extract top menu item for navigating to home as OCP 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:57 +03:00
Iku-tursoandJanne Savolainen 43443759dd Extract top menu item for opening context menu using the new competition 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:56 +03:00
Iku-tursoandJanne Savolainen b23453ffda Introduce competition for top bar items to achieve OCP-compliance 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:56 +03:00
Iku-tursoandJanne Savolainen a38c213ba2 Move some more code for application update to feature directory 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:54 +03:00
Iku-tursoandJanne Savolainen fcd181af30 Extract global override-files from bloated getDiForUnitTesting 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:46 +03:00
Iku-tursoandJanne Savolainen 6e155953d9 Introduce helper to get a global override for a function-injectable 
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:46 +03:00
Iku-tursoandJanne Savolainen 97e04632ca Move some code for application update to feature directory 
The rest of the code could not be moved yet because of work-in-progress refactorings for OCP compliance.

Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>

Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
 2022-10-20 08:35:44 +03:00
Sebastian Malton 024c5ee52c Require milestones on PRs before merging (#6431) 
* Require milestones on PRs before merging

Signed-off-by: Sebastian Malton <sebastian@malton.name>
 2022-10-19 14:00:04 -04:00
Sebastian Malton 7e6751bf38 Add automatic workflow for bumping version on master (#6429) 
Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>
 2022-10-19 12:10:37 -04:00