- The cwd field was being overridden unconditionally by the new getConfigurationFileModelInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* adding https_proxy to execHelm env
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
* lint plus simplification
Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
* Add NoMetrics style module
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Add Open Cluster Settings link
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Fine-tune NoMetrics layout
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Add test for clicking Open Settings link
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Add data-testid
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Fixing tests
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Use navigateToEntitySettings instead of broadcastMessage
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Fix test selector
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* - maintenance: upgrade react-select to latest version (5+)
- fix: props.styles was ignored and didn't passed to original react-select component from abstraction wrapper
* Update snapshots after merging stuff to master
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix code style
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
This reverts commit ecd881c25df219b511d7efd43dac59e748b21cc7.
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix removing hot bar item
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix navigating back to tab in catalog from hotbar
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add tooltipLabels field to ChartData
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Use tooltipLabels in ClusterPieCharts for pods
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Check for tooltipLabels field to assign tooltip text
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Use tooltipLabels inside overview charts
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Expand workload overview charts to fit tooltips
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Move tooltipLabels into chart datasets
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Move tooltipLabels prop to PieCharts
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Little clean up
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Getting back id field to PieChartData interface
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Id fix
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* More clean up
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Move devserver to different port
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
* Move port to common vars
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
* Use Number to cast
Signed-off-by: DmitriyNoa <dmytro.zharkov@gmail.com>
* Clean up Menu DOM elements
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Clean up Tooltip DOM
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Do not render Animate when not in need
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Update snapshots
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* clean up <Animate/> and <Tooltip/>
Signed-off-by: Roman <ixrock@gmail.com>
Co-authored-by: Roman <ixrock@gmail.com>
* Getting this context for switch hotbar methods
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Do not convert store methods to arrow functions
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
* Implement a lot of technical requirements for behavioural unit tests
Note: the crux of this was to make routing env-agnostic, and not based on URLs as magic strings, but instead something type-enforced.
Note: extension-based routes comply to same exact interface by "late-registering" their routes when installed. Routes are just injectables.
Note: another chunk of global shared state is no more.
Note: a lot of explicit side effects have been cornered to injectables.
Note: a lot of stuff has become reactive as part if this.
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make a directory commonly available
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Require id for <Select /> to prevent non-deterministic renders
This was caused by global state in a 3rd party lib: "react-select".
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Specify id for all <Select /> to satisfy previous commit
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Prevent explicit side effect in component by using existing dependency instead
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract instantiation of "conf" as injectables for causing side effects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce a legacy-helper to make gradual refactoring of inheritors of Singleton easier
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make legacy unit tests for hotbar green and more simple by using the new legacy helper
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Temporarily kludge all unit tests green with a disclaimer about allowing side-effects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove kludge in previous commit by explicitly permitting specific side effects where old unit tests require it
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Prevent old unit test with side effects from accessing file system
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Migrate to actual typing for di.permitSideEffects
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Prevent unit tests from failing because of non-standard method of HTML-element not present in js-dom
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Adapt integration tests to recent changes
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Fix code style
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Fix artifact from bad rebase
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add a deprecation from a review comment
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove change that is not required
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove redundant comment
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix code style
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove redundant file
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix bad merge
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Improve variable name
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Tweak logger interface to be more descriptive
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make injecting legacy singleton always provide new instance
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove conditional typing when not needed
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Improve naming of variable
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove unnecessary code style changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove flag for causing side effects from too broad scope
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Override side-effects in unit test using injectable instead of monkey patching
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Flag some side-effects and add general overrides
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Fix unit tests in CI by removing explicit side-effect
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove explicit side-effect from getting default shell
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce abstraction for getting absolute paths
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using abstraction for getting absolute path to control explicit side effect
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce abstraction for joining paths
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using abstraction for joining paths to control explicit side effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix fake implementation for join paths
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix test after removing explicit side effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove explicit side effects from kubeconfig-syncs
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix arguments after removing explicit side effect
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make registrators not async for not being needed anymore
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make generalCatalogEntities non-observable, as there is no requirement
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove redundant code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify logic for registering general catalog entity sources
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Replace function for getting application menu items with reactive solution
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix typo in interface name
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove global shared state usages of hot bar store
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove redundant enum
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
* Add links for ingresses
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add back the arrow service
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Only display link if host is defined
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Resolve PR comments
- Fix crash in IngressDetails
- Make ingress routes scrollable
- Don't display link if the URL contains "*"
- Consolidate rendering of rules to all use the same transform function
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix http(s) formatting and add some tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix exception in KubeStore.watch event buffer handling
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* always preload app fonts at earliest stages, fix#5019
Signed-off-by: Roman <ixrock@gmail.com>
* attempt to fix tests, clean up
Signed-off-by: Roman <ixrock@gmail.com>
