* unify build fs layout
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* use currentApp path for static files
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* lint fix
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* allow to import open-lens
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* allow to customize both main & renderer
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix compile-library script
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* remove bundled extensions
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* similar interface for both main & renderer
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* use startApp on both sides
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix startApp import
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix startApp import
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* Fix injection cycle (somehow)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* use cwd in download_binaries
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* introduce applicationInformationToken
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* register applicationInformationInjectable in main & renderer
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* allow to define bundled extensions via appStart
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* compile node-fetch automatically via prepare
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* define peerDependencies
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* webpack fixes
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* rename application-information-token.injectable.ts -> application-information-token.ts
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* monaco-editor as externals
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* refactor application-information
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* introduce bundledExtensionInjectionToken
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* mark library exports as experimental
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* move extension npm package files & add release automation
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* add missing build files to package
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix bad merge conflict resolve
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix package.json name
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* allow to set mode via startApp
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* revert unnecessary changes
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* webpack: fix extensionOutDir
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* remove unnecessary peerDependencies
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* introduce nodeEnvInjectionToken
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* remove NODE_ENV from environmentVariablesInjectable
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix jest modulePathIgnorePatterns
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix duplicate injectable registration
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
* fix build executableName
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
* Switch bundled extension declarations to injection token
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change how bundled extensions are loaded
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix token file name
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix spelling
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Improve interface name
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make request-api-resources flatter in implementation
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* More improvements to requestApiResources
- Also move files to better places
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Rename iter.pipeline as iter.chain
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add check for incomplete SelfSubjectRulesReview to fix GKE
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Adding namespaced for KubeApiResource
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactoring of AuthorizationNamespaceReview
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Removing dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactoring ListApiResources
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Extract ClusterContext into deps for KubeObjectStore to fix circular import
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix remaining type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash in frame by consolidating setup into runnables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors and remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix core resources not showing up
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix namespaces not being shown
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Simplify ClusterContext to remove something only NamespaceStore needs
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make sure the public API doesn't change
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix lint
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fixing namespace-select-filter tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix other tests requiring overrides
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix kludge in cluster-frame tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix remaining test failures
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix integration test due to incorrect casting
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix integration test and kube watches not working at all
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix secret details test
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix lint
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix non-ApplicationBuilder tests by adding overrides
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash due to trying to read hostedCluster too soon
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash due to timing issues
- Make injectable phases more explicit for renderer
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace apiBaseInjectionToken with tokens for configuration instead
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use new ordering to make openNodeShellSession non-special
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove Singleton from BaseStore to remove global shared state
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove more usages of Singleton
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of legacy global execHelm with injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove last use of legacy global execHelm
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Extract BaseStore deps into constructor argument
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce method to make store migrations injectable
- Use it for ClusterStore
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch HotbarStore to injectable migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch UserStore to injectable migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move migration utils into common/utils/
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch WeblinkStore to injectable migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error in base-store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove tests that reference lastSeenVersion
- That value is not used anywhere in code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove usage of legacy global .getInstance
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove usage of legacy global ClusterStore.getInstance
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add simple migrations dependency for stores without any preexisting migrations
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix messed up import
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add typing to transient injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cleanup formatting
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix typing in tests to satisfy requirement to have cacheFile
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* More consistent use of BaseStore.displayName
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add catching of error while starting main application
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move initializing sentry to runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unneeded appPathsInjectionToken
- Only had once impl, which was in common anyway
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add support for multiple "runAfter" runnables
- Needed so that several dependencies can be declared
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use multiple runAfter support to fix crash on renderer
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove traces
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override to fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix base store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix runManyFor tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix hotbar store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix user store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override for getConfigurationFileModel to fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove overrides for configuration stores
- Now that there is an override for getConfiguration
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Overhaul FS fakes with full in-memory filesystem
- This increases our confidence in fs related logic
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove use of global shared Electron.App
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add fake access support
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Handle copy as part of fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add ensureDir/Sync support to fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use pathExistsSync instead of fsInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add createReadStream to fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add stat to fake FS
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test failures due to incomplete overrides
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fully injectable-ize BaseStore so that ApplicationBuilder tests work
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Consolidate more bootstrapping into startFrame
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move initializing CatalogCategories to runnable in bootstrap
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert contextMenuOpen initializers into runnables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert navigateForExtension init to runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make cluster state sync fully injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move init hotbar store into runnables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make LensTheme fully injectable and runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cleanup old code from missed from previous commit
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Manually split out terminal color names and fully type LensTheme
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix old imports
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unnecessart awaits
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fully cherry pick injectablizing custom monaco themes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix duplicate mock warning
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix incorrectly fully cherry picking new runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Complete cherry-pick of current cluster injcetablization
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix override file name
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix injecting before app paths are set up
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix injecting before app paths are set up
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix ordering of runnable and order of injection
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert all renderer runnables to late-inject style
- To help fix issues around injection time
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix react-beautiful-dnd mocks
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update and fix WriteJson(Sync) to fix error in tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix HotbarStore.load being called twice is being buggy
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update listing-active-helm-repositories-in-preferences snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix sidebar-and-tab-navigation-tests
- Move enabling extensions in tests to a proper location
- Fix flushing promises
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove props from dnd mock to make snapshot diffs smaller
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix import
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests by overriding things that are no longer overriden by default
- NOTE: They are overridden when using ApplicationBuilder
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix hotbar store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix cluster store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix extension-loader tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix extension-discovery tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix cluster-role-dialog tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix user store tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix kubeconfig sync tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix sidebar and tab tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove unused code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix pick paths import type error and simplify signature
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error in legacy ipc registration
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove another use of legacy requestOpenPathPicker
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of legacy global PathPicker.Pick
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix usage in light of changed prop names
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix catalog tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix more type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test flakiness by removing side effects from userStore preferences
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix loading
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cherry pick updated startFrameInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add tests to verify runMany behaviour in new possible incorrect configuration
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix init ordering during start frame
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix cluster state sync
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots after removing side-effects
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add override for technical test
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Correctly mark currentlyInClusterFrame as causedSideEffects
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Better formatting
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix behaviour regression
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add better logging
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix BaseStore sync
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update last snapshot
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override for randomBytes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make startMainApplication not an injection time side effect
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Choose better names for start-frame runnable tokens
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove duplication of code in RunManyFor
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add unit tests and fix handling empty runAfter array
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace use of mobx from runManyFor with custom barrier
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add missing test
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
- Errors from "request" package (and thus the "@kubernetes/client-node"
package too) contain a "response" field which is very large and has
redundent information on it
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
- Clean up some of them to use more injectables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Stop using source code in build file
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add new injectable version of binaryName
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add new NormalizedPlatform type
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch legacy execHelm to use legacy global DI for binaryPath
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce injectable for kube auth proxy certs
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce injectable forms of PrometheusProviders
- Remove class requirement
- Make everything injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update tests to not use private functions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Cleanup creating binary names and paths
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move files to be under a feature folder
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add error notification on shell sync failure
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Improve error handling of case where match is not found
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash when upgrading release
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash when upgrading helm releases
- Fixes not being able to upgrade helm releases as well.
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test failures
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove mac-ca usage since it was only in tests (#6043)
* Make injecting CAs injectable, remove mac-ca as dependency
* Fix win-ca failing on electron renderer on windows
* Fix the matcher under features/ for main
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors from new types
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Temp change to see windows errors on CI
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix temp change
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Change error message for windows
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Increase maxBuffer size when reading windows CAs
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch back to running integration tests on windows
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix usage after rebase
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update lock file
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* fix: getAllowedResources for all namespaces using SelfSubjectRulesReview
Signed-off-by: Andreas Hippler <andreas.hippler@goto.com>
* fix: refresh accessibility every 15 min
Signed-off-by: Andreas Hippler <andreas.hippler@goto.com>
* chore: remove unused clusterRefreshHandler
Signed-off-by: Andreas Hippler <andreas.hippler@goto.com>
* fix: resolve SelfSubjectRulesReview globs
Signed-off-by: Andreas Hippler <andreas.hippler@goto.com>
Signed-off-by: Andreas Hippler <andreas.hippler@goto.com>
Co-authored-by: Andreas Hippler <andreas.hippler@goto.com>
* Make ClusterFrameManager fully injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix not using the users configured shell for sync
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix issue with use of userShellSetting in ShellSessions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add winston formatting support for error causes
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix failing to run built version
- Finally make logger fully injectable
- Simplify startMainApplication to only have runMany(Sync) invocations
to fix time of use bugs related to logger
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacy type enforced ipc to fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Upgrade to latest node-fetch
- Introduce injection tokens for retriving the implementation of
node-fetch via await import() calls
- Add webpack file for compiling node-fetch to electron-renderer single
file format
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update lock file
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add type packages which were removed for some reason
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add more dev @types deps that weren't added last time
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Simpify by using webpack to create a commonjs package
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix build for integration tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix unit tests on CI not having all deps
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Revert accidental timeout change
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace manually specifying nodeJS externals with preset
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert runManyFor to use composite
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert runManySyncFor to use composite and to enfore sync-ness
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove dead code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert getStartableStoppable to be always sync as it is never used in an async fashion
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert all sync runnables to comply with new checks for sync-ness
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix syncing shell environment when using fish
- Add some better logging for the future
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add some unit tests to codify assumptions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix timeout
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix handling of '' in env
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add function description
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove global version of appEventBus
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce a temporary but better shape of ExecFileInjectable error
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move some code for application update to feature directory
The rest of the code could not be moved yet because of work-in-progress refactorings for OCP compliance.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce helper to get a global override for a function-injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract global override-files from bloated getDiForUnitTesting
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Move some more code for application update to feature directory
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce competition for top bar items to achieve OCP-compliance
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for opening context menu using the new competition
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for navigating to home as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for navigating to back as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for navigating to forward as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for application update as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Format code to make ongoing refactoring a bit easier
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add missing unit tests for top bar extendability using extension API
This makes ongoing refactoring easier.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Replace implementation for old top-bar items for losing competition
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract top menu item for window controls as OCP
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce reusable component for spacing between other components
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce helper component to render list of React elements
Features:
- Placeholder for empty list
- Separators between items
- No boilerplate for "key" prop in React
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix double-clicking and dragging of window from top bar
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix stuff broken in rebase
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots after rebase
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make fake time have a default value for "now"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Migrate some application menu items to injectables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate separators of application menu in single file
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove duplication from separators in application menu
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract some operation system actions from application menu as injectables
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract menu item for quitting application as injectable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce way to type narrow a string property
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make the di's for unit testing able to auto-register also named exports
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make global override less strict to simplify setup of many unit tests
There's a better solution for this in the horizon, as this overridden thing is better faked than stubbed.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify a test
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce way to create hierarchical composites from a flat array
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Implement hierarchy of application menu items using "many-root" composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Migrate more application menu items to injectables
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Simplify hierarchy of application menu items using "single-root" composite
Also solve composed typing of application menu by using Discriminated Unions of TypeScript, see: https://www.typescriptlang.org/docs/handbook/2/narrowing.html#discriminated-unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify creation of composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite able to have custom handler for missing parent ids
This will be useful next for application menu items, where a missing parent id cannot be fatal.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Defend against self-referencing composites
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Reintroduce non-fatal handling of orphan application menu items
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make faked, yet weak, typing a bit stronger
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify getting of composite paths
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make registrator for application menu items support all known scenarios
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add logging for unrecognizable application menu item types
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Rename id of menu item to keep it discoverable by existing extensions
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate code to check for updates closer to feature
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Introduce reusable horizontal line
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for preferences as a Feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for terminal preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for editor preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for proxy preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for telemetry preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for application preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code related to helm chart preferences under related Feature in preparation for competition
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for kubernetes preference tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for application preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for editor preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for kubernetes preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for proxy preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add missing observer to make sure component updates
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for telemetry preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Switch to using competition for terminal preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Tweak UI for preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Tweak more UI of preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Revert "Introduce reusable horizontal line"
This reverts commit 4d8c147fe0f1a14bd884f73cf345e7d3a28b954a.
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce utility to find exactly one item from array
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce competition for preferences navigation
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code under a Feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove usage of old code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add extensions tab group to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce way to find out if composite has a descendant
This will serve eg. hiding of empty preference tab groups.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make tab groups and tabs in preferences not render when there is no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove code made redundant with hiding of preference tabs without content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Tweak UI for preference navigation tab groups
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Introduce test helper to abstract discovery of HTML elements
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Kill dead code
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate discovery of HTML elements in some tests
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt application builder to changes in preference navigation
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt test setup to changes in preference navigation
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove uninteresting technical tests that are covered by behavioural ones
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate discovery of HTML elements in a test
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove test ID made redundant by consolidating discovery of HTML elements
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove duplication from preference pages
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix import
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make queries in element discovery return matching attribute values for easier testing
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make element discovery able to do nested discovery
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make element discovery able to discover without value for attribute
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Implement registrator for preference items
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make styling less brittle by not relying on static HTML-element structures with CSS-rules
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Add todo
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove "group" from preference types, as it is exact replica of "item"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Replace usages of react-component factory with actual components for simplicity
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Start considering application preferences as default tab
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate naming
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make sense in horizontal lines
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Clean public interface of a normalize composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate name of function
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate directory structure of composite
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move utility functions to common
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Rename a preference item type to better communicate intent in UI
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move shared UI component to more common place
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate sizing of horizontal line to t-shirts
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move application update related preferences under application update feature
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make winner of competition to use original route for preferences
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make HTML element discovery require less parameters
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Extract "composable-responsibilities" for Discriminable, Labelable, Orderable, and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshot
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code under a feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Consolidate navigating to preferences
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Move code under a feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Relocate code under a sub-feature
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add TODO
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove dead code
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix merge conflicts
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update snapshots after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix import path after rebase
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Remove duplication from exhaustiveness checks for discriminating unions
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Add TODO
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Update link to a more recent article
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify static Showability of a PreferenceItem
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Move general function to general directory
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract responsibility of "separability"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make separator in Map-component know left and right item
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove additional separators when separated items are not shown for having no content
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots
Co-authored-by: Mikko Aspiala <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix lint error
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt integration test to recent changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Adapt more integration tests to recent changes
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
* Make composite not care about in formatting of ids
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Adapt application builder and tests to array-like paths over string-like paths
Array-like paths do not have weakness for special characters as part of id, such as ".".
Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite not care about formatting of ids
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Adapt application builder and tests to array-like paths over string-like paths
Array-like paths do not have weakness for special characters as part of id, such as ".".
Also note: the error messaging for clicking of application menu in application builder is a bit worse now I think, but the simplification of the test code is worth it in this case IMHO.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate output of get-composite-path to match find-composite's input
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make global overrides for functions log args of the call for devability
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make attempts to log error throw in unit tests
Errors cannot be allowed to happen without a unit test explicitly causing it. Errors cannot be allowed to happen without author of unit test knowing it.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite not know about how children are transformed
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove some duplication from tests of composite
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composite unit test an unrealistic test scenario about undefined ids
Also make the thrown error suggest how to fix the problem.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Kill dead code
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify unit tests for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate tests to now point-free composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify "Showable"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make non-shown application menu items not break composite structure
This was made apparent by adding related unit tests for all known environments.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify usages of Orderable and Showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Extract being maybe Showable as explicit composable responsibility
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make more showables maybe showable
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate logic for application menu for Windows to be based on composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Start using named export for composite
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Rename type for accuracy
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove unnecessary type and value
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make composable responsibilities readonly to nudge towards immutability
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Remove a bit of duplication to create TS-constants
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Make a comment and test name make more sense
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify fallthrough in a switch/case
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Replace inline styles with proper CSS
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Switch to correct type to indicate "object which might not contain a property"
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Simplify overriding of platform in a unit test
Also make typing of platforms more strict, and remove some magic strings.
Also add a TODO for further OCP-ification.
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Consolidate some "maybe-types" and arguments using them
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Update snapshots
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Signed-off-by: Janne Savolainen <janne.savolainen@live.fi>
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
* Fix manually set prometheus service address to work after re-connect
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
* Fix manually set prometheus service address to work after re-connect
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
* Setup prometheus also on contenxt handler constructor
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
* Fix syncing shell env on TCSH and CSH
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactor computeUnixShellEnvironment to be clearer
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add better type safety around Channels
- Reallow non-JSON serializable complex types
- Remove unnecessary JSON serialization step to IPC
- Remove unnecesary injectable-ization of MessageChannel and
RequestChannel declarations
- Add channel listener injectable getter function to remove general need
for type casting and improve type safety
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add check to verify data in IPC related tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix implementation in light of new safety check in tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix listener ID clash potential
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch to not forcing split of request channel handlers being seperate from the listener decl
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move message channels to changed signature too
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix not registering listener
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test imports
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix type errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Refactor listening of different channel kinds
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add test covering new checking code for request channel handlers
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix windows shell not having all environment variables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix startup due to buildVersion dependency
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Call cleanup in computeShellEnvironment
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix loading helm release details
- The helm manifest can sometimes contain KubeJsonApiDataLists
instead of just KubeJsonApiData entries
- Add additional logging to main for when a route handler throws so that
we can gain more context in the future
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix usage of getHelmReleaseResources
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add test to verify handling of Lists being returned
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
- Includes local fixes that are required by the new code
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Making apiBase injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert all of Helm functions to be DI
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make PortForward's use of apiBase fully injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert all metric requests to be injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace resource applier with injectables
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch KubeJsonApi.forCluster to be injectable but do not use
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert the rest of shell sessions to be DI-ed
- This is a prerequesit for using the new
createKubeJsonApiForClusterInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Use new createKubeJsonApiForClusterInjectable for openNodeShellSession
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make KubeconfigDialog injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove jest-fetch-mock and make fetch injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests with new global override
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add new injectable for create KubeJsonApi and JsonApi instances
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix showing-details-for-helm-release behavioural tests
- Remove HelmChartStore in favour of all injectables
- Create a model for UpgradeChartDockTab
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix show details and updating helm releases tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix residual typing issues related to metrics
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash on load due to circular dependency
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix create resource tab not working
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove legacy apiBase global
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce and use isDebuggingInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce and use windowLocationInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove global legacy apiKube
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Improve injectable filenames compared to the injectables inside
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove modifying input in requestActivePortForwardInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Introduce and use get(Milli)SecondsFromUnixEpochInjectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Switch to non-reactive way of gettting possible helm release versions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix typo
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix bug in KubeApi constructor
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert all KubeApi related tests to use asyncFn
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix unit tests after introducing new injectables that have side effects
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix bad rebase causing tests to fail
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Improve expects for multiple field values
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix crash will looking up api refs
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix breaking change on KubeApi.list
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Better fix for formatting urls
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove injectable for time since we should just use useMockTime
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add happy path behavioural tests for upgrade chart tab
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Remove debug message
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* fix showing-details-for-helm-release tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix installing-helm-chart-from-new-tab tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests relating to hosted cluster id
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots to recent changes in master
Co-authored-by: Janne Savolainen <janne.savolainen@live.fi>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
* Reupdated upgrade chart new tab test snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix flakiness in unit test when using <Animated>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix flakiness and improve tests for DeleteClusterDialog
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix kubeconfig-sync tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix <Extensions> tests by removing mockFs and making everything injectable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix build issues
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix getElectronAppPathInjectable override not returning absolute paths
- Also fixes the listing-active-helm-repos-in-prefs tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Replace all uses of getAbsolutePath with joinPaths as it is more correct and less confusing
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix opening application window tests by making override properly absolute
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots relating no longer using getAbsolutePath
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix and add behavioural tests for RenderDelay
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix extension discovery tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix test flakiness because of path side effects, propagate uses to as many places
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix extension-discovery tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override to fix some tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Rewrite and fix implementation of KubeconfigManager and its tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests by global override pathExists
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix unit tests failing on windows by using injectable verions of path functions
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Attempt to fix test timeout by using runInAction
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots after rebase
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots after rebase
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix tests after rebase
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix setupIpcMainHandlers usage
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Update snapshots
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Iku-turso <mikko.aspiala@gmail.com>
Co-authored-by: Iku-turso <mikko.aspiala@gmail.com>
* Make injecting CAs injectable, remove mac-ca as dependency
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix win-ca failing on electron renderer on windows
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix the matcher under features/ for main
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix lint
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Convert ReleaseChannel into an InitializableState
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix init timing for DefaultUpdateChannel
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Make UserStore loading seperate from creation to fix initialization timing errors
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix overrides of UserStore
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Fix UserStore tests
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Move userStoreFileMigration call to the init runnable
Signed-off-by: Sebastian Malton <sebastian@malton.name>
* Add global override for userStoreFileMigratiom
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
